NOMERGE emoji_reaction: Pass explicitChildNodes: true in a Semantics container

chrisbobbe · chrisbobbe · commit 8379f6dfb874 · 2025-08-19T21:03:00.000-07:00
This fixes a test failure when we make an upcoming refactor. (The
container node's label would apparently have its children's labels
appended to it...I haven't seen that behavior in manual testing on
my iPhone with VoiceOver, before or after that refactor, but, shrug;
this change does seem correct anyway.)
diff --git a/lib/widgets/emoji_reaction.dart b/lib/widgets/emoji_reaction.dart
@@ -1032,6 +1032,7 @@ class ViewReactionsUserList extends StatelessWidget {
       label: zulipLocalizations.seeWhoReactedSheetUserListLabel(emojiName, userIds.length),
       role: SemanticsRole.tabPanel,
       container: true,
+      explicitChildNodes: true,
       child: result);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1032,6 +1032,7 @@ class ViewReactionsUserList extends StatelessWidget {`
`1032`	`1032`	`label: zulipLocalizations.seeWhoReactedSheetUserListLabel(emojiName, userIds.length),`
`1033`	`1033`	`role: SemanticsRole.tabPanel,`
`1034`	`1034`	`container: true,`
	`1035`	`+ explicitChildNodes: true,`
`1035`	`1036`	`child: result);`
`1036`	`1037`	`}`
`1037`	`1038`	`}`