autocomplete: Introduce AutocompleteViewManager._autocompleteViews

This set replaces the three sets of different `AutocompleteView`
subclasses into one, simplifying the code.

Author: sm-sayedi

lib/model/autocomplete.dart

@@ -206,39 +206,17 @@ class AutocompleteIntent<QueryT extends AutocompleteQuery> {
 ///
 /// On reassemble, call [reassemble].
 class AutocompleteViewManager {
-  final Set<MentionAutocompleteView> _mentionAutocompleteViews = {};
-  final Set<TopicAutocompleteView> _topicAutocompleteViews = {};
-  final Set<EmojiAutocompleteView> _emojiAutocompleteViews = {};
+  final Set<AutocompleteView> _autocompleteViews = {};
 
   AutocompleteDataCache autocompleteDataCache = AutocompleteDataCache();
 
-  void registerMentionAutocomplete(MentionAutocompleteView view) {
-    final added = _mentionAutocompleteViews.add(view);
+  void registerAutocomplete(AutocompleteView view) {
+    final added = _autocompleteViews.add(view);
     assert(added);
   }
 
-  void unregisterMentionAutocomplete(MentionAutocompleteView view) {
-    final removed = _mentionAutocompleteViews.remove(view);
-    assert(removed);
-  }
-
-  void registerTopicAutocomplete(TopicAutocompleteView view) {
-    final added = _topicAutocompleteViews.add(view);
-    assert(added);
-  }
-
-  void unregisterTopicAutocomplete(TopicAutocompleteView view) {
-    final removed = _topicAutocompleteViews.remove(view);
-    assert(removed);
-  }
-
-  void registerEmojiAutocomplete(EmojiAutocompleteView view) {
-    final added = _emojiAutocompleteViews.add(view);
-    assert(added);
-  }
-
-  void unregisterEmojiAutocomplete(EmojiAutocompleteView view) {
-    final removed = _emojiAutocompleteViews.remove(view);
+  void unregisterAutocomplete(AutocompleteView view) {
+    final removed = _autocompleteViews.remove(view);
     assert(removed);
   }
 
@@ -263,10 +241,7 @@ class AutocompleteViewManager {
   /// Calls [AutocompleteView.reassemble] for all that are registered.
   ///
   void reassemble() {
-    for (final view in _mentionAutocompleteViews) {
-      view.reassemble();
-    }
-    for (final view in _topicAutocompleteViews) {
+    for (final view in _autocompleteViews) {
       view.reassemble();
     }
   }
@@ -307,6 +282,7 @@ abstract class AutocompleteView<QueryT extends AutocompleteQuery, ResultT extend
   /// and begin the search for the initial query.
   AutocompleteView({required this.store, required QueryT query})
       : _query = query {
+    store.autocompleteViewManager.registerAutocomplete(this);
     _startSearch();
   }
 
@@ -417,6 +393,15 @@ abstract class AutocompleteView<QueryT extends AutocompleteQuery, ResultT extend
     }
     return false;
   }
+
+  @override
+  void dispose() {
+    store.autocompleteViewManager.unregisterAutocomplete(this);
+    // We cancel in-progress computations by checking [hasListeners] between tasks.
+    // After [super.dispose] is called, [hasListeners] returns false.
+    // TODO test that logic (may involve detecting an unhandled Future rejection; how?)
+    super.dispose();
+  }
 }
 
 /// An [AutocompleteView] for an autocomplete interaction
@@ -441,16 +426,14 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
     required Narrow narrow,
     required MentionAutocompleteQuery query,
   }) {
-    final view = MentionAutocompleteView._(
+    return MentionAutocompleteView._(
       store: store,
       query: query,
       localizations: localizations,
       narrow: narrow,
       sortedUsers: _usersByRelevance(store: store, narrow: narrow),
       sortedUserGroups: _userGroupsByRelevance(store: store),
     );
-    store.autocompleteViewManager.registerMentionAutocomplete(view);
-    return view;
   }
 
   final Narrow narrow;
@@ -709,15 +692,6 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
   MentionAutocompleteResult? _testUserGroup(MentionAutocompleteQuery query, UserGroup userGroup) {
     return query.testUserGroup(userGroup, store);
   }
-
-  @override
-  void dispose() {
-    store.autocompleteViewManager.unregisterMentionAutocomplete(this);
-    // We cancel in-progress computations by checking [hasListeners] between tasks.
-    // After [super.dispose] is called, [hasListeners] returns false.
-    // TODO test that logic (may involve detecting an unhandled Future rejection; how?)
-    super.dispose();
-  }
 }
 
 /// A query the user has entered into some form of autocomplete.
@@ -1153,11 +1127,8 @@ class TopicAutocompleteView extends AutocompleteView<TopicAutocompleteQuery, Top
     required int streamId,
     required TopicAutocompleteQuery query,
   }) {
-    final view = TopicAutocompleteView._(
-      store: store, streamId: streamId, query: query);
-    store.autocompleteViewManager.registerTopicAutocomplete(view);
-    view._fetch();
-    return view;
+    return TopicAutocompleteView._(store: store, streamId: streamId, query: query)
+      .._fetch();
   }
 
   /// The channel/stream the eventual message will be sent to.
@@ -1199,12 +1170,6 @@ class TopicAutocompleteView extends AutocompleteView<TopicAutocompleteQuery, Top
     }
     return null;
   }
-
-  @override
-  void dispose() {
-    store.autocompleteViewManager.unregisterTopicAutocomplete(this);
-    super.dispose();
-  }
 }
 
 /// A query for autocompleting a topic to send to,

lib/model/emoji.dart

@@ -481,9 +481,7 @@ class EmojiAutocompleteView extends AutocompleteView<EmojiAutocompleteQuery, Emo
     required PerAccountStore store,
     required EmojiAutocompleteQuery query,
   }) {
-    final view = EmojiAutocompleteView._(store: store, query: query);
-    store.autocompleteViewManager.registerEmojiAutocomplete(view);
-    return view;
+    return EmojiAutocompleteView._(store: store, query: query);
   }
 
   @override