api: Make UserSettings.displayEmojiReactionUsers required

chrisbobbe · chrisbobbe · commit 13a2447dc448 · 2025-10-03T17:33:58.000-07:00
Fixes-partly: #1837
diff --git a/lib/api/model/initial_snapshot.dart b/lib/api/model/initial_snapshot.dart
@@ -282,7 +282,7 @@ class UserSettings {
   )
   TwentyFourHourTimeMode twentyFourHourTime;
 
-  bool? displayEmojiReactionUsers; // TODO(server-6)
+  bool displayEmojiReactionUsers;
   Emojiset emojiset;
   bool presenceEnabled;
 
diff --git a/lib/api/model/initial_snapshot.g.dart b/lib/api/model/initial_snapshot.g.dart
diff --git a/lib/widgets/emoji_reaction.dart b/lib/widgets/emoji_reaction.dart
@@ -130,7 +130,7 @@ class ReactionChipsList extends StatelessWidget {
   Widget build(BuildContext context) {
     final zulipLocalizations = ZulipLocalizations.of(context);
     final store = PerAccountStoreWidget.of(context);
-    final displayEmojiReactionUsers = store.userSettings.displayEmojiReactionUsers ?? false;
+    final displayEmojiReactionUsers = store.userSettings.displayEmojiReactionUsers;
     final showNames = displayEmojiReactionUsers && reactions.total <= 3;
 
     Widget result = Wrap(spacing: 4, runSpacing: 4, crossAxisAlignment: WrapCrossAlignment.center,

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ class UserSettings {`
`282`	`282`	`)`
`283`	`283`	`TwentyFourHourTimeMode twentyFourHourTime;`
`284`	`284`
`285`		`- bool? displayEmojiReactionUsers; // TODO(server-6)`
	`285`	`+ bool displayEmojiReactionUsers;`
`286`	`286`	`Emojiset emojiset;`
`287`	`287`	`bool presenceEnabled;`
`288`	`288`