Get route-transition duration robustly

Author: MdSaifAliMolla

test/widgets/action_sheet_test.dart

@@ -140,7 +140,8 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
   // like if it's in padding around a Paragraph.
   await tester.longPress(find.byType(MessageContent), warnIfMissed: false);
   // sheet appears onscreen; default duration of bottom-sheet enter animation
-  await tester.pump(const Duration(milliseconds: 250));
+  await transitionDurationObserver.pumpPastTransition(tester);
+
   // Check the action sheet did in fact open, so we don't defeat any tests that
   // use simple `find.byIcon`-style checks to test presence/absence of a button.
   check(find.byType(BottomSheet)).findsOne();
@@ -199,19 +200,22 @@ void main() {
       check(find.byType(InboxPageBody)).findsOne();
 
       await tester.longPress(find.text(someChannel.name).hitTestable());
-      await tester.pump(const Duration(milliseconds: 250));
+      await transitionDurationObserver.pumpPastTransition(tester);
     }
 
     Future<void> showFromSubscriptionList(WidgetTester tester) async {
+      final transitionDurationObserver = TransitionDurationObserver();
+
       await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
+        navigatorObservers: [transitionDurationObserver],
         child: const HomePage()));
       await tester.pump();
       await tester.tap(find.byIcon(ZulipIcons.hash_italic));
       await tester.pump();
       check(find.byType(SubscriptionListPageBody)).findsOne();
 
       await tester.longPress(find.text(someChannel.name).hitTestable());
-      await tester.pump(const Duration(milliseconds: 250));
+      await transitionDurationObserver.pumpPastTransition(tester);
     }
 
     Future<void> showFromMsglistAppBar(WidgetTester tester, {
@@ -220,6 +224,8 @@ void main() {
     }) async {
       channel ??= someChannel;
 
+      final transitionDurationObserver = TransitionDurationObserver();
+
       connection.prepare(json: eg.newestGetMessagesResult(
         foundOldest: true, messages: []).toJson());
       if (narrow case ChannelNarrow()) {
@@ -229,31 +235,35 @@ void main() {
       }
       await tester.pumpWidget(TestZulipApp(
         accountId: eg.selfAccount.id,
+        navigatorObservers: [transitionDurationObserver],
         child: MessageListPage(
           initNarrow: narrow)));
       await tester.pumpAndSettle();
 
       await tester.longPress(find.descendant(
         of: find.byType(ZulipAppBar),
         matching: find.text(channel.name)));
-      await tester.pump(const Duration(milliseconds: 250));
+      await transitionDurationObserver.pumpPastTransition(tester);
     }
 
     Future<void> showFromRecipientHeader(WidgetTester tester, {
       StreamMessage? message,
     }) async {
       message ??= someMessage;
 
+      final transitionDurationObserver = TransitionDurationObserver();
+
       connection.prepare(json: eg.newestGetMessagesResult(
         foundOldest: true, messages: [message]).toJson());
       await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
+        navigatorObservers: [transitionDurationObserver],
         child: const MessageListPage(initNarrow: CombinedFeedNarrow())));
       await tester.pumpAndSettle();
 
       await tester.longPress(find.descendant(
         of: find.byType(RecipientHeader),
         matching: find.text(message.displayRecipient ?? '')));
-      await tester.pump(const Duration(milliseconds: 250));
+      await transitionDurationObserver.pumpPastTransition(tester);
     }
 
     Future<void> showFromTopicListAppBar(WidgetTester tester, {int? streamId}) async {
@@ -739,7 +749,7 @@ void main() {
 
       await tester.longPress(find.text(topic));
       // sheet appears onscreen; default duration of bottom-sheet enter animation
-      await tester.pump(const Duration(milliseconds: 250));
+      await transitionDurationObserver.pumpPastTransition(tester);
     }
 
     Future<void> showFromAppBar(WidgetTester tester, {
@@ -766,8 +776,7 @@ void main() {
           effectiveTopic.displayName ?? eg.defaultRealmEmptyTopicDisplayName));
       await tester.longPress(topicRow);
       // sheet appears onscreen; default duration of bottom-sheet enter animation
-      await tester.pump(const Duration(milliseconds: 250));
-    }
+      await transitionDurationObserver.pumpPastTransition(tester);    }
 
     Future<void> showFromRecipientHeader(WidgetTester tester, {
       StreamMessage? message,
@@ -785,7 +794,7 @@ void main() {
         of: find.byType(RecipientHeader),
         matching: find.text(effectiveMessage.topic.displayName!)));
       // sheet appears onscreen; default duration of bottom-sheet enter animation
-      await tester.pump(const Duration(milliseconds: 250));
+      await transitionDurationObserver.pumpPastTransition(tester);
     }
 
     final actionSheetFinder = find.byType(BottomSheet);
@@ -2037,29 +2046,62 @@ void main() {
         check(await Clipboard.getData('text/plain')).isNotNull().text.equals('Hello world');
       });
 
-      testWidgets('can show snackbar on success', (tester) async {
-        // Regression test for: https://github.com/zulip/zulip-flutter/issues/732
-        testBinding.deviceInfoResult = const IosDeviceInfo(systemVersion: '16.0');
-
+     testWidgets('success', (tester) async {
         final message = eg.streamMessage();
         await setupToMessageActionSheet(tester, message: message, narrow: TopicNarrow.ofMessage(message));
 
-        // Make the request take a bit of time to complete…
-        prepareRawContentResponseSuccess(message: message, rawContent: 'Hello world',
-          delay: const Duration(milliseconds: 500));
+        prepareRawContentResponseSuccess(message: message, rawContent: 'Hello world');
         await tapCopyMessageTextButton(tester);
-        // … and pump a frame to finish the NavigationState.pop animation…
-        await tester.pump(const Duration(milliseconds: 250));
-        // … before the request finishes.  This is the repro condition for #732.
-        await tester.pump(const Duration(milliseconds: 250));
+        await tester.pump(Duration.zero);
+        check(await Clipboard.getData('text/plain')).isNotNull().text.equals('Hello world');
+      });
 
-        final snackbar = tester.widget<SnackBar>(find.byType(SnackBar));
-        check(snackbar.behavior).equals(SnackBarBehavior.floating);
-        final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
-        tester.widget(find.descendant(matchRoot: true,
+    testWidgets('can show snackbar on success', (WidgetTester tester) async {
+      // Regression test for: https://github.com/zulip/zulip-flutter/issues/732
+      final TransitionDurationObserver transitionDurationObserver = TransitionDurationObserver();
+      await tester.pumpWidget(
+        MaterialApp(
+          navigatorObservers: <NavigatorObserver>[transitionDurationObserver],
+          home: Scaffold(
+            body: Builder(
+              builder: (context) {
+                testBinding.deviceInfoResult = const IosDeviceInfo(systemVersion: '16.0');
+                final message = eg.streamMessage();
+                setupToMessageActionSheet(
+                  tester,
+                  message: message,
+                  narrow: TopicNarrow.ofMessage(message),
+                );
+                return const SizedBox.shrink();
+              },
+            ),
+          ),
+        ),
+      );
+      final message = eg.streamMessage();
+       // Make the request take a bit of time to complete
+      prepareRawContentResponseSuccess(
+        message: message,
+        rawContent: 'Hello world',
+        delay: const Duration(milliseconds: 500),
+      );
+      await tapCopyMessageTextButton(tester);
+      await transitionDurationObserver.pumpPastTransition(tester);  // … and pump a frame to finish the NavigationState.pop animation…
+      await transitionDurationObserver.pumpPastTransition(tester); // … before the request finishes.  This is the repro condition for #732.
+
+      final snackbar = tester.widget<SnackBar>(find.byType(SnackBar));
+      check(snackbar.behavior).equals(SnackBarBehavior.floating);
+
+      final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
+      tester.widget(
+        find.descendant(
+          matchRoot: true,
           of: find.byWidget(snackbar.content),
-          matching: find.text(zulipLocalizations.successMessageTextCopied)));
-      });
+          matching: find.text(zulipLocalizations.successMessageTextCopied),
+        ),
+      );
+    });
+
 
       testWidgets('request has an error', (tester) async {
         final message = eg.streamMessage();
@@ -2283,7 +2325,7 @@ void main() {
             // See comment in setupToMessageActionSheet about warnIfMissed: false
             await tester.longPress(find.byType(MessageContent), warnIfMissed: false);
             // sheet appears onscreen; default duration of bottom-sheet enter animation
-            await tester.pump(const Duration(milliseconds: 250));
+            await transitionDurationObserver.pumpPastTransition(tester);
             check(find.byType(BottomSheet)).findsOne();
             checkButtonIsPresent(expected);