renderer: addContextMenu should not require index as an argument.

We also replace pending getDomain() removals in favour of
getDomainById() in this commit. We add a new function called
removeDomainById as well.

Author: shubham-padia

app/renderer/js/main.ts

@@ -441,14 +441,14 @@ export class ServerManagerView {
   initServerActions(): void {
     const $serverImgs: NodeListOf<HTMLImageElement> =
       document.querySelectorAll(".server-icons");
-    for (const [index, $serverImg] of $serverImgs.entries()) {
-      this.addContextMenu($serverImg, index);
+    for (const $serverImg of $serverImgs) {
+      this.addContextMenu($serverImg);
       if ($serverImg.src === defaultIcon) {
-        this.displayInitialCharLogo($serverImg, index);
+        this.displayInitialCharLogo($serverImg);
       }
 
       $serverImg.addEventListener("error", () => {
-        this.displayInitialCharLogo($serverImg, index);
+        this.displayInitialCharLogo($serverImg);
       });
     }
   }
@@ -500,11 +500,7 @@ export class ServerManagerView {
     return tab instanceof ServerTab ? (await tab.webview).properties.url : "";
   }
 
-  displayInitialCharLogo($img: HTMLImageElement, index: number): void {
-    // The index parameter is needed because webview[data-tab-id] can
-    // increment beyond the size of the sidebar org array and throw an
-    // error
-
+  displayInitialCharLogo($img: HTMLImageElement): void {
     const $altIcon = document.createElement("div");
     const $parent = $img.parentElement!;
     const $container = $parent.parentElement!;
@@ -525,7 +521,7 @@ export class ServerManagerView {
     $img.remove();
     $parent.append($altIcon);
 
-    this.addContextMenu($altIcon, index);
+    this.addContextMenu($altIcon);
   }
 
   sidebarHoverEvent(
@@ -818,8 +814,8 @@ export class ServerManagerView {
     }
   }
 
-  async isLoggedIn(index: number): Promise<boolean> {
-    const tab = this.tabs[index];
+  async isLoggedIn(tabId: string): Promise<boolean> {
+    const tab = this.getTabById(tabId);
     if (!(tab instanceof ServerTab)) return false;
     const webview = await tab.webview;
     const url = webview.getWebContents().getURL();
@@ -830,9 +826,16 @@ export class ServerManagerView {
     return this.tabs.find((tab) => tab.properties.tabId === tabId);
   }
 
-  addContextMenu($serverImg: HTMLElement, index: number): void {
+  addContextMenu($serverImg: HTMLElement): void {
     $serverImg.addEventListener("contextmenu", async (event) => {
       event.preventDefault();
+      const tabElement = $serverImg.closest(".tab");
+      const tabId =
+        tabElement instanceof HTMLElement
+          ? tabElement.dataset.tabId
+          : undefined;
+      if (tabId === undefined) return;
+
       const template = [
         {
           label: t.__("Disconnect organization"),
@@ -846,11 +849,11 @@ export class ServerManagerView {
               ),
             });
             if (response === 0) {
-              if (DomainUtil.removeDomain(index)) {
+              if (DomainUtil.removeDomainById(tabId)) {
                 ipcRenderer.send("reload-full-app");
               } else {
                 const {title, content} = Messages.orgRemovalError(
-                  DomainUtil.getDomain(index).url,
+                  DomainUtil.getDomainById(tabId)!.url,
                 );
                 dialog.showErrorBox(title, content);
               }
@@ -859,19 +862,19 @@ export class ServerManagerView {
         },
         {
           label: t.__("Notification settings"),
-          enabled: await this.isLoggedIn(index),
+          enabled: await this.isLoggedIn(tabId),
           click: async () => {
             // Switch to tab whose icon was right-clicked
-            const tab = this.tabs[index];
-            await this.activateTab(tab.properties.tabId);
+            const tab = this.getTabById(tabId);
+            await this.activateTab(tabId);
             if (tab instanceof ServerTab)
               (await tab.webview).showNotificationSettings();
           },
         },
         {
           label: t.__("Copy Zulip URL"),
           click() {
-            clipboard.writeText(DomainUtil.getDomain(index).url);
+            clipboard.writeText(DomainUtil.getDomainById(tabId)!.url);
           },
         },
       ];

app/renderer/js/pages/preference/connected-org-section.ts

@@ -48,11 +48,10 @@ export function initConnectedOrgSection({
   // Show noServerText if no servers are there otherwise hide it
   $existingServers.textContent = servers.length === 0 ? noServerText : "";
 
-  for (const [i, server] of servers.entries()) {
+  for (const server of servers) {
     initServerInfoForm({
       $root: $serverInfoContainer,
       server,
-      index: i,
       id: server.id,
       onChange: reloadApp,
     });

app/renderer/js/pages/preference/server-info-form.ts

@@ -11,7 +11,6 @@ import * as DomainUtil from "../../utils/domain-util.ts";
 type ServerInfoFormProperties = {
   $root: Element;
   server: ServerConfig;
-  index: number;
   id: string;
   onChange: () => void;
 };
@@ -59,13 +58,14 @@ export function initServerInfoForm(properties: ServerInfoFormProperties): void {
       message: t.__("Are you sure you want to disconnect this organization?"),
     });
     if (response === 0) {
-      if (DomainUtil.removeDomain(properties.index)) {
+      if (DomainUtil.removeDomainById(properties.id)) {
         ipcRenderer.send("reload-full-app");
       } else {
-        const {title, content} = Messages.orgRemovalError(
-          DomainUtil.getDomain(properties.index).url,
-        );
-        dialog.showErrorBox(title, content);
+        const domain = DomainUtil.getDomainById(properties.id);
+        if (domain) {
+          const {title, content} = Messages.orgRemovalError(domain.url);
+          dialog.showErrorBox(title, content);
+        }
       }
     }
   });

app/renderer/js/utils/domain-util.ts

@@ -82,13 +82,6 @@ export function getDomains(): ServerConfig[] {
   }
 }
 
-export function getDomain(index: number): ServerConfig {
-  reloadDatabase();
-  return serverConfigSchema.parse(
-    database.getObject<unknown>(`/domains[${index}]`),
-  );
-}
-
 export function getDomainById(id: string): ServerConfig | undefined {
   return getDomains().find((server) => server.id === id);
 }
@@ -121,8 +114,13 @@ export function removeDomains(): void {
   reloadDatabase();
 }
 
-export function removeDomain(index: number): boolean {
-  if (EnterpriseUtil.isPresetOrg(getDomain(index).url)) {
+export function removeDomainById(id: string): boolean {
+  const index = getDomains().findIndex((domain) => domain.id === id);
+  if (index === -1) {
+    return false;
+  }
+
+  if (EnterpriseUtil.isPresetOrg(getDomainById(id)!.url)) {
     return false;
   }