domain: Add getDomainById and updateDomainById.

Use id instead of index to get and update domain. We remove updateDomain
in this commit but not getDomain since it is being used in other places,
where it will be easier to remove when changing the encompassing
functions to use id instead of index.

Author: shubham-padia

app/renderer/js/main.ts

@@ -332,7 +332,7 @@ export class ServerManagerView {
         (async () => {
           const serverConfig = await DomainUtil.updateSavedServer(
             server.url,
-            i,
+            server.id,
           );
           tab.setLabel(serverConfig.alias);
           tab.setIcon(DomainUtil.iconAsUrl(serverConfig.icon));
@@ -1072,7 +1072,7 @@ export class ServerManagerView {
             const tab = this.tabs[index];
             if (tab instanceof ServerTab) tab.setLabel(realmName);
             domain.alias = realmName;
-            DomainUtil.updateDomain(index, domain);
+            DomainUtil.updateDomainById(domain.id, domain);
             // Update the realm name also on the Window menu
             ipcRenderer.send("update-menu", {
               tabs: this.tabsForIpc,
@@ -1094,7 +1094,7 @@ export class ServerManagerView {
               if (tab instanceof ServerTab)
                 tab.setIcon(DomainUtil.iconAsUrl(localIconPath));
               domain.icon = localIconPath;
-              DomainUtil.updateDomain(index, domain);
+              DomainUtil.updateDomainById(domain.id, domain);
             }
           }),
         );

app/renderer/js/utils/domain-util.ts

@@ -89,9 +89,13 @@ export function getDomain(index: number): ServerConfig {
   );
 }
 
-export function updateDomain(index: number, server: ServerConfig): void {
-  reloadDatabase();
-  serverConfigSchema.parse(server);
+export function getDomainById(id: string): ServerConfig | undefined {
+  return getDomains().find((server) => server.id === id);
+}
+
+export function updateDomainById(id: string, server: ServerConfig): void {
+  const index = getDomains().findIndex((domain) => domain.id === id);
+  assert.ok(index !== -1, `Domain with id ${id} not found`);
   database.push(`/domains[${index}]`, server, true);
 }
 
@@ -164,10 +168,10 @@ export async function saveServerIcon(iconURL: string): Promise<string> {
 
 export async function updateSavedServer(
   url: string,
-  index: number,
+  id: string,
 ): Promise<ServerConfig> {
   // Does not promise successful update
-  const serverConfig = getDomain(index);
+  const serverConfig = getDomainById(id)!;
   const oldIcon = serverConfig.icon;
   try {
     const newServerSetting = await checkDomain(url, true);
@@ -178,7 +182,7 @@ export async function updateSavedServer(
     const localIconUrl = await saveServerIcon(newServerConfig.icon);
     if (!oldIcon || localIconUrl !== defaultIconSentinel) {
       newServerConfig.icon = localIconUrl;
-      updateDomain(index, newServerConfig);
+      updateDomainById(id, newServerConfig);
       reloadDatabase();
     }