more linting fixes

Author: Aitchessbee

app/renderer/js/main.ts

@@ -7,6 +7,8 @@ import {Menu, app, dialog, session} from "@electron/remote";
 import * as remote from "@electron/remote";
 import * as Sentry from "@sentry/electron/renderer";
 
+import Sortable from "sortablejs";
+
 import type {Config} from "../../common/config-util.js";
 import * as ConfigUtil from "../../common/config-util.js";
 import * as DNDUtil from "../../common/dnd-util.js";
@@ -28,7 +30,6 @@ import {initializeTray} from "./tray.js";
 import {ipcRenderer} from "./typed-ipc-renderer.js";
 import * as DomainUtil from "./utils/domain-util.js";
 import ReconnectUtil from "./utils/reconnect-util.js";
-import Sortable from "sortablejs";
 
 Sentry.init({});
 
@@ -242,11 +243,11 @@ export class ServerManagerView {
       animation: 150,
       onEnd: (event: Sortable.SortableEvent) => {
         // Update the domain order in the database
-        DomainUtil.updateDomainOrder(event.oldIndex || 0, event.newIndex || 0);
+        DomainUtil.updateDomainOrder(event.oldIndex ?? 0, event.newIndex ?? 0);
 
         // Update the current active tab index
-        this.activeTabIndex = event.newIndex || 0;
-        ConfigUtil.setConfigItem("lastActiveTab", event.newIndex || 0);
+        this.activeTabIndex = event.newIndex ?? 0;
+        ConfigUtil.setConfigItem("lastActiveTab", event.newIndex ?? 0);
 
         // Reload the app to give the tabs their new indexes
         ipcRenderer.send("reload-full-app");

app/renderer/js/utils/domain-util.ts

@@ -73,17 +73,17 @@ export function updateDomain(index: number, server: ServerConf): void {
 }
 
 export function updateDomainOrder(oldIndex: number, newIndex: number) {
-  let domains = serverConfSchema
+  const domains = serverConfSchema
     .array()
     .parse(db.getObject<unknown>("/domains"));
 
   const [movedDomain] = domains.splice(oldIndex, 1);
   domains.splice(newIndex, 0, movedDomain);
 
   // Update each domain in the database with its new order
-  domains.forEach((domain, index) => {
+  for (const [index, domain] of domains.entries()) {
     updateDomain(index, domain);
-  });
+  }
 }
 
 export async function addDomain(server: {