Fix: Crash in API<21 due to tinting of drawables using ColorStateList.

Fixes: #431

Author: nitish1211

app/src/main/java/com/zulip/android/activities/ZulipActivity.java

@@ -1365,6 +1365,9 @@ private void setupFab() {
         fab = (FloatingActionButton) findViewById(R.id.fab);
         chatBox = (SwipeRemoveLinearLayout) findViewById(R.id.messageBoxContainer);
         chatBox.registerToSwipeEvents(this);
+        addFileBtn.setColorFilter(getResources().getColorStateList(R.color.colorTextSecondary).getColorForState(addFileBtn.getDrawableState(), 0));
+        sendBtn.setColorFilter(getResources().getColorStateList(R.color.colorTextSecondary).getColorForState(sendBtn.getDrawableState(), 0));
+        togglePrivateStreamBtn.setColorFilter(getResources().getColorStateList(R.color.colorTextSecondary).getColorForState(togglePrivateStreamBtn.getDrawableState(), 0));
         fabHidder = new CountDownTimer(Constants.HIDE_FAB_AFTER_SEC * 1000, Constants.HIDE_FAB_AFTER_SEC * 1000) {
             public void onTick(long millisUntilFinished) {
             }

app/src/main/java/com/zulip/android/util/ListDialog.java

@@ -8,6 +8,7 @@
 import android.os.Bundle;
 import android.view.LayoutInflater;
 import android.view.View;
+import android.widget.ImageView;
 
 import com.zulip.android.R;
 
@@ -55,6 +56,12 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
         View rootView = inflater.inflate(R.layout.list_dialog, null);
         View cameraListItem = rootView.findViewById(R.id.picture_dialog);
         View fileListItem = rootView.findViewById(R.id.pick_file_dialog);
+        ImageView cameraImage =(ImageView) rootView.findViewById(R.id.camera_share_icon);
+        ImageView fileImage =(ImageView) rootView.findViewById(R.id.file_share_icon);
+
+        //Add proper colorState tinting to the camera and fileList Icons
+        cameraImage.setColorFilter(getResources().getColorStateList(R.color.colorTextSecondary).getColorForState(cameraImage.getDrawableState(), 0));
+        fileImage.setColorFilter(getResources().getColorStateList(R.color.colorTextSecondary).getColorForState(fileImage.getDrawableState(), 0));
 
         // if device doesn't have camera, disable camera option
         if (!getActivity().getPackageManager().hasSystemFeature(PackageManager.FEATURE_CAMERA)) {

app/src/main/res/layout/chatbox.xml

@@ -38,8 +38,7 @@
             android:layout_height="wrap_content"
             android:contentDescription="@string/stream_private_content_desp"
             android:padding="3dp"
-            android:src="@drawable/ic_action_person"
-            android:tint="@color/colorTextSecondary" />
+            android:src="@drawable/ic_action_person" />
     </LinearLayout>
 
     <LinearLayout
@@ -58,8 +57,7 @@
             android:paddingLeft="8dp"
             android:paddingRight="4dp"
             android:paddingTop="4dp"
-            android:src="@drawable/ic_add_circle_outline_black_24dp"
-            android:tint="@color/colorTextSecondary" />
+            android:src="@drawable/ic_add_circle_outline_black_24dp" />
 
         <AutoCompleteTextView
             android:id="@+id/message_et"
@@ -78,8 +76,7 @@
             android:alpha="0.7"
             android:contentDescription="@string/send_content_desp"
             android:padding="4dp"
-            android:src="@drawable/ic_send_24dp"
-            android:tint="@color/colorTextSecondary" />
+            android:src="@drawable/ic_send_24dp" />
 
     </LinearLayout>
 

app/src/main/res/layout/list_dialog.xml

@@ -10,11 +10,11 @@
         android:layout_marginBottom="16dp"
         android:orientation="horizontal">
     <ImageView
+        android:id="@+id/camera_share_icon"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_gravity="center_vertical"
         android:src="@drawable/ic_photo_camera_black_24dp"
-        android:tint="?attr/colorControlNormal"
         android:alpha="0.7"/>
     <TextView
         android:layout_width="wrap_content"
@@ -33,11 +33,11 @@
         android:orientation="horizontal"
         android:layout_marginTop="8dp">
     <ImageView
+        android:id="@+id/file_share_icon"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_gravity="center_vertical"
         android:src="@drawable/ic_insert_drive_file_black_24dp"
-        android:tint="?attr/colorControlNormal"
         android:alpha="0.7"/>
     <TextView
         android:layout_width="wrap_content"