Finish DevAuthActivity first then finish LoginActivity to login to Zulip Activity

Author: kunall17

app/src/main/java/com/zulip/android/activities/DevAuthActivity.java

@@ -28,7 +28,7 @@
 public class DevAuthActivity extends Activity implements LoginInterface {
     private RecyclerView recyclerView;
     private ProgressDialog connectionProgressDialog;
-
+    public static final int ADD_REALM_REQUEST = 566;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {

app/src/main/java/com/zulip/android/activities/LoginActivity.java

@@ -1,5 +1,6 @@
 package com.zulip.android.activities;
 
+import android.app.Activity;
 import android.app.ProgressDialog;
 import android.content.DialogInterface;
 import android.content.Intent;
@@ -44,6 +45,8 @@
 import java.net.URISyntaxException;
 import java.util.List;
 
+import static com.zulip.android.activities.DevAuthActivity.ADD_REALM_REQUEST;
+
 /**
  * Activity to Login through various backends on a specified server.
  * Currently supported LoginAuths are Emailbackend and DevAuthBackend.
@@ -126,6 +129,11 @@ protected void onActivityResult(int requestCode, int resultCode, Intent intent)
                 GoogleSignInResult result = Auth.GoogleSignInApi.getSignInResultFromIntent(intent);
                 handleSignInResult(result);
                 break;
+            case ADD_REALM_REQUEST:
+                if (resultCode == Activity.RESULT_OK) {
+                    setResult(Activity.RESULT_OK, intent);
+                    finish();
+                }
             default:
                 break;
         }
@@ -171,7 +179,7 @@ private void checkForError() {
             }
         }
     }
-    
+
 
     private void showBackends(String httpScheme, String serverURL) {
         Uri serverUri = Uri.parse(serverURL);

app/src/main/java/com/zulip/android/networking/AsyncDevGetEmails.java

@@ -13,6 +13,9 @@
 import org.json.JSONException;
 import org.json.JSONObject;
 
+
+import static com.zulip.android.activities.DevAuthActivity.ADD_REALM_REQUEST;
+
 /**
  * A background task which asynchronously fetches the Emails (Admins or Users) for the devAuthBackend
  * Mainly used Development builds.
@@ -51,7 +54,7 @@ protected void onPostExecute(String result) {
                 intent.putExtra(REALM_NAME_JSON, realmName);
                 intent.putExtra(SERVER_URL_JSON, serverURL);
                 intent.putExtra(ADD_REALM_BOOLEAN_JSON, startedFromAddRealm);
-                context.startActivity(intent);
+                ((LoginActivity) context).startActivityForResult(intent, ADD_REALM_REQUEST);
             }
         } catch (JSONException e) {
             ZLog.logException(e);

app/src/main/java/com/zulip/android/networking/AsyncLogin.java

@@ -92,7 +92,14 @@ protected void onPostExecute(String result) {
 
     private void loginThroughAddRealm(JSONObject jsonObject) {
         try {
-            Intent intent = new Intent(context, ZulipActivity.class);
+            Intent intent = null;
+            //This is done to start ZulipActivity from DevAuthActivity which cannot be done directly as DevAuthActivity was called from LoginActivity
+            //And Therefore we have to finish two activities (DevAuthActivity and LoginActivity) if started from DevAuthActivity.
+            if (context instanceof DevAuthActivity) {
+                intent = new Intent();
+            } else if (context instanceof LoginActivity) {
+                intent = new Intent(context, ZulipActivity.class);
+            }
             intent.putExtra("realmName", realmName);
             intent.putExtra("api_key", jsonObject.getString("api_key"));
             intent.putExtra("email", username);