Updated based on comments

Author: koziodigitalinc

app/src/main/java/com/zulip/android/ZulipApp.java

@@ -267,7 +267,7 @@ public UserConfigurationResponse read(JsonReader in) throws IOException {
                                     currentPerson.setId(foundPerson.getId());
                                 }
                             } catch (SQLException e) {
-                                e.printStackTrace();
+                                ZLog.logException(e);
                             }
                         }
 
@@ -412,7 +412,7 @@ public <C, T> RuntimeExceptionDao<C, T> getDao(Class<C> cls, boolean useCache) {
             RuntimeExceptionDao<C, T> ret = new RuntimeExceptionDao<>(
                     (Dao<C, T>) databaseHelper.getDao(cls));
             if(useCache) {
-                ret.setObjectCache(objectCache);
+                ret.setObjectCache(getObjectCache());
             }
             return ret;
         } catch (SQLException e) {

app/src/main/java/com/zulip/android/activities/DevAuthActivity.java

@@ -69,7 +69,6 @@ public void onItemClick(String email) {
                         .enqueue(new DefaultCallback<LoginResponse>() {
                             @Override
                             public void onSuccess(Call<LoginResponse> call, Response<LoginResponse> response) {
-                                super.onSuccess(call, response);
                                 getApp().setLoggedInApiKey(response.body().getApiKey());
                                 openHome();
                             }

app/src/main/java/com/zulip/android/activities/LoginActivity.java

@@ -194,7 +194,6 @@ private void showBackends(String httpScheme, String serverURL) {
         mServerEditText.setText(serverUri.toString());
         mServerEditText.setEnabled(false);
         ((ZulipApp) getApplication()).setServerURL(serverUri.toString());
-//        AsyncGetBackends asyncGetBackends = new AsyncGetBackends(ZulipApp.get());
 
         getServices()
                 .getAuthBackends()

app/src/main/java/com/zulip/android/models/Message.java

@@ -18,6 +18,7 @@
 import com.j256.ormlite.misc.TransactionManager;
 import com.j256.ormlite.stmt.DeleteBuilder;
 import com.j256.ormlite.table.DatabaseTable;
+import com.zulip.android.R;
 import com.zulip.android.ZulipApp;
 import com.zulip.android.util.CustomHtmlToSpannedConverter;
 import com.zulip.android.util.ZLog;
@@ -168,10 +169,6 @@ public Message(ZulipApp app, JSONObject message,
                    Map<String, Person> personCache,
                    Map<String, Stream> streamCache) throws JSONException {
         this.setID(message.getInt("id"));
-//        this.setSender(Person.getOrUpdate(app,
-//                message.getString("sender_email"),
-//                message.getString("sender_full_name"),
-//                message.getString("avatar_url"), personCache));
 
         if (message.getString("type").equals("stream")) {
             this.setType(MessageType.STREAM_MESSAGE);
@@ -314,7 +311,7 @@ public void setRecipients(Person[] list) {
             setRecipients(to.getId() + "," + from.getId());
             return;
         } catch (Exception e) {
-            e.printStackTrace();
+            ZLog.logException(e);
         }
 
         this.recipients = (recipientId == 0 && senderId == 0) ? recipientList(list) : recipientId + "," + senderId;
@@ -581,7 +578,7 @@ public void setSubject(String subject) {
         if (subject != null && subject.equals("")) {
             // The empty string should be interpreted as "no topic"
             // i18n here will be sad
-            this.subject = "(no topic)";
+            this.subject = ZulipApp.get().getString(R.string.no_topic_in_message);
         } else {
             this.subject = subject;
         }

app/src/main/java/com/zulip/android/models/Person.java

@@ -7,6 +7,7 @@
 import com.j256.ormlite.stmt.SelectArg;
 import com.j256.ormlite.table.DatabaseTable;
 import com.zulip.android.ZulipApp;
+import com.zulip.android.util.ZLog;
 
 import org.apache.commons.lang.builder.HashCodeBuilder;
 
@@ -155,7 +156,7 @@ public static Person getByEmail(ZulipApp app, String email) {
             return getByEmail(app.getDatabaseHelper().getDao(
                     Person.class), email);
         } catch (SQLException e) {
-            e.printStackTrace();
+            ZLog.logException(e);
         }
         return null;
     }

app/src/main/java/com/zulip/android/models/updated/JenkinsType.java

@@ -1,15 +1,21 @@
 package com.zulip.android.models.updated;
 
 
+import com.google.gson.annotations.SerializedName;
+
 public class JenkinsType {
-    private String source_url;
-    private String display_url;
 
-    public String getSource_url() {
-        return source_url;
+    @SerializedName("sourceUrl")
+    private String sourceUrl;
+
+    @SerializedName("displayUrl")
+    private String displayUrl;
+
+    public String getSourceUrl() {
+        return sourceUrl;
     }
 
-    public String getDisplay_url() {
-        return display_url;
+    public String getDisplayUrl() {
+        return displayUrl;
     }
 }

app/src/main/java/com/zulip/android/networking/response/UserConfigurationResponse.java

@@ -79,15 +79,14 @@ public class UserConfigurationResponse {
     @SerializedName("left_side_userlist")
     private boolean leftSideUserlist;
 
-    //todo
     @SerializedName("muted_topics")
     private List<List<String>> mutedTopics;
 
-    //todo
+    //todo unkown type
     @SerializedName("alert_words")
     private List<?> alertWords;
 
-    //todo
+    //todo unknown type
     @SerializedName("realm_bots")
     private List<?> realmBots;
 

app/src/main/java/com/zulip/android/networking/response/events/GetEventResponse.java

@@ -4,6 +4,7 @@
 
 import com.google.gson.annotations.SerializedName;
 import com.zulip.android.util.TypeSwapper;
+import com.zulip.android.util.ZLog;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -50,6 +51,7 @@ public <T extends EventsBranch, R>List<R> getEventsOf(EventsBranch.BranchType br
         }
         catch(Exception e) {
             //catch misuse
+            ZLog.logException(e);
             return null;
         }
     }

app/src/main/java/com/zulip/android/networking/util/DefaultCallback.java

@@ -1,7 +1,8 @@
 package com.zulip.android.networking.util;
 
 import android.support.annotation.CallSuper;
-import android.util.Log;
+
+import com.zulip.android.util.ZLog;
 
 import retrofit2.Call;
 import retrofit2.Callback;
@@ -28,6 +29,6 @@ public void onSuccess(Call<T> call, Response<T> response) {
     @Override
     public void onFailure(Call<T> call, Throwable t) {
         //log error
-        Log.e("DefaultCallback", "Nework failure", t);
+        ZLog.logException(t);
     }
 }

app/src/main/res/values/strings.xml

@@ -84,4 +84,5 @@
     <string name="no_login_error_widget">First login to Zulip app.</string>
     <string name="toast_login_failed_fetching_backends">Failed to fetch Backends!</string>
     <string name="login_activity_toast_login_error">Unknown login error.</string>
+    <string name="no_topic_in_message">(no topic)</string>
 </resources>