Toast when message is sent to unsubscribed stream

Fixes: #255 and #256

Author: jainkuniya

app/src/main/java/com/zulip/android/activities/ZulipActivity.java

@@ -1255,16 +1255,17 @@ private void sendMessage() {
                 streamActv.requestFocus();
                 return;
             } else {
-                try {
-                    Cursor streamCursor = makeStreamCursor(streamActv.getText().toString());
-                    if (streamCursor.getCount() == 0) {
-                        streamActv.setError(getString(R.string.stream_not_exists));
-                        streamActv.requestFocus();
-                        return;
-                    }
-                } catch (SQLException e) {
-                    ZLog.logException(e);
-                    Log.e("SQLException", "SQL not correct", e);
+                Stream stream = Stream.streamCheckBeforeMessageSend(app, streamActv.getText().toString());
+                //check whether stream exists or not
+                if (stream == null) {
+                    streamActv.setError(getString(R.string.stream_not_exists));
+                    streamActv.requestFocus();
+                    return;
+                }// check whether user is subscribed or not
+                else if (!stream.isSubscribed()) {
+                    Toast.makeText(ZulipActivity.this, getString(R.string.message_not_subscribed)
+                            + " " + streamActv.getText().toString() + " " + getString(R.string.keyword_stream), Toast.LENGTH_SHORT).show();
+                    return;
                 }
             }
             if (TextUtils.isEmpty(topicActv.getText().toString())) {

app/src/main/java/com/zulip/android/models/Stream.java

@@ -13,6 +13,7 @@
 import com.j256.ormlite.stmt.SelectArg;
 import com.j256.ormlite.table.DatabaseTable;
 import com.zulip.android.ZulipApp;
+import com.zulip.android.util.ZLog;
 
 import org.apache.commons.lang.builder.EqualsBuilder;
 import org.apache.commons.lang.builder.HashCodeBuilder;
@@ -190,4 +191,24 @@ public int getId() {
         return id;
     }
 
-}
+    /**
+     * Checks stream name is valid or not
+     * @param app ZulipApp
+     * @param streamName Checks this stream name is valid or not
+     * @return null if stream does not exist else cursor
+     */
+    public static Stream streamCheckBeforeMessageSend(ZulipApp app, CharSequence streamName) {
+        if (streamName == null) {
+            return null;
+        }
+        try {
+            return app.getDao(Stream.class)
+                    .queryBuilder().where()
+                    .eq(Stream.NAME_FIELD, new SelectArg(Stream.NAME_FIELD, streamName)).queryForFirst();
+        } catch (SQLException e) {
+            ZLog.logException(e);
+        }
+        return null;
+    }
+
+}

app/src/main/res/values/strings.xml

@@ -116,4 +116,6 @@
     <string name="camera_content_desp">take photo</string>
     <string name="menu_one_day_before">One Day Before</string>
     <string name="enter_date">Enter Date</string>
+    <string name="message_not_subscribed">Not subscribed to</string>
+    <string name="keyword_stream">stream</string>
 </resources>