Fix lint errors.

Author: Sam1301

app/src/main/java/com/zulip/android/activities/ZulipActivity.java

@@ -355,7 +355,7 @@ public void onClick(View v) {
         onTextChangeOfPeopleSearchEditText();
         mNotificationManager = (NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE);
         mBuilder = (NotificationCompat.Builder) new NotificationCompat.Builder(this)
-                .setColor(getColor(R.color.notif_background));
+                .setColor(ContextCompat.getColor(this, R.color.notif_background));
         ivSearchPeopleCancel.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View v) {
@@ -899,7 +899,7 @@ protected void onNewIntent(Intent intent) {
         if (mBuilder == null) {
             mBuilder = (NotificationCompat.Builder) new NotificationCompat.Builder(this)
                     .setContentTitle(getString(R.string.notif_title))
-                    .setColor(getColor(R.color.notif_background));
+                    .setColor(ContextCompat.getColor(this, R.color.notif_background));
         }
 
         // Get action and MIME type of intent
@@ -941,8 +941,7 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
 
             // activity transition animation
             ActivityTransitionAnim.transition(ZulipActivity.this);
-        }
-        else if (requestCode == REQUEST_PICK_FILE && resultCode == RESULT_OK) {
+        } else if (requestCode == REQUEST_PICK_FILE && resultCode == RESULT_OK) {
             List<Uri> fileUris = new ArrayList<>();
             if (data.getData() != null) {
                 fileUris.add(data.getData());
@@ -1214,8 +1213,6 @@ private void uploadFile(final File file) {
         // MultipartBody.Part is used to send also the actual file name
         MultipartBody.Part body = prepareFilePart("file", file, notifId);
 
-        final String loadingMsg = getResources().getString(R.string.uploading_message);
-
         // start notification
         setNotification(notifId, getString(R.string.init_notif_title));
 
@@ -1225,40 +1222,44 @@ private void uploadFile(final File file) {
         call.enqueue(new DefaultCallback<UploadResponse>() {
             @Override
             public void onSuccess(Call<UploadResponse> call, Response<UploadResponse> response) {
-                if (!isDestroyed()) {
-                    String filePathOnServer = "";
-                    UploadResponse uploadResponse = response.body();
-                    filePathOnServer = uploadResponse.getUri();
-                    if (!filePathOnServer.equals("")) {
-                        endNotification(notifId, getString(R.string.finish_notif_title));
-
-                        // add uploaded file url on server to composed message
-                        messageEt.append("\n[" + file.getName() + "](" +
-                                UrlHelper.addHost(filePathOnServer) + ")");
-                        displayFAB(false);
-                        displayChatBox(true);
-                    } else {
-                        endNotification(notifId, getString(R.string.failed_to_upload));
-                    }
-                    mNotificationManager.cancel(notifId);
+                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1 && isDestroyed()) {
+                    return;
                 }
+                String filePathOnServer = "";
+                UploadResponse uploadResponse = response.body();
+                filePathOnServer = uploadResponse.getUri();
+                if (!filePathOnServer.equals("")) {
+                    endNotification(notifId, getString(R.string.finish_notif_title));
+
+                    // add uploaded file url on server to composed message
+                    messageEt.append("\n[" + file.getName() + "](" +
+                            UrlHelper.addHost(filePathOnServer) + ")");
+                    displayFAB(false);
+                    displayChatBox(true);
+                } else {
+                    endNotification(notifId, getString(R.string.failed_to_upload));
+                }
+                mNotificationManager.cancel(notifId);
+
             }
 
             @Override
             public void onError(Call<UploadResponse> call, Response<UploadResponse> response) {
-                if (!isDestroyed()) {
-                    endNotification(notifId, getString(R.string.failed_to_upload));
-                    mNotificationManager.cancel(notifId);
+                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1 && isDestroyed()) {
+                    return;
                 }
+                endNotification(notifId, getString(R.string.failed_to_upload));
+                mNotificationManager.cancel(notifId);
             }
 
             @Override
             public void onFailure(Call<UploadResponse> call, Throwable t) {
-                if (!isDestroyed()) {
-                    endNotification(notifId, getString(R.string.failed_to_upload));
-                    mNotificationManager.cancel(notifId);
-                    ZLog.logException(t);
+                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1 && isDestroyed()) {
+                    return;
                 }
+                endNotification(notifId, getString(R.string.failed_to_upload));
+                mNotificationManager.cancel(notifId);
+                ZLog.logException(t);
             }
         });
     }

app/src/main/java/com/zulip/android/util/FileUtils.java

@@ -16,6 +16,7 @@
 
 package com.zulip.android.util;
 
+import android.annotation.SuppressLint;
 import android.content.ContentResolver;
 import android.content.ContentUris;
 import android.content.Context;
@@ -246,6 +247,7 @@ public static String getDataColumn(Context context, Uri uri, String selection,
      * @see #getFile(Context, Uri)
      * @author paulburke
      */
+    @SuppressLint("NewApi")
     public static String getPath(final Context context, final Uri uri) {
 
         if (DEBUG)

app/src/main/res/values/strings.xml

@@ -108,7 +108,6 @@
     <string name="star_message">Star message</string>
     <string name="un_star_message">Unstar message</string>
     <string name="login_failed">Unable to login</string>
-    <string name="uploading_message">Uploading</string>
     <string name="cannot_upload_file">Cannot upload file</string>
     <string name="cannot_find_file">Cannot find requested file</string>
     <string name="failed_to_upload">Failed</string>
@@ -167,7 +166,6 @@
     <string name="people_drawer_recent_pm_label">Recent Private Messages</string>
     <string name="people_drawer_others_label">New Private Message</string>
     <string name="mentions">\@-mentions</string>
-    <string name="attach">Attach</string>
     <string name="notif_title">Upload to Zulip</string>
     <string name="init_notif_title">Starting upload</string>
     <string name="finish_notif_title">Complete</string>