Merge pull request #81 from yuki24/add-config-for-registering-assets

Add a config to opt out of registering assets

Author: zorab47

README.md

@@ -198,6 +198,23 @@ or later.
 gem 'activeadmin', github: 'activeadmin', ref: 'b3a9f4b'
 ```
 
+### Suppressing warnings from Active Admin
+
+As of Active Admin 1.1.0, `config.register_stylesheet` and `config.register_javascript` have been deprecated. `ActiveAdmin::SortableTree` uses these interfaces to register required assets automatically. Because of this, you may see a deprecation warning:
+
+```
+DEPRECATION WARNING: Active Admin: The `register_javascript` config is deprecated and will be removed
+in v2. Import your "active_admin/sortable.js" javascript in the active_admin.js.
+ (called from <main> at config/environment.rb:5)
+```
+
+You could opt out of it by setting `config.aa_sortable_tree.register_assets` to `false`:
+
+```ruby
+# config/application.rb
+config.aa_sortable_tree.register_assets = false
+```
+
 ## Semantic Versioning
 
 ActiveAdmin::SortableTree follows [semantic versioning](http://semver.org).

lib/active_admin/sortable_tree/engine.rb

@@ -5,6 +5,9 @@ module SortableTree
     class Engine < ::Rails::Engine
       engine_name "active_admin-sortable_tree"
 
+      config.aa_sortable_tree = ActiveSupport::OrderedOptions.new
+      config.aa_sortable_tree.register_assets = true
+
       initializer "active_admin-sortable_tree.precompile", group: :all do |app|
         app.config.assets.precompile += [
           "active_admin/sortable.css",
@@ -13,8 +16,10 @@ class Engine < ::Rails::Engine
       end
 
       initializer "active_admin-sortable_tree.register_assets" do
-        ActiveAdmin.application.register_stylesheet "active_admin/sortable.css"
-        ActiveAdmin.application.register_javascript "active_admin/sortable.js"
+        if config.aa_sortable_tree.register_assets
+          ActiveAdmin.application.register_stylesheet "active_admin/sortable.css"
+          ActiveAdmin.application.register_javascript "active_admin/sortable.js"
+        end
       end
     end
   end

spec/dummy/app/assets/javascripts/active_admin.js

@@ -1,2 +1,3 @@
 //= require active_admin/base
+//= require active_admin/sortable
 //= require jquery.simulate

spec/dummy/app/assets/stylesheets/active_admin.css.scss

@@ -10,6 +10,7 @@
 // Active Admin's got SASS!
 @import "active_admin/mixins";
 @import "active_admin/base";
+@import "active_admin/sortable";
 
 // Overriding any non-variable SASS must be done after the fact.
 // For example, to change the default status-tag color:

spec/dummy/config/application.rb

@@ -50,6 +50,8 @@ class Application < Rails::Application
 
     # Version of your assets, change this if you want to expire all your assets
     config.assets.version = '1.0'
+
+    config.aa_sortable_tree.register_assets = false
   end
 end