Skip to content

Conversation

@matthijs
Copy link
Contributor

@matthijs matthijs commented Nov 15, 2025

Proposed change

This adds support for a dimmer with a different identifier (Eco-Dim.05 Zigbee).

Additional information

Fixes: #4369

Device diagnostics

Is this really needed?

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (1e5953b) to head (6cdff84).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4494   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         369      369           
  Lines       12094    12094           
=======================================
  Hits        11156    11156           
  Misses        938      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthijs matthijs changed the title Add quirk for Eco-Dim.05 Zigbee, different naming (closes: #4369) Update quirk for Eco-Dim.05 Zigbee, different naming (closes: #4369) Nov 15, 2025
@TheJulianJES TheJulianJES changed the title Update quirk for Eco-Dim.05 Zigbee, different naming (closes: #4369) Add Eco-Dim.05 Zigbee dimmer variant Nov 17, 2025
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added another commit to update the existing v2 quirk with the alternative manufacturer/model name using .applies_to(manf, model). Since the v2 quirk is the same in function (replacing cluster occurrences), we don't need to copy the quirk here.

Thanks for the PR!

@TheJulianJES TheJulianJES merged commit bf73aa9 into zigpy:dev Nov 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Device Support Request] EcoDim.05 two-gang dimmer

2 participants