fix: avoid bitwise operations on integers

Author: aminya

src/incoming_msg.cc

@@ -31,7 +31,7 @@ Napi::Value IncomingMsg::IntoBuffer(const Napi::Env& env) {
     auto length = zmq_msg_size(*ref);
 
     if (noElectronMemoryCage) {
-        static auto constexpr zero_copy_threshold = 1 << 7;
+        static auto constexpr zero_copy_threshold = 1U << 7U;
         if (length > zero_copy_threshold) {
             /* Reuse existing buffer for external storage. This avoids copying but
                does include an overhead in having to call a finalizer when the

src/observer.cc

@@ -77,6 +77,7 @@ constexpr const char* EventName(uint32_t val) {
 
 #ifdef ZMQ_EVENT_HANDSHAKE_FAILED_AUTH
 constexpr const char* AuthError(uint32_t val) {
+    // NOLINTBEGIN(*-magic-numbers)
     switch (val) {
     case 300:
         return "Temporary error";
@@ -88,6 +89,7 @@ constexpr const char* AuthError(uint32_t val) {
         /* Fallback if the auth error was unknown, which should not happen. */
         return "Unknown error";
     }
+    // NOLINTEND(*-magic-numbers)
 }
 #endif
 
@@ -201,13 +203,13 @@ bool Observer::ValidateOpen() const {
 }
 
 bool Observer::HasEvents() const {
-    int32_t events = 0;
+    uint32_t events = 0;
     size_t events_size = sizeof(events);
 
     while (zmq_getsockopt(socket, ZMQ_EVENTS, &events, &events_size) < 0) {
         /* Ignore errors. */
         if (zmq_errno() != EINTR) {
-            return 0;
+            return false;
         }
     }
 

src/outgoing_msg.cc

@@ -6,7 +6,7 @@
 
 namespace zmq {
 OutgoingMsg::OutgoingMsg(Napi::Value value, Module& module) {
-    static auto constexpr zero_copy_threshold = 1 << 7;
+    static auto constexpr zero_copy_threshold = 1U << 7U;
 
     auto buffer_send = [&](uint8_t* data, size_t length) {
         /* Zero-copy heuristic. There's an overhead in releasing the buffer with an

src/poller.h

@@ -16,7 +16,7 @@ class Poller {
     UvHandle<uv_timer_t> readable_timer;
     UvHandle<uv_timer_t> writable_timer;
 
-    int32_t events{0};
+    uint32_t events{0};
     std::function<void()> finalize = nullptr;
 
 public:
@@ -139,7 +139,7 @@ class Poller {
     /* Trigger one or more specific events manually. No validation is
        performed, which means these will cause EAGAIN errors if no events
        were actually available. */
-    void Trigger(int32_t triggered) {
+    void Trigger(uint32_t triggered) {
         events &= ~triggered;
         if (events == 0) {
             [[maybe_unused]] auto err = uv_poll_stop(poll);

src/socket.cc

@@ -20,7 +20,7 @@
 namespace zmq {
 /* The maximum number of sync I/O operations that are allowed before the I/O
    methods will force the returned promise to be resolved in the next tick. */
-[[maybe_unused]] auto constexpr max_sync_operations = 1 << 9;
+[[maybe_unused]] auto constexpr max_sync_operations = 1U << 9U;
 
 /* Ordinary static cast for all available numeric types. */
 template <typename T>
@@ -38,7 +38,7 @@ uint64_t NumberCast<uint64_t>(const Napi::Number& num) {
         return 0;
     }
 
-    static constexpr auto max_safe_integer = static_cast<double>((1ULL << 53) - 1);
+    static constexpr auto max_safe_integer = static_cast<double>((1ULL << 53U) - 1);
     if (value > max_safe_integer) {
         Warn(num.Env(),
             "Value is larger than Number.MAX_SAFE_INTEGER and may have been rounded "
@@ -245,8 +245,8 @@ bool Socket::ValidateOpen() const {
     }
 }
 
-bool Socket::HasEvents(int32_t requested) const {
-    int32_t events = 0;
+bool Socket::HasEvents(uint32_t requested_events) const {
+    uint32_t events = 0;
     size_t events_size = sizeof(events);
 
     while (zmq_getsockopt(socket, ZMQ_EVENTS, &events, &events_size) < 0) {
@@ -256,7 +256,7 @@ bool Socket::HasEvents(int32_t requested) const {
         }
     }
 
-    return (events & requested) != 0;
+    return (events & requested_events) != 0;
 }
 
 void Socket::Close() {

src/socket.h

@@ -56,7 +56,7 @@ class Socket : public Napi::ObjectWrap<Socket>, public Closable {
 private:
     inline void WarnUnlessImmediateOption(int32_t option) const;
     [[nodiscard]] inline bool ValidateOpen() const;
-    [[nodiscard]] bool HasEvents(int32_t events) const;
+    [[nodiscard]] bool HasEvents(uint32_t requested_events) const;
 
     /* Send/receive are usually in a hot path and will benefit slightly
        from being inlined. They are used in more than one location and are