fix: use std::array instead of C-arrays

Author: aminya

src/module.cc

@@ -1,4 +1,6 @@
 
+#include <array>
+
 #include "./module.h"
 
 #include "./context.h"
@@ -58,16 +60,19 @@ Napi::Object Capabilities(const Napi::Env& env) {
 }
 
 Napi::Value CurveKeyPair(const Napi::CallbackInfo& info) {
-    char public_key[41];
-    char secret_key[41];
-    if (zmq_curve_keypair(public_key, secret_key) < 0) {
+    static constexpr auto max_key_length = 41;
+
+    std::array<char, max_key_length> public_key{};
+    std::array<char, max_key_length> secret_key{};
+
+    if (zmq_curve_keypair(public_key.data(), secret_key.data()) < 0) {
         ErrnoException(info.Env(), zmq_errno()).ThrowAsJavaScriptException();
         return info.Env().Undefined();
     }
 
     auto result = Napi::Object::New(info.Env());
-    result["publicKey"] = Napi::String::New(info.Env(), public_key);
-    result["secretKey"] = Napi::String::New(info.Env(), secret_key);
+    result["publicKey"] = Napi::String::New(info.Env(), public_key.data());
+    result["secretKey"] = Napi::String::New(info.Env(), secret_key.data());
     return result;
 }
 

src/poller.h

@@ -24,11 +24,11 @@ class Poller {
        ZMQ style edge-triggered, with READABLE state indicating that ANY
        event may be present on the corresponding ZMQ socket. */
     int32_t Initialize(
-        Napi::Env env, uv_os_sock_t& fd, std::function<void()> finalizer = nullptr) {
+        Napi::Env env, uv_os_sock_t& file_descriptor, std::function<void()> finalizer = nullptr) {
         auto* loop = UvLoop(env);
 
         poll->data = this;
-        if (auto err = uv_poll_init_socket(loop, poll.get(), fd); err != 0) {
+        if (auto err = uv_poll_init_socket(loop, poll.get(), file_descriptor); err != 0) {
             return err;
         }
 

src/socket.cc

@@ -4,6 +4,7 @@
 #include <cstdint>
 #include <limits>
 #include <unordered_set>
+#include <array>
 
 #include "./context.h"
 #include "./incoming_msg.h"
@@ -778,18 +779,20 @@ Napi::Value Socket::GetSockOpt<char*>(const Napi::CallbackInfo& info) {
 
     auto const option = info[0].As<Napi::Number>();
 
-    char value[1024];
-    size_t length = sizeof(value) - 1;
-    if (zmq_getsockopt(socket, option, value, &length) < 0) {
+    static constexpr auto max_value_length = 1024;  //+
+    auto value = std::array<char, max_value_length>();  //+
+    size_t length = value.size();  //+
+    if (zmq_getsockopt(socket, option, value.data(), &length) < 0) {  //+
         ErrnoException(Env(), zmq_errno()).ThrowAsJavaScriptException();
         return Env().Undefined();
     }
 
     if (length == 0 || (length == 1 && value[0] == 0)) {
         return Env().Null();
     }
+    // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-constant-array-index)
     value[length] = '\0';
-    return Napi::String::New(Env(), value);
+    return Napi::String::New(Env(), value.data());
 }
 
 template <>

src/util/arguments.h

@@ -28,7 +28,7 @@ struct Not {
 
 template <typename... F>
 class Verify {
-    const std::string_view msg;
+    /* const */ std::string_view msg;
 
 public:
     constexpr explicit Verify(std::string_view msg) noexcept : msg(msg) {}

src/util/electron_helper.h

@@ -36,7 +36,8 @@ inline bool hasElectronMemoryCage(const Napi::Env& env) {
                                     .ToString()
                                     .Utf8Value();
             int const majorVer = stoi(first_component(electronVers));
-            if (majorVer >= 21) {
+            static constexpr auto electron_memory_cage_version = 21;
+            if (majorVer >= electron_memory_cage_version) {
                 hasElectronMemoryCageCache = true;
             }
         }