fix: fix finalization of thread-safe poller

Author: aminya

.github/workflows/docs.yml

@@ -27,7 +27,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-
       - name: Cache
         uses: actions/cache@v4
         with:

src/draft.ts

@@ -41,27 +41,22 @@ interface RadioGroupOptions {
 export interface Radio extends Writable<MessageLike, [RadioGroupOptions]> {}
 allowMethods(Radio.prototype, ["send"])
 
-const join = (
-  Socket.prototype as Socket & {
-    join: (value: Array<string | Buffer>) => void
-  }
-).join
-const leave = (
-  Socket.prototype as Socket & {
-    leave: (value: Array<string | Buffer>) => void
-  }
-).leave
-
 export class Dish extends Socket {
   constructor(options?: SocketOptions<Dish>) {
     super(SocketType.Dish, options)
   }
 
   join(...values: Array<Buffer | string>): void {
+    const {join} = Socket.prototype as Socket & {
+      join: (value: Array<string | Buffer>) => void
+    }
     join(values)
   }
 
   leave(...values: Array<Buffer | string>): void {
+    const {leave} = Socket.prototype as Socket & {
+      leave: (value: Array<string | Buffer>) => void
+    }
     leave(values)
   }
 }

src/socket.cc

@@ -140,9 +140,12 @@ Socket::Socket(const Napi::CallbackInfo& info)
 
         /* Callback to free the underlying poller. Move the poller to transfer
            ownership after the constructor has completed. */
-        finalize = [&]() {
-            [[maybe_unused]] auto err = zmq_poller_destroy(&poll);
-            assert(err == 0);
+        finalize = [poll]() mutable {
+            if (poll != nullptr) {
+                [[maybe_unused]] auto err = zmq_poller_destroy(&poll);
+                assert(err == 0);
+                poll = nullptr;
+            }
         };
 
         if (zmq_poller_add(poll, socket, nullptr, ZMQ_POLLIN | ZMQ_POLLOUT) < 0) {