Merge pull request #669 from zeromq/cmake-ts-fork

Author: aminya

.github/workflows/CI.yml

@@ -125,11 +125,11 @@ jobs:
         if: ${{ !matrix.docker }}
         run: pnpm run build.js
 
-      - name: Install Node 12
+      - name: Install Node 10
         if: ${{ !matrix.docker && matrix.os != 'macos-14' }}
         uses: actions/setup-node@v4
         with:
-          node-version: 12
+          node-version: 10
           architecture: ${{ env.setup_node_arch }}
 
       - name: Build Native
@@ -139,7 +139,7 @@ jobs:
       - name: Build Native Windows 32
         if: ${{ matrix.os == 'windows-2019' && matrix.node_arch == 'ia32' }}
         run:
-          node ./node_modules/cmake-ts/build/main.js named-configs windows-x86
+          node ./node_modules/@aminya/cmake-ts/build/main.js named-configs windows-x86
 
       - name: Use Node 20
         if: ${{ !matrix.docker }}

CMakeLists.txt

@@ -102,7 +102,7 @@ project_options(ENABLE_CACHE ENABLE_COMPILE_COMMANDS_SYMLINK)
 file(GLOB_RECURSE SOURCES "./src/*.cc")
 add_library(addon SHARED ${SOURCES})
 
-target_link_libraries(addon PRIVATE project_options project_warnings)
+target_link_libraries(addon PRIVATE project_options) # project_warnings
 
 if(ZMQ_DRAFT)
   target_compile_definitions(addon PRIVATE ZMQ_BUILD_DRAFT_API)
@@ -135,6 +135,5 @@ set_target_properties(addon PROPERTIES PREFIX "" SUFFIX ".node")
 
 # Windows
 if(WIN32)
-  set_property(TARGET addon PROPERTY LINK_FLAGS "-Xlinker /DELAYLOAD:NODE.EXE")
   target_link_libraries(addon PRIVATE "ShLwApi.lib" "delayimp.lib")
 endif()

README.md

@@ -97,9 +97,9 @@ during build, you can build this package from source.
 Make sure you have the following installed before attempting to build from
 source:
 
-- Node.js 12+ or Electron
+- Node.js 10+ or Electron
 - A working C++17 compiler toolchain with make
-- Python 3 with Node 12+ (or legacy Python 2.7)
+- Python 3 with Node 10+ (or legacy Python 2.7)
 - CMake 2.8+
 - curl
 

package.json

@@ -19,7 +19,7 @@
   },
   "homepage": "http://zeromq.github.io/zeromq.js/",
   "dependencies": {
-    "cmake-ts": "^0.3.0",
+    "@aminya/cmake-ts": "^0.3.0-aminya.7",
     "node-addon-api": "^8.2.1"
   },
   "devDependencies": {