fix: silence poller UV reinterpret cast warnings

Author: aminya

src/module.h

@@ -18,10 +18,10 @@ struct Terminator {
         assert(context != nullptr);
 
 #ifdef ZMQ_BLOCKY
-        bool const blocky = zmq_ctx_get(context, ZMQ_BLOCKY) != 0;
+        const bool blocky = zmq_ctx_get(context, ZMQ_BLOCKY) != 0;
 #else
         /* If the option cannot be set, don't suggest to set it. */
-        bool blocky = false;
+        const bool blocky = false;
 #endif
 
         /* Start termination asynchronously so we can detect if it takes long
@@ -35,7 +35,7 @@ struct Terminator {
         if (terminate.wait_for(500ms) == std::future_status::timeout) {
             /* We can't use process.emitWarning, because the Node.js runtime
                has already shut down. So we mimic it instead. */
-            fprintf(stderr,
+            (void)fprintf(stderr,
                 "(node:%d) WARNING: Waiting for queued ZeroMQ messages to be "
                 "delivered.%s\n",
                 uv_os_getpid(),

src/poller.h

@@ -74,6 +74,7 @@ class Poller {
             [[maybe_unused]] auto err = uv_timer_start(
                 readable_timer.get(),
                 [](uv_timer_t* timer) {
+                    // NOLINTNEXTLINE(*-pro-type-reinterpret-cast)
                     auto& poller = *reinterpret_cast<Poller*>(timer->data);
                     poller.Trigger(UV_READABLE);
                 },
@@ -98,6 +99,7 @@ class Poller {
             [[maybe_unused]] auto err = uv_timer_start(
                 writable_timer.get(),
                 [](uv_timer_t* timer) {
+                    // NOLINTNEXTLINE(*-pro-type-reinterpret-cast)
                     auto& poller = *reinterpret_cast<Poller*>(timer->data);
                     poller.Trigger(UV_WRITABLE);
                 },
@@ -164,6 +166,7 @@ class Poller {
        There is no guarantee that any events are available. */
     static void Callback(uv_poll_t* poll, int32_t status, int32_t /*events*/) {
         if (status == 0) {
+            // NOLINTNEXTLINE(*-pro-type-reinterpret-cast)
             auto& poller = *reinterpret_cast<Poller*>(poll->data);
             poller.TriggerReadable();
             poller.TriggerWritable();