Skip to content

Commit a6a520d

Browse files
kartbencfriedt
authored andcommitted
drivers: fuel_gauge: remove dead code in set_prop functions
Remove useless assignments to `val` parameter in sbs_gauge_set_prop() and bq27z746_set_prop(). Since `val` is passed by value, modifying it has no effect. Also remove unused `tmp_val` variable. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
1 parent 72d8814 commit a6a520d

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

drivers/fuel_gauge/bq27z746/bq27z746.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -241,16 +241,13 @@ static int bq27z746_set_prop(const struct device *dev, fuel_gauge_prop_t prop,
241241
union fuel_gauge_prop_val val)
242242
{
243243
int rc = 0;
244-
uint16_t tmp_val = 0;
245244

246245
switch (prop) {
247246
case FUEL_GAUGE_SBS_MFR_ACCESS:
248247
rc = bq27z746_write16(dev, BQ27Z746_MANUFACTURERACCESS, val.sbs_mfr_access_word);
249-
val.sbs_mfr_access_word = tmp_val;
250248
break;
251249
case FUEL_GAUGE_SBS_ATRATE:
252250
rc = bq27z746_write16(dev, BQ27Z746_ATRATE, val.sbs_at_rate);
253-
val.sbs_at_rate = tmp_val;
254251
break;
255252
default:
256253
rc = -ENOTSUP;

drivers/fuel_gauge/sbs_gauge/sbs_gauge.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -215,32 +215,26 @@ static int sbs_gauge_set_prop(const struct device *dev, fuel_gauge_prop_t prop,
215215
union fuel_gauge_prop_val val)
216216
{
217217
int rc = 0;
218-
uint16_t tmp_val = 0;
219218

220219
switch (prop) {
221220

222221
case FUEL_GAUGE_SBS_MFR_ACCESS:
223222
rc = sbs_cmd_reg_write(dev, SBS_GAUGE_CMD_MANUFACTURER_ACCESS,
224223
val.sbs_mfr_access_word);
225-
val.sbs_mfr_access_word = tmp_val;
226224
break;
227225
case FUEL_GAUGE_SBS_REMAINING_CAPACITY_ALARM:
228226
rc = sbs_cmd_reg_write(dev, SBS_GAUGE_CMD_REM_CAPACITY_ALARM,
229227
val.sbs_remaining_capacity_alarm);
230-
val.sbs_remaining_capacity_alarm = tmp_val;
231228
break;
232229
case FUEL_GAUGE_SBS_REMAINING_TIME_ALARM:
233230
rc = sbs_cmd_reg_write(dev, SBS_GAUGE_CMD_REM_TIME_ALARM,
234231
val.sbs_remaining_time_alarm);
235-
val.sbs_remaining_time_alarm = tmp_val;
236232
break;
237233
case FUEL_GAUGE_SBS_MODE:
238234
rc = sbs_cmd_reg_write(dev, SBS_GAUGE_CMD_BATTERY_MODE, val.sbs_mode);
239-
val.sbs_mode = tmp_val;
240235
break;
241236
case FUEL_GAUGE_SBS_ATRATE:
242237
rc = sbs_cmd_reg_write(dev, SBS_GAUGE_CMD_AR, val.sbs_at_rate);
243-
val.sbs_at_rate = tmp_val;
244238
break;
245239
default:
246240
rc = -ENOTSUP;

0 commit comments

Comments
 (0)