net: igmp: Fix double unref of igmp packet

MaochenWang1 · henrikbrixandersen · commit 7b916593ec08 · 2024-03-15T13:35:16.000+01:00
If send the igmp packet when lower interface is down, the packet will be
freed twice and show error log. Remove the net_pkt_unref in igmp_send(),
and let the caller free it.

Signed-off-by: Maochen Wang &lt;maochen.wang@nxp.com&gt;
diff --git a/subsys/net/ip/igmp.c b/subsys/net/ip/igmp.c
@@ -255,7 +255,6 @@ static int igmp_send(struct net_pkt *pkt)
 	ret = net_send_data(pkt);
 	if (ret < 0) {
 		net_stats_update_ipv4_igmp_drop(net_pkt_iface(pkt));
-		net_pkt_unref(pkt);
 		return ret;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,6 @@ static int igmp_send(struct net_pkt *pkt)`
`255`	`255`	`ret = net_send_data(pkt);`
`256`	`256`	`if (ret < 0) {`
`257`	`257`	`net_stats_update_ipv4_igmp_drop(net_pkt_iface(pkt));`
`258`		`- net_pkt_unref(pkt);`
`259`	`258`	`return ret;`
`260`	`259`	`}`
`261`	`260`