cmake: modules: version: Check that required fields are present

Will throw an error showing what the issue with the VERSION file
is if a required field is missing

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Author: nordicjm

cmake/modules/version.cmake

@@ -67,17 +67,17 @@ foreach(type file IN ZIP_LISTS VERSION_TYPE VERSION_FILE)
   set(${type}_VERSION_EXTRA ${CMAKE_MATCH_1})
 
   # Validate all version fields fit in a single byte
-  if(${type}_VERSION_MAJOR GREATER 255)
-    message(FATAL_ERROR "VERSION_MAJOR must be in the range 0-255 (Current ${${type}_VERSION_MAJOR})")
+  if(NOT DEFINED ${type}_VERSION_MAJOR OR ${type}_VERSION_MAJOR GREATER 255)
+    message(FATAL_ERROR "VERSION_MAJOR must be present and in the range of 0-255 (Current: ${${type}_VERSION_MAJOR})")
   endif()
-  if(${type}_VERSION_MINOR GREATER 255)
-    message(FATAL_ERROR "VERSION_MINOR must be in the range 0-255 (Current ${${type}_VERSION_MINOR})")
+  if(NOT DEFINED ${type}_VERSION_MINOR OR ${type}_VERSION_MINOR GREATER 255)
+    message(FATAL_ERROR "VERSION_MINOR must be present and in the range of 0-255 (Current: ${${type}_VERSION_MINOR})")
   endif()
-  if(${type}_PATCHLEVEL GREATER 255)
-    message(FATAL_ERROR "PATCHLEVEL must be in the range 0-255 (Current ${${type}_PATCHLEVEL})")
+  if(NOT DEFINED ${type}_PATCHLEVEL OR ${type}_PATCHLEVEL GREATER 255)
+    message(FATAL_ERROR "PATCHLEVEL must be present and in the range of 0-255 (Current: ${${type}_PATCHLEVEL})")
   endif()
-  if(${type}_VERSION_TWEAK GREATER 255)
-    message(FATAL_ERROR "VERSION_TWEAK must be in the range 0-255 (Current ${${type}_VERSION_TWEAK})")
+  if(NOT DEFINED ${type}_VERSION_TWEAK OR ${type}_VERSION_TWEAK GREATER 255)
+    message(FATAL_ERROR "VERSION_TWEAK must be present and in the range of 0-255 (Current: ${${type}_VERSION_TWEAK})")
   endif()
 
   # Temporary convenience variables