Skip to content

Commit c2b3d01

Browse files
Fix: step status check bug
1 parent ef01565 commit c2b3d01

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/zenml/orchestrators/step_launcher.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,14 +370,15 @@ def _bypass() -> None:
370370
):
371371
# Handle as a non-failure as exception is a propagation of graceful termination.
372372
publish_utils.publish_stopped_step_run(step_run.id)
373+
373374
else:
374375
logger.error(
375376
"Failed to run step `%s`: %s",
376377
self._invocation_id,
377378
e,
378379
)
379380
publish_utils.publish_failed_step_run(step_run.id)
380-
raise
381+
raise
381382
else:
382383
logger.info(
383384
f"Using cached version of step `{self._invocation_id}`."

src/zenml/zen_stores/schemas/pipeline_run_schemas.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -818,6 +818,7 @@ def is_placeholder_run(self) -> bool:
818818
@staticmethod
819819
def _step_in_progress(step_id: UUID, session: Session) -> bool:
820820
from zenml.steps.heartbeat import cached_is_heartbeat_unhealthy
821+
from zenml.zen_stores.schemas.step_run_schemas import StepRunSchema
821822

822823
step_run = session.execute(
823824
select(StepRunSchema).where(StepRunSchema.id == step_id)
@@ -899,18 +900,14 @@ def _check_if_run_in_progress(self) -> bool:
899900

900901
steps_statuses = {
901902
name: ExecutionStatus(status)
902-
for name, status in step_run_statuses
903+
for _, name, status in step_run_statuses
903904
}
904905

905906
for step_name, _ in step_dict.items():
906907
if step_name in steps_to_skip:
907908
# failed steps downstream
908909
continue
909910

910-
if steps_statuses[step_name].is_finished:
911-
# completed steps
912-
continue
913-
914911
if step_name not in steps_statuses:
915912
# steps that haven't started yet
916913
return True

0 commit comments

Comments
 (0)