Fix lint issues

Author: jbh

manifests/repo.pp

@@ -67,7 +67,9 @@
 
   case $facts['os']['family'] {
     'Debian': {
-      unless $facts['os']['release']['major'] in ['9', '10', '11'] or $facts['os']['release']['major'] in ['16.04', '18.04', '20.04', '22.04'] {
+      $supported_debian = $facts['os']['release']['major'] in ['9', '10', '11']
+      $supported_ubuntu = $facts['os']['release']['major'] in ['16.04', '18.04', '20.04', '22.04']
+      unless $supported_debian or $supported_ubuntu {
         fail($unsupported)
       }
 

spec/classes/license_spec.rb

@@ -9,20 +9,21 @@
       test_content = 'test-license-content'
       let(:facts) { os_facts }
 
-
       describe 'without params' do
-        it { is_expected.to compile.and_raise_error(/.*/) }
+        it { is_expected.to compile.and_raise_error(%r{/.*/}) }
       end
 
       describe 'with Puppet URL for source' do
         let(:params) { { source: file_uri } }
+
         it { is_expected.to compile }
         it { is_expected.to contain_class('zend_common::license').with_source(file_uri) }
         it { is_expected.to contain_file('/opt/zend/zendphp/etc/license').with_source(file_uri) }
       end
-      
+
       describe 'with text for content' do
         let(:params) { { content: test_content } }
+
         it { is_expected.to compile }
         it { is_expected.to contain_class('zend_common::license').with_content(test_content) }
         it { is_expected.to contain_file('/opt/zend/zendphp/etc/license').with_content(test_content) }