Use __dir__ instead of __FILE__ where possible

Author: bquorning

spec/core/middleware/request/upload_spec.rb

@@ -3,7 +3,7 @@
 
 describe ZendeskAPI::Middleware::Request::Upload do
   subject { ZendeskAPI::Middleware::Request::Upload.new(lambda { |env| env }) }
-  let(:filename) { File.join(File.dirname(__FILE__), "test.jpg") }
+  let(:filename) { File.join(__dir__, "test.jpg") }
 
   it "should handle no body" do
     expect(subject.call({})).to eq({})

spec/core/spec_helper.rb

@@ -1,5 +1,3 @@
-$:.unshift(File.join(File.dirname(__FILE__), "macros"))
-
 ENV["TZ"] = "CET" # something that is not local and not utc so we find all the bugs
 
 require "zendesk_api"
@@ -28,7 +26,7 @@ def encoding_aware?
 
 # tests fail when this is included in a Module (someone else also defines client)
 def client
-  credentials = File.join(File.dirname(__FILE__), "..", "fixtures", "credentials.yml")
+  credentials = File.join(__dir__, "..", "fixtures", "credentials.yml")
   @client ||= begin
     client = ZendeskAPI::Client.new do |config|
       if File.exist?(credentials)
@@ -157,7 +155,7 @@ def stub_json_request(verb, path_matcher, body = json, options = {})
 end
 
 VCR.configure do |c|
-  c.cassette_library_dir = File.join(File.dirname(__FILE__), "..", "fixtures", "cassettes")
+  c.cassette_library_dir = File.join(__dir__, "..", "fixtures", "cassettes")
   c.default_cassette_options = {record: :new_episodes, decode_compressed_response: true, serialize_with: :json, preserve_exact_body_bytes: true}
   c.hook_into :webmock
   c.configure_rspec_metadata!

zendesk_api.gemspec

@@ -1,4 +1,4 @@
-lib = File.expand_path("../lib/", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require "zendesk_api/version"