Skip to content

Commit afbf222

Browse files
committed
Lint: Fix Style/StringLiterals etc. offenses
No functional changes, only changing single quotes to double quotes.
1 parent 985e4e2 commit afbf222

File tree

118 files changed

+450
-610
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

118 files changed

+450
-610
lines changed

.standard_todo.yml

Lines changed: 2 additions & 162 deletions
Large diffs are not rendered by default.

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
source 'https://rubygems.org'
1+
source "https://rubygems.org"
22

33
gem "jruby-openssl", platforms: :jruby
44
gem "mini_mime"

Rakefile

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
require 'bundler/setup'
2-
require 'rake/testtask'
3-
require 'bundler/gem_tasks'
4-
require 'bump/tasks'
5-
require 'standard/rake'
1+
require "bundler/setup"
2+
require "rake/testtask"
3+
require "bundler/gem_tasks"
4+
require "bump/tasks"
5+
require "standard/rake"
66

77
begin
8-
require 'rspec/core/rake_task'
8+
require "rspec/core/rake_task"
99
rescue LoadError
1010
puts "WARN: #{$ERROR_INFO.message} Continuing..."
1111
end
@@ -32,22 +32,22 @@ if defined?(RSpec)
3232
.sub("your_zendesk_host", ENV.fetch("SPEC_LIVE_ZENDESK_HOST")))
3333
end
3434

35-
desc 'Default: run specs.'
35+
desc "Default: run specs."
3636
task :default => "spec"
3737
end
3838

3939
# extracted from https://github.com/grosser/project_template
4040
rule(/^version:bump:.*/) do |t|
4141
sh "git status | grep 'nothing to commit'" # ensure we are not dirty
42-
index = %w(major minor patch).index(t.name.split(':').last)
43-
file = 'lib/zendesk_api/version.rb'
42+
index = %w(major minor patch).index(t.name.split(":").last)
43+
file = "lib/zendesk_api/version.rb"
4444

4545
version_file = File.read(file)
4646
old_version, *version_parts = version_file.match(/(\d+)\.(\d+)\.(\d+)/).to_a
4747
version_parts[index] = version_parts[index].to_i + 1
4848
version_parts[2] = 0 if index < 2 # remove patch for minor
4949
version_parts[1] = 0 if index < 1 # remove minor for major
50-
new_version = version_parts * '.'
50+
new_version = version_parts * "."
5151
File.write(file, version_file.sub(old_version, new_version))
5252

5353
sh "bundle && git add #{file} Gemfile.lock && git commit -m 'bump version to #{new_version}'"

lib/zendesk_api.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
module ZendeskAPI; end
22

3-
require 'faraday'
4-
require 'faraday/multipart'
3+
require "faraday"
4+
require "faraday/multipart"
55

6-
require 'zendesk_api/helpers'
7-
require 'zendesk_api/core_ext/inflection'
8-
require 'zendesk_api/client'
6+
require "zendesk_api/helpers"
7+
require "zendesk_api/core_ext/inflection"
8+
require "zendesk_api/client"

lib/zendesk_api/actions.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ module DestroyMany
271271
# @return [JobStatus] the {JobStatus} instance for this destroy job
272272
def destroy_many!(client, ids, association = Association.new(:class => self))
273273
response = client.connection.delete("#{association.generate_path}/destroy_many") do |req|
274-
req.params = { :ids => ids.join(',') }
274+
req.params = { :ids => ids.join(",") }
275275

276276
yield req if block_given?
277277
end
@@ -321,7 +321,7 @@ def update_many!(client, ids_or_attributes, attributes = {})
321321
if attributes == {}
322322
req.body = { resource_name => ids_or_attributes }
323323
else
324-
req.params = { :ids => ids_or_attributes.join(',') }
324+
req.params = { :ids => ids_or_attributes.join(",") }
325325
req.body = { singular_resource_name => attributes }
326326
end
327327

lib/zendesk_api/association.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require 'zendesk_api/helpers'
1+
require "zendesk_api/helpers"
22

33
module ZendeskAPI
44
# Represents an association between two resources
@@ -93,7 +93,7 @@ def side_load(resources, side_loads)
9393

9494
# @return [Array<String>] ['ZendeskAPI', 'Voice', etc.. ]
9595
def ignorable_namespace_strings
96-
ZendeskAPI::DataNamespace.descendants.map { |klass| klass.to_s.split('::') }.flatten.uniq
96+
ZendeskAPI::DataNamespace.descendants.map { |klass| klass.to_s.split("::") }.flatten.uniq
9797
end
9898

9999
def _side_load(resource, side_loads)

lib/zendesk_api/associations.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require 'zendesk_api/helpers'
1+
require "zendesk_api/helpers"
22

33
module ZendeskAPI
44
# This module holds association method for resources.

lib/zendesk_api/client.rb

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
1-
require 'zendesk_api/version'
2-
require 'zendesk_api/sideloading'
3-
require 'zendesk_api/configuration'
4-
require 'zendesk_api/collection'
5-
require 'zendesk_api/lru_cache'
6-
require 'zendesk_api/silent_mash'
7-
require 'zendesk_api/middleware/request/etag_cache'
8-
require 'zendesk_api/middleware/request/retry'
9-
require 'zendesk_api/middleware/request/raise_rate_limited'
10-
require 'zendesk_api/middleware/request/upload'
11-
require 'zendesk_api/middleware/request/encode_json'
12-
require 'zendesk_api/middleware/request/api_token_impersonate'
13-
require 'zendesk_api/middleware/request/url_based_access_token'
14-
require 'zendesk_api/middleware/response/callback'
15-
require 'zendesk_api/middleware/response/deflate'
16-
require 'zendesk_api/middleware/response/gzip'
17-
require 'zendesk_api/middleware/response/sanitize_response'
18-
require 'zendesk_api/middleware/response/parse_iso_dates'
19-
require 'zendesk_api/middleware/response/parse_json'
20-
require 'zendesk_api/middleware/response/raise_error'
21-
require 'zendesk_api/middleware/response/logger'
22-
require 'zendesk_api/delegator'
1+
require "zendesk_api/version"
2+
require "zendesk_api/sideloading"
3+
require "zendesk_api/configuration"
4+
require "zendesk_api/collection"
5+
require "zendesk_api/lru_cache"
6+
require "zendesk_api/silent_mash"
7+
require "zendesk_api/middleware/request/etag_cache"
8+
require "zendesk_api/middleware/request/retry"
9+
require "zendesk_api/middleware/request/raise_rate_limited"
10+
require "zendesk_api/middleware/request/upload"
11+
require "zendesk_api/middleware/request/encode_json"
12+
require "zendesk_api/middleware/request/api_token_impersonate"
13+
require "zendesk_api/middleware/request/url_based_access_token"
14+
require "zendesk_api/middleware/response/callback"
15+
require "zendesk_api/middleware/response/deflate"
16+
require "zendesk_api/middleware/response/gzip"
17+
require "zendesk_api/middleware/response/sanitize_response"
18+
require "zendesk_api/middleware/response/parse_iso_dates"
19+
require "zendesk_api/middleware/response/parse_json"
20+
require "zendesk_api/middleware/response/raise_error"
21+
require "zendesk_api/middleware/response/logger"
22+
require "zendesk_api/delegator"
2323

2424
module ZendeskAPI
2525
# The top-level class that handles configuration and connection to the Zendesk API.
@@ -63,21 +63,21 @@ def respond_to?(method, *args)
6363
# @return [ZendeskAPI::User] Current user or nil
6464
def current_user(reload = false)
6565
return @current_user if @current_user && !reload
66-
@current_user = users.find(:id => 'me')
66+
@current_user = users.find(:id => "me")
6767
end
6868

6969
# Returns the current account
7070
# @return [Hash] The attributes of the current account or nil
7171
def current_account(reload = false)
7272
return @current_account if @current_account && !reload
73-
@current_account = SilentMash.new(connection.get('account/resolve').body)
73+
@current_account = SilentMash.new(connection.get("account/resolve").body)
7474
end
7575

7676
# Returns the current locale
7777
# @return [ZendeskAPI::Locale] Current locale or nil
7878
def current_locale(reload = false)
7979
return @locale if @locale && !reload
80-
@locale = locales.find(:id => 'current')
80+
@locale = locales.find(:id => "current")
8181
end
8282

8383
# Creates a new {Client} instance and yields {#config}.
@@ -207,12 +207,12 @@ def build_connection
207207
private
208208

209209
def resource_class_for(method)
210-
resource_name = ZendeskAPI::Helpers.modulize_string(Inflection.singular(method.to_s.gsub(/\W/, '')))
210+
resource_name = ZendeskAPI::Helpers.modulize_string(Inflection.singular(method.to_s.gsub(/\W/, "")))
211211
ZendeskAPI::Association.class_from_namespace(resource_name)
212212
end
213213

214214
def check_url
215-
if !config.allow_http && !config.url.start_with?('https://')
215+
if !config.allow_http && !config.url.start_with?("https://")
216216
raise ArgumentError, "zendesk_api is ssl only; url must begin with https://"
217217
end
218218
end
@@ -238,7 +238,7 @@ def set_token_auth
238238

239239
def set_default_logger
240240
if config.logger.nil? || config.logger == true
241-
require 'logger'
241+
require "logger"
242242
config.logger = Logger.new($stderr)
243243
config.logger.level = Logger::WARN
244244
end

lib/zendesk_api/collection.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
require 'zendesk_api/resource'
2-
require 'zendesk_api/resources'
3-
require 'zendesk_api/search'
4-
require 'zendesk_api/pagination'
1+
require "zendesk_api/resource"
2+
require "zendesk_api/resources"
3+
require "zendesk_api/search"
4+
require "zendesk_api/pagination"
55

66
module ZendeskAPI
77
# Represents a collection of resources. Lazily loaded, resources aren't
@@ -289,7 +289,7 @@ def to_s
289289
inspect = []
290290
inspect << "options=#{@options.inspect}" if @options.any?
291291
inspect << "path=#{path}"
292-
"#{Inflection.singular(@resource)} collection [#{inspect.join(',')}]"
292+
"#{Inflection.singular(@resource)} collection [#{inspect.join(",")}]"
293293
end
294294
end
295295

@@ -370,7 +370,7 @@ def join_special_params
370370
# some params use comma-joined strings instead of query-based arrays for multiple values
371371
@options.each do |k, v|
372372
if SPECIALLY_JOINED_PARAMS.include?(k.to_sym) && v.is_a?(Array)
373-
@options[k] = v.join(',')
373+
@options[k] = v.join(",")
374374
end
375375
end
376376
end

lib/zendesk_api/configuration.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ def initialize
6767
def options
6868
{
6969
:headers => {
70-
:accept => 'application/json',
71-
:accept_encoding => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
70+
:accept => "application/json",
71+
:accept_encoding => "gzip;q=1.0,deflate;q=0.6,identity;q=0.3",
7272
:user_agent => "ZendeskAPI Ruby #{ZendeskAPI::VERSION}"
7373
},
7474
:request => {

0 commit comments

Comments
 (0)