simplifies how cbp support is implemented by each resource class

Author: fbvilela

lib/zendesk_api/cbp_support.rb

@@ -4,7 +4,6 @@
 require 'zendesk_api/association'
 require 'zendesk_api/associations'
 require 'zendesk_api/verbs'
-require 'zendesk_api/cbp_support'
 
 # See docs: https://developer.zendesk.com/api-reference/
 module ZendeskAPI
@@ -164,7 +163,10 @@ def attribute_changes
   class DataResource < Data
     attr_accessor :error, :error_message
     extend Verbs
-    include CBPSupport
+
+    def self.cbp_path_regexes
+      []
+    end
   end
 
   # Represents a resource that can only GET

lib/zendesk_api/resource.rb

@@ -153,7 +153,9 @@ def self.incremental_export(client, start_time)
       ZendeskAPI::Collection.new(client, self, :path => "incremental/organizations?start_time=#{start_time.to_i}")
     end
 
-    CBP_ACTIONS = [/organizations$/].freeze
+    def self.cbp_path_regexes
+      [/organizations$/]
+    end
   end
 
   class Brand < Resource
@@ -183,7 +185,9 @@ class OrganizationSubscription < ReadResource
     has User
     has Organization
 
-    CBP_ACTIONS = [%r{organizations/\d+/subscriptions$}].freeze
+    def self.cbp_path_regexes
+      [%r{organizations/\d+/subscriptions$}]
+    end
   end
 
   class Category < Resource
@@ -382,7 +386,9 @@ class Ticket < Resource
     extend UpdateMany
     extend DestroyMany
 
-    CBP_ACTIONS = [/tickets$/].freeze
+    def self.cbp_path_regexes
+      [/tickets$/]
+    end
 
     # Unlike other attributes, "comment" is not a property of the ticket,
     # but is used as a "comment on save", so it should be kept unchanged,
@@ -604,8 +610,11 @@ class Trigger < Rule
     include Conditions
     include Actions
 
-    CBP_ACTIONS = [/triggers$/, %r{triggers/active$}].freeze
     has :execution, :class => RuleExecution
+
+    def self.cbp_path_regexes
+      [/triggers$/, %r{triggers/active$}]
+    end
   end
 
   class Automation < Rule
@@ -650,17 +659,23 @@ def self.preview(client, options = {})
   end
 
   class GroupMembership < Resource
-    CBP_ACTIONS = [%r{groups/\d+/memberships$}].freeze
     extend CreateMany
     extend DestroyMany
 
     has User
     has Group
+
+    def self.cbp_path_regexes
+      [%r{groups/\d+/memberships$}]
+    end
   end
 
   class Group < Resource
-    CBP_ACTIONS = [/groups$/, %r{groups/assignable$}].freeze
     has_many :memberships, :class => GroupMembership, :path => "memberships"
+
+    def self.cbp_path_regexes
+      [/groups$/, %r{groups/assignable$}]
+    end
   end
 
   class User < Resource

lib/zendesk_api/resources.rb

@@ -30,8 +30,8 @@
     end
 
     context "when CBP is used" do
+      before { allow(ZendeskAPI::TestResource).to receive(:cbp_path_regexes).and_return([/test_resources/]) }
       it "is empty on the first page" do
-        stub_const("ZendeskAPI::TestResource::CBP_ACTIONS", %w[test_resources])
         collection = ZendeskAPI::Collection.new(client, ZendeskAPI::TestResource)
         expect(collection.prev).to eq([])
       end
@@ -1045,7 +1045,7 @@ def to_proc
 
     context "when fetching a collection that supports CBP" do
       before do
-        stub_const("ZendeskAPI::TestResource::CBP_ACTIONS", %w[test_resources])
+        allow(ZendeskAPI::TestResource).to receive(:cbp_path_regexes).and_return([/test_resources/])
         expect(subject).to receive(:get_response).with("test_resources").and_return(cbp_success_response)
       end
 
@@ -1078,7 +1078,7 @@ def generate_response(index, has_more)
         }
       end
       before do
-        stub_const("ZendeskAPI::TestResource::CBP_ACTIONS", %w[test_resources])
+        allow(ZendeskAPI::TestResource).to receive(:cbp_path_regexes).and_return([/test_resources/])
         stub_json_request(:get, %r{test_resources\?page%5Bsize%5D=1}, json(generate_response(1, true)))
         stub_json_request(:get, %r{test_resources.json\/\?page%5Bafter%5D=after1&page%5Bsize%5D=1}, json(generate_response(2, true)))
         stub_json_request(:get, %r{test_resources.json\/\?page%5Bafter%5D=after2&page%5Bsize%5D=1}, json(generate_response(3, true)))