Check additional errors key

`errors` is returned in the validation message when attempting to create a translation for a locale that is not supported.

Author: codealchemy

lib/zendesk_api/error.rb

@@ -20,7 +20,7 @@ def initialize(*)
         super
 
         if response[:body].is_a?(Hash)
-          @errors = response[:body]["details"] || generate_error_msg(response[:body]) || response[:body]["error"]
+          @errors = response[:body]["details"] || generate_error_msg(response[:body])
         end
 
         @errors ||= {}
@@ -33,11 +33,11 @@ def to_s
       private
 
       def generate_error_msg(response_body)
-        return unless response_body["description"] || response_body["message"]
-
         [
           response_body["description"],
-          response_body["message"]
+          response_body["message"],
+          response_body["error"],
+          response_body["errors"]
         ].compact.join(" - ")
       end
     end

spec/core/middleware/response/raise_error_spec.rb

@@ -93,17 +93,18 @@
           fail # didn't raise an error
         end
 
-        context "with only an error key" do
-          let(:body) { JSON.dump(:error => "something went wrong") }
-
-          it "should return RecordInvalid with proper message" do
-            begin
-              client.connection.get "/non_existent"
-            rescue ZendeskAPI::Error::RecordInvalid => e
-              expect(e.errors).to eq("something went wrong")
-              expect(e.to_s).to eq("ZendeskAPI::Error::RecordInvalid: something went wrong")
-            else
-              fail # didn't raise an error
+        {
+          error: 'There was an error',
+          errors: 'There were several errors'
+        }.each do |key, message|
+          context "with only an #{key} key" do
+            let(:body) { JSON.dump(key => message) }
+
+            it "should return RecordInvalid with proper message" do
+              expect { client.connection.get "/non_existent" }.to raise_error do |error|
+                expect(error).to be_a(ZendeskAPI::Error::RecordInvalid)
+                expect(error.errors).to eq(message)
+              end
             end
           end
         end
@@ -129,17 +130,18 @@
           fail # didn't raise an error
         end
 
-        context "with only an error key" do
-          let(:body) { JSON.dump(:error => "something went wrong") }
-
-          it "should return RecordInvalid with proper message" do
-            begin
-              client.connection.get "/non_existent"
-            rescue ZendeskAPI::Error::RecordInvalid => e
-              expect(e.errors).to eq("something went wrong")
-              expect(e.to_s).to eq("ZendeskAPI::Error::RecordInvalid: something went wrong")
-            else
-              fail # didn't raise an error
+        {
+          error: 'There was an error',
+          errors: 'There were several errors'
+        }.each do |key, message|
+          context "with only an #{key} key" do
+            let(:body) { JSON.dump(key => message) }
+
+            it "should return RecordInvalid with proper message" do
+              expect { client.connection.get "/non_existent" }.to raise_error do |error|
+                expect(error).to be_a(ZendeskAPI::Error::RecordInvalid)
+                expect(error.errors).to eq(message)
+              end
             end
           end
         end