Skip to content

Commit 4f1f29d

Browse files
authored
Merge pull request #526 from zendesk/fvilela/RED-1548
[RED-1548] Fix issue with Faraday::Multipart
2 parents d5e368c + 573de27 commit 4f1f29d

File tree

2 files changed

+35
-2
lines changed

2 files changed

+35
-2
lines changed

lib/zendesk_api/client.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,6 @@ def self.check_deprecated_namespace_usage(attributes, name)
143143
# Retry middleware if retry is true
144144
def build_connection
145145
Faraday.new(config.options) do |builder|
146-
builder.request :multipart
147-
148146
# response
149147
builder.use ZendeskAPI::Middleware::Response::RaiseError
150148
builder.use ZendeskAPI::Middleware::Response::Callback, self

spec/live/ticket_spec.rb

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,41 @@ def valid_attributes
2727
it_should_be_readable agent, :ccd_tickets, create: true
2828
it_should_be_readable organization, :tickets
2929

30+
describe "#create" do
31+
context "when passing large objects as parameters" do
32+
let(:requester) { client.users.search(query: 'role:end-user').detect(&:photo) }
33+
let(:organization) { client.organizations.sample }
34+
let(:ticket_parameters) do
35+
{
36+
subject: 'live spec subject',
37+
description: 'live spec description',
38+
requester: requester,
39+
organization: organization
40+
} # We should always use requester/organiztion _id for existing records. This test should not be used as a guideline on how to use the sdk.
41+
end
42+
43+
before do
44+
VCR.use_cassette("ticket_create_with_large_objects") do
45+
@ticket = ZendeskAPI::Ticket.create(client, ticket_parameters)
46+
end
47+
end
48+
49+
it 'is creatable' do
50+
expect(requester).to_not be_nil
51+
52+
expect(@ticket.id).to_not be_nil
53+
expect(@ticket.description).to eq(ticket_parameters[:description])
54+
end
55+
end
56+
57+
after do
58+
return unless @ticket
59+
VCR.use_cassette("ticket_destroy_with_large_objects") do
60+
@ticket.destroy!
61+
end
62+
end
63+
end
64+
3065
describe "#attributes_for_save" do
3166
let :ticket do
3267
described_class.new(instance_double(ZendeskAPI::Client), status: :new)

0 commit comments

Comments
 (0)