Lint: Fix layout offenses

No functional changes, only indentation and other whitespace issues,
plus some other simple layout fixes.

Author: bquorning

.standard_todo.yml

@@ -8,12 +8,10 @@ ignore:
 - lib/zendesk_api/actions.rb:
   - Lint/AssignmentInCondition
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - lib/zendesk_api/association.rb:
   - Style/HashSyntax
   - Lint/AssignmentInCondition
   - Lint/ShadowedArgument
-  - Layout/SpaceInsideBlockBraces
   - Style/SafeNavigation
 - lib/zendesk_api/associations.rb:
   - Style/HashSyntax
@@ -22,9 +20,7 @@ ignore:
   - Performance/RedundantMerge
 - lib/zendesk_api/client.rb:
   - Style/MissingRespondToMissing
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
-  - Layout/ArgumentAlignment
   - Lint/AssignmentInCondition
 - lib/zendesk_api/collection.rb:
   - Style/PercentLiteralDelimiters
@@ -34,11 +30,8 @@ ignore:
   - Style/Alias
   - Performance/StringIdentifierArgument
   - Style/ParenthesesAroundCondition
-  - Layout/SpaceInsideHashLiteralBraces
 - lib/zendesk_api/configuration.rb:
   - Style/HashSyntax
-- lib/zendesk_api/helpers.rb:
-  - Layout/DotPosition
 - lib/zendesk_api/middleware/request/encode_json.rb:
   - Lint/Void
 - lib/zendesk_api/middleware/request/etag_cache.rb:
@@ -51,19 +44,15 @@ ignore:
   - Lint/RedundantStringCoercion
 - lib/zendesk_api/pagination.rb:
   - Style/Alias
-  - Layout/SpaceInsideHashLiteralBraces
-  - Layout/ClosingParenthesisIndentation
 - lib/zendesk_api/resource.rb:
   - Style/Alias
   - Style/TrivialAccessors
   - Style/HashSyntax
   - Lint/DuplicateMethods
   - Performance/Caller
-  - Layout/SpaceInsideHashLiteralBraces
 - lib/zendesk_api/resources.rb:
   - Style/Alias
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/PercentLiteralDelimiters
   - Lint/AssignmentInCondition
 - lib/zendesk_api/search.rb:
@@ -72,215 +61,143 @@ ignore:
   - Style/Alias
 - spec/core/association_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/bulk_actions_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
-  - Layout/ArgumentAlignment
-  - Layout/MultilineMethodCallBraceLayout
 - spec/core/client_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/core/collection_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
-  - Layout/ArgumentAlignment
-  - Layout/MultilineMethodCallBraceLayout
-  - Layout/ClosingParenthesisIndentation
   - Lint/ConstantDefinitionInBlock
   - Lint/InheritException
   - Style/Proc
-  - Layout/DotPosition
   - Style/PercentLiteralDelimiters
   - Style/TernaryParentheses
 - spec/core/configuration_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/core/create_resource_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
-- spec/core/data_namespace_spec.rb:
-  - Layout/DotPosition
 - spec/core/data_resource_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/middleware/request/encode_json_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/core/middleware/request/etag_cache_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/PercentLiteralDelimiters
 - spec/core/middleware/request/retry_spec.rb:
-  - Layout/DotPosition
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/middleware/request/upload_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/middleware/response/callback_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/middleware/response/deflate_spec.rb:
   - Style/HashSyntax
 - spec/core/middleware/response/gzip_spec.rb:
   - Style/HashSyntax
-- spec/core/middleware/response/parse_iso_dates_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/middleware/response/parse_json_spec.rb:
   - Style/HashSyntax
 - spec/core/middleware/response/raise_error_spec.rb:
   - Style/HashSyntax
-  - Layout/ArgumentAlignment
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/read_resource_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceBeforeBlockBraces
-  - Layout/ArgumentAlignment
-  - Layout/SpaceInsideHashLiteralBraces
-  - Layout/ClosingParenthesisIndentation
 - spec/core/resource_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
   - Lint/ConstantDefinitionInBlock
   - Style/PercentLiteralDelimiters
-  - Layout/SpaceBeforeBlockBraces
 - spec/core/resources/automation_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/resources/macro_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/resources/trigger_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/resources/view_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/PercentLiteralDelimiters
-- spec/core/search_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/core/spec_helper.rb:
   - Style/GlobalVars
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/MixinUsage
 - spec/core/trackie_spec.rb:
   - Style/BlockComments
 - spec/fixtures/zendesk.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/live/app_installation_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/PercentLiteralDelimiters
 - spec/live/app_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/PercentLiteralDelimiters
 - spec/live/article_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/automation_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/live/bookmark_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/brand_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/category_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/dynamic_content/item_spec.rb:
   - Style/HashSyntax
 - spec/live/dynamic_content/variant_spec.rb:
   - Style/HashSyntax
 - spec/live/group_membership_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/group_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/identity_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/macro_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
   - Lint/RedundantStringCoercion
 - spec/live/organization_field_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/organization_membership_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/organization_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/organization_subscription_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/push_notification_device_spec.rb:
   - Style/PercentLiteralDelimiters
 - spec/live/request_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/live/section_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/setting_spec.rb:
   - Style/HashSyntax
 - spec/live/suspended_ticket_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/live/tag_spec.rb:
   - Style/PercentLiteralDelimiters
   - Style/HashSyntax
 - spec/live/target_spec.rb:
   - Style/HashSyntax
   - Lint/BooleanSymbol
 - spec/live/ticket_field_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/ticket_form_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/ticket_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/PercentLiteralDelimiters
-  - Layout/FirstHashElementIndentation
 - spec/live/topic_spec.rb:
   - Style/HashSyntax
 - spec/live/trigger_category_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/trigger_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/live/upload_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/user_field_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/user_spec.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Style/HashSyntax
 - spec/live/user_view_spec.rb:
   - Style/HashSyntax
-  - Layout/HashAlignment
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/live/view_spec.rb:
   - Style/HashSyntax
-  - Layout/SpaceInsideHashLiteralBraces
 - spec/macros/resource_macros.rb:
-  - Layout/SpaceInsideHashLiteralBraces
   - Lint/RedundantStringCoercion
   - Style/HashSyntax
   - Performance/RedundantMerge
   - Style/MultilineIfModifier
-- zendesk_api.gemspec:
-  - Layout/ExtraSpacing

lib/zendesk_api/actions.rb

@@ -172,7 +172,7 @@ module CreateMany
     # @return [JobStatus] the {JobStatus} instance for this create job
     def create_many!(client, attributes_array, association = Association.new(:class => self))
       response = client.connection.post("#{association.generate_path}/create_many") do |req|
-        req.body = { resource_name => attributes_array }
+        req.body = {resource_name => attributes_array}
 
         yield req if block_given?
       end
@@ -187,7 +187,7 @@ module CreateOrUpdate
     # @param [Hash] attributes The attributes to create.
     def create_or_update!(client, attributes, association = Association.new(:class => self))
       response = client.connection.post("#{association.generate_path}/create_or_update") do |req|
-        req.body = { singular_resource_name => attributes }
+        req.body = {singular_resource_name => attributes}
 
         yield req if block_given?
       end
@@ -207,7 +207,7 @@ def create_or_update_many!(client, attributes)
       association = Association.new(:class => self)
 
       response = client.connection.post("#{association.generate_path}/create_or_update_many") do |req|
-        req.body = { resource_name => attributes }
+        req.body = {resource_name => attributes}
 
         yield req if block_given?
       end
@@ -271,7 +271,7 @@ module DestroyMany
     # @return [JobStatus] the {JobStatus} instance for this destroy job
     def destroy_many!(client, ids, association = Association.new(:class => self))
       response = client.connection.delete("#{association.generate_path}/destroy_many") do |req|
-        req.params = { :ids => ids.join(",") }
+        req.params = {:ids => ids.join(",")}
 
         yield req if block_given?
       end
@@ -319,10 +319,10 @@ def update_many!(client, ids_or_attributes, attributes = {})
 
       response = client.connection.put("#{association.generate_path}/update_many") do |req|
         if attributes == {}
-          req.body = { resource_name => ids_or_attributes }
+          req.body = {resource_name => ids_or_attributes}
         else
-          req.params = { :ids => ids_or_attributes.join(",") }
-          req.body = { singular_resource_name => attributes }
+          req.params = {:ids => ids_or_attributes.join(",")}
+          req.body = {singular_resource_name => attributes}
         end
 
         yield req if block_given?

lib/zendesk_api/association.rb

@@ -109,15 +109,15 @@ def _side_load(resource, side_loads)
     def side_load_from_parent_id(resource, side_loads, key)
       key = "#{resource.class.singular_resource_name}_id"
 
-      resource.send("#{options.name}=", _side_load(resource, side_loads.select {|side_load|
+      resource.send("#{options.name}=", _side_load(resource, side_loads.select { |side_load|
         side_load[key] == resource.id
       }))
     end
 
     def side_load_from_child_ids(resource, side_loads, plural_key)
       ids = resource.send(plural_key)
 
-      resource.send("#{options.name}=", _side_load(resource, side_loads.select {|side_load|
+      resource.send("#{options.name}=", _side_load(resource, side_loads.select { |side_load|
         ids.include?(side_load[options.include_key])
       }))
     end

lib/zendesk_api/client.rb

@@ -44,7 +44,7 @@ def method_missing(method, *args, &)
         return ZendeskAPI::Collection.new(self, resource_class, options)
       end
 
-      @resource_cache[method] ||= { :class => nil, :cache => ZendeskAPI::LRUCache.new }
+      @resource_cache[method] ||= {:class => nil, :cache => ZendeskAPI::LRUCache.new}
       if !options.delete(:reload) && (cached = @resource_cache[method][:cache].read(options.hash))
         cached
       else
@@ -191,9 +191,9 @@ def build_connection
         # Should always be first in the stack
         if config.retry
           builder.use ZendeskAPI::Middleware::Request::Retry,
-                      :logger => config.logger,
-                      :retry_codes => config.retry_codes,
-                      :retry_on_exception => config.retry_on_exception
+            :logger => config.logger,
+            :retry_codes => config.retry_codes,
+            :retry_on_exception => config.retry_on_exception
         end
         if config.raise_error_when_rate_limited
           builder.use ZendeskAPI::Middleware::Request::RaiseRateLimited, :logger => config.logger

lib/zendesk_api/collection.rb

@@ -378,7 +378,7 @@ def join_special_params
     def set_association_from_options
       @collection_path = @options.delete(:collection_path)
 
-      association_options = { :path => @options.delete(:path) }
+      association_options = {:path => @options.delete(:path)}
       association_options[:path] ||= @collection_path.join("/") if @collection_path
       @association = @options.delete(:association) || Association.new(association_options.merge(:class => @resource_class))
       @collection_path ||= [@resource]
@@ -443,7 +443,7 @@ def wrap_resource(res, with_association = with_association?)
         res = res.merge(:association => @association) if with_association
         @resource_class.new(@client, res)
       else
-        res = { :id => res }
+        res = {:id => res}
         res.merge!(:association => @association) if with_association
         @resource_class.new(@client, res)
       end