Lint: Fix simple offenses

These changes were all done with `standardrb --fix`.

Author: bquorning

.standard_todo.yml

@@ -2,202 +2,37 @@
 # Remove from this list as you refactor files.
 ---
 ignore:
-- Rakefile:
-  - Style/HashSyntax
-  - Style/PercentLiteralDelimiters
 - lib/zendesk_api/actions.rb:
   - Lint/AssignmentInCondition
-  - Style/HashSyntax
 - lib/zendesk_api/association.rb:
-  - Style/HashSyntax
   - Lint/AssignmentInCondition
   - Lint/ShadowedArgument
   - Style/SafeNavigation
 - lib/zendesk_api/associations.rb:
-  - Style/HashSyntax
-  - Style/EachWithObject
   - Lint/AssignmentInCondition
   - Performance/RedundantMerge
 - lib/zendesk_api/client.rb:
   - Style/MissingRespondToMissing
-  - Style/HashSyntax
   - Lint/AssignmentInCondition
 - lib/zendesk_api/collection.rb:
-  - Style/PercentLiteralDelimiters
   - Performance/RedundantMerge
-  - Style/HashSyntax
   - Style/SafeNavigation
-  - Style/Alias
-  - Performance/StringIdentifierArgument
-  - Style/ParenthesesAroundCondition
-- lib/zendesk_api/configuration.rb:
-  - Style/HashSyntax
-- lib/zendesk_api/middleware/request/encode_json.rb:
-  - Lint/Void
-- lib/zendesk_api/middleware/request/etag_cache.rb:
-  - Style/HashSyntax
 - lib/zendesk_api/middleware/request/retry.rb:
-  - Style/TernaryParentheses
-  - Style/RescueStandardError
   - Style/SafeNavigation
-- lib/zendesk_api/middleware/response/logger.rb:
-  - Lint/RedundantStringCoercion
-- lib/zendesk_api/pagination.rb:
-  - Style/Alias
 - lib/zendesk_api/resource.rb:
-  - Style/Alias
   - Style/TrivialAccessors
-  - Style/HashSyntax
   - Lint/DuplicateMethods
-  - Performance/Caller
 - lib/zendesk_api/resources.rb:
-  - Style/Alias
-  - Style/HashSyntax
-  - Style/PercentLiteralDelimiters
   - Lint/AssignmentInCondition
-- lib/zendesk_api/search.rb:
-  - Style/Alias
-- lib/zendesk_api/track_changes.rb:
-  - Style/Alias
-- spec/core/association_spec.rb:
-  - Style/HashSyntax
-- spec/core/bulk_actions_spec.rb:
-  - Style/HashSyntax
-- spec/core/client_spec.rb:
-  - Style/HashSyntax
 - spec/core/collection_spec.rb:
-  - Style/HashSyntax
   - Lint/ConstantDefinitionInBlock
   - Lint/InheritException
-  - Style/Proc
-  - Style/PercentLiteralDelimiters
-  - Style/TernaryParentheses
-- spec/core/configuration_spec.rb:
-  - Style/HashSyntax
-- spec/core/create_resource_spec.rb:
-  - Style/HashSyntax
-- spec/core/data_resource_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/request/encode_json_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/request/etag_cache_spec.rb:
-  - Style/HashSyntax
-  - Style/PercentLiteralDelimiters
-- spec/core/middleware/request/retry_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/request/upload_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/response/callback_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/response/deflate_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/response/gzip_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/response/parse_json_spec.rb:
-  - Style/HashSyntax
-- spec/core/middleware/response/raise_error_spec.rb:
-  - Style/HashSyntax
-- spec/core/read_resource_spec.rb:
-  - Style/HashSyntax
 - spec/core/resource_spec.rb:
-  - Style/HashSyntax
   - Lint/ConstantDefinitionInBlock
-  - Style/PercentLiteralDelimiters
-- spec/core/resources/automation_spec.rb:
-  - Style/HashSyntax
-- spec/core/resources/macro_spec.rb:
-  - Style/HashSyntax
-- spec/core/resources/trigger_spec.rb:
-  - Style/HashSyntax
-- spec/core/resources/view_spec.rb:
-  - Style/HashSyntax
-  - Style/PercentLiteralDelimiters
 - spec/core/spec_helper.rb:
   - Style/GlobalVars
-  - Style/HashSyntax
   - Style/MixinUsage
-- spec/core/trackie_spec.rb:
-  - Style/BlockComments
-- spec/fixtures/zendesk.rb:
-  - Style/HashSyntax
-- spec/live/app_installation_spec.rb:
-  - Style/HashSyntax
-  - Style/PercentLiteralDelimiters
-- spec/live/app_spec.rb:
-  - Style/HashSyntax
-  - Style/PercentLiteralDelimiters
-- spec/live/article_spec.rb:
-  - Style/HashSyntax
-- spec/live/automation_spec.rb:
-  - Style/HashSyntax
-- spec/live/bookmark_spec.rb:
-  - Style/HashSyntax
-- spec/live/brand_spec.rb:
-  - Style/HashSyntax
-- spec/live/category_spec.rb:
-  - Style/HashSyntax
-- spec/live/dynamic_content/item_spec.rb:
-  - Style/HashSyntax
-- spec/live/dynamic_content/variant_spec.rb:
-  - Style/HashSyntax
-- spec/live/group_membership_spec.rb:
-  - Style/HashSyntax
-- spec/live/group_spec.rb:
-  - Style/HashSyntax
-- spec/live/identity_spec.rb:
-  - Style/HashSyntax
-- spec/live/macro_spec.rb:
-  - Style/HashSyntax
-  - Lint/RedundantStringCoercion
-- spec/live/organization_field_spec.rb:
-  - Style/HashSyntax
-- spec/live/organization_membership_spec.rb:
-  - Style/HashSyntax
-- spec/live/organization_spec.rb:
-  - Style/HashSyntax
-- spec/live/organization_subscription_spec.rb:
-  - Style/HashSyntax
-- spec/live/push_notification_device_spec.rb:
-  - Style/PercentLiteralDelimiters
-- spec/live/request_spec.rb:
-  - Style/HashSyntax
-- spec/live/section_spec.rb:
-  - Style/HashSyntax
-- spec/live/setting_spec.rb:
-  - Style/HashSyntax
-- spec/live/suspended_ticket_spec.rb:
-  - Style/HashSyntax
-- spec/live/tag_spec.rb:
-  - Style/PercentLiteralDelimiters
-  - Style/HashSyntax
 - spec/live/target_spec.rb:
-  - Style/HashSyntax
   - Lint/BooleanSymbol
-- spec/live/ticket_field_spec.rb:
-  - Style/HashSyntax
-- spec/live/ticket_form_spec.rb:
-  - Style/HashSyntax
-- spec/live/ticket_spec.rb:
-  - Style/HashSyntax
-  - Style/PercentLiteralDelimiters
-- spec/live/topic_spec.rb:
-  - Style/HashSyntax
-- spec/live/trigger_category_spec.rb:
-  - Style/HashSyntax
-- spec/live/trigger_spec.rb:
-  - Style/HashSyntax
-- spec/live/upload_spec.rb:
-  - Style/HashSyntax
-- spec/live/user_field_spec.rb:
-  - Style/HashSyntax
-- spec/live/user_spec.rb:
-  - Style/HashSyntax
-- spec/live/user_view_spec.rb:
-  - Style/HashSyntax
-- spec/live/view_spec.rb:
-  - Style/HashSyntax
 - spec/macros/resource_macros.rb:
-  - Lint/RedundantStringCoercion
-  - Style/HashSyntax
   - Performance/RedundantMerge
-  - Style/MultilineIfModifier

Rakefile

@@ -33,13 +33,13 @@ if defined?(RSpec)
   end
 
   desc "Default: run specs."
-  task :default => "spec"
+  task default: "spec"
 end
 
 # extracted from https://github.com/grosser/project_template
 rule(/^version:bump:.*/) do |t|
   sh "git status | grep 'nothing to commit'" # ensure we are not dirty
-  index = %w(major minor patch).index(t.name.split(":").last)
+  index = %w[major minor patch].index(t.name.split(":").last)
   file = "lib/zendesk_api/version.rb"
 
   version_file = File.read(file)

lib/zendesk_api/actions.rb

@@ -110,7 +110,7 @@ def find!(client, options = {})
         @client = client # so we can use client.logger in rescue
 
         raise ArgumentError, "No :id given" unless options[:id] || options["id"] || ancestors.include?(SingularResource)
-        association = options.delete(:association) || Association.new(:class => self)
+        association = options.delete(:association) || Association.new(class: self)
 
         includes = Array(options[:include])
         options[:include] = includes.join(",") if includes.any?
@@ -170,7 +170,7 @@ module CreateMany
     # @param [Client] client The {Client} object to be used
     # @param [Array] attributes_array An array of resources to be created.
     # @return [JobStatus] the {JobStatus} instance for this create job
-    def create_many!(client, attributes_array, association = Association.new(:class => self))
+    def create_many!(client, attributes_array, association = Association.new(class: self))
       response = client.connection.post("#{association.generate_path}/create_many") do |req|
         req.body = {resource_name => attributes_array}
 
@@ -185,7 +185,7 @@ module CreateOrUpdate
     # Creates or updates resource using the create_or_update endpoint.
     # @param [Client] client The {Client} object to be used
     # @param [Hash] attributes The attributes to create.
-    def create_or_update!(client, attributes, association = Association.new(:class => self))
+    def create_or_update!(client, attributes, association = Association.new(class: self))
       response = client.connection.post("#{association.generate_path}/create_or_update") do |req|
         req.body = {singular_resource_name => attributes}
 
@@ -204,7 +204,7 @@ module CreateOrUpdateMany
     #
     # @return [JobStatus] the {JobStatus} instance for this destroy job
     def create_or_update_many!(client, attributes)
-      association = Association.new(:class => self)
+      association = Association.new(class: self)
 
       response = client.connection.post("#{association.generate_path}/create_or_update_many") do |req|
         req.body = {resource_name => attributes}
@@ -269,9 +269,9 @@ module DestroyMany
     # @param [Client] client The {Client} object to be used
     # @param [Array] ids An array of ids to destroy
     # @return [JobStatus] the {JobStatus} instance for this destroy job
-    def destroy_many!(client, ids, association = Association.new(:class => self))
+    def destroy_many!(client, ids, association = Association.new(class: self))
       response = client.connection.delete("#{association.generate_path}/destroy_many") do |req|
-        req.params = {:ids => ids.join(",")}
+        req.params = {ids: ids.join(",")}
 
         yield req if block_given?
       end
@@ -300,9 +300,9 @@ def update(client, attributes = {}, &)
       # @param [Hash] attributes The attributes to update. Default to {
       def update!(client, attributes = {}, &)
         ZendeskAPI::Client.check_deprecated_namespace_usage attributes, singular_resource_name
-        resource = new(client, :id => attributes.delete(:id), :global => attributes.delete(:global), :association => attributes.delete(:association))
+        resource = new(client, id: attributes.delete(:id), global: attributes.delete(:global), association: attributes.delete(:association))
         resource.attributes.merge!(attributes)
-        resource.save!(:force_update => resource.is_a?(SingularResource), &)
+        resource.save!(force_update: resource.is_a?(SingularResource), &)
         resource
       end
     end
@@ -315,13 +315,13 @@ module UpdateMany
     # @param [Hash] attributes The attributes to update resources with
     # @return [JobStatus] the {JobStatus} instance for this destroy job
     def update_many!(client, ids_or_attributes, attributes = {})
-      association = attributes.delete(:association) || Association.new(:class => self)
+      association = attributes.delete(:association) || Association.new(class: self)
 
       response = client.connection.put("#{association.generate_path}/update_many") do |req|
         if attributes == {}
           req.body = {resource_name => ids_or_attributes}
         else
-          req.params = {:ids => ids_or_attributes.join(",")}
+          req.params = {ids: ids_or_attributes.join(",")}
           req.body = {singular_resource_name => attributes}
         end
 

lib/zendesk_api/association.rb

@@ -43,7 +43,7 @@ def initialize(options = {})
     # * with_parent - Include the parent path (false by default)
     # * with_id - Include the instance id, if possible (true)
     def generate_path(*args)
-      options = SilentMash.new(:with_id => true)
+      options = SilentMash.new(with_id: true)
       if args.last.is_a?(Hash)
         original_options = args.pop
         options.merge!(original_options)