fix: *Remove Useless Function Props*: finally we carefully remove only actual function props and not every completion that has bad name e.g. global Symbol completion

Author: zardoy

src/configurationType.ts

@@ -67,7 +67,7 @@ export type Configuration = {
      */
     // volarLoadConfigPaths: string[]
     /**
-     * Removes `Symbol`, `caller`, `prototype` everywhere
+     * Removes annoying `Symbol`, `caller`, `prototype` everywhere
      * @default true
      *  */
     'removeUselessFunctionProps.enable': boolean

typescript/src/completions/functionPropsAndMethods.ts

@@ -1,13 +1,23 @@
 import { oneOf } from '@zardoy/utils'
+import { matchParents } from '../utils'
 import { sharedCompletionContext } from './sharedContext'
 
 export default (entries: ts.CompletionEntry[]) => {
     const { c, prevCompletionsMap } = sharedCompletionContext
 
     if (c('removeUselessFunctionProps.enable')) {
         entries = entries.filter(entry => {
-            if (oneOf(entry.kind, ts.ScriptElementKind.warning)) return true
-            return !['Symbol', 'caller', 'prototype'].includes(entry.name)
+            const completionDeclaration = entry.symbol?.valueDeclaration
+            if (
+                ['Symbol', 'caller', 'prototype'].includes(entry.name) &&
+                !oneOf(entry.kind, ts.ScriptElementKind.warning) &&
+                (entry.insertText === '[Symbol]' ||
+                    (completionDeclaration?.getSourceFile().fileName.includes('node_modules/typescript/lib/lib') &&
+                        matchParents(completionDeclaration.parent, ['InterfaceDeclaration'])?.name.text === 'Function'))
+            ) {
+                return false
+            }
+            return true
         })
     }
 

typescript/test/completions.spec.ts

@@ -415,6 +415,28 @@ test('String template type completions', () => {
     })
 })
 
+test('Remove Useless Function Props', () => {
+    const tester = fourslashLikeTester(/* ts */ `
+        const a = () => {}
+        a./*1*/
+        const b = {
+            Symbol: 5,
+            prototype: 5,
+            caller: 5,
+        }
+        b./*2*/
+    `)
+    const badProps = ['Symbol', 'caller', 'prototype']
+    tester.completion(1, {
+        excludes: badProps,
+    })
+    tester.completion(2, {
+        includes: {
+            names: badProps,
+        },
+    })
+})
+
 test('Switch Case Exclude Covered', () => {
     const [, _, numPositions] = fileContentsSpecialPositions(/*ts*/ `
         let test: 'foo' | 'bar'

typescript/test/testing.ts

@@ -130,7 +130,9 @@ export const fourslashLikeTester = (contents: string, fileName = entrypoint) =>
                     }
                 }
                 if (excludes) {
-                    expect(result?.entryNames, message).not.toContain(excludes)
+                    for (const exclude of excludes) {
+                        expect(result?.entryNames, message).not.toContain(exclude)
+                    }
                 }
             }
         },