Merge pull request #159 from zardoy/develop

Author: zardoy

src/configurationType.ts

@@ -115,10 +115,9 @@ export type Configuration = {
      */
     'suggestions.keywordsInsertText': 'none' | 'space'
     /**
-     * Will be `format-short` by default in future as super useful!
-     * Requires TypeScript 5.0+
+     * Wether to show module name from which completion comes (inserted at start of completion detail)
      * @recommended
-     * @default disable
+     * @default short-format
      */
     'suggestions.displayImportedInfo': 'disable' | 'short-format' | 'long-format'
     /**
@@ -441,8 +440,8 @@ export type Configuration = {
      */
     'disableMethodSnippets.jsxAttributes': boolean
     /**
-     * disable method snippets at function arguments
-     * @default true
+     * Wether to disable method snippets in function arguments
+     * @default false
      */
     'disableMethodSnippets.functionArguments': boolean
     /**

typescript/src/completions/displayImportedInfo.ts

@@ -9,7 +9,7 @@ export default (entries: ts.CompletionEntry[]) => {
     for (const entry of entries) {
         const { symbol } = entry
         if (!symbol) continue
-        const [node] = symbol.getDeclarations() ?? []
+        const [node] = symbol.declarations ?? []
         if (!node) continue
         let importDeclaration: ts.ImportDeclaration | undefined
         if (ts.isImportSpecifier(node) && ts.isNamedImports(node.parent) && ts.isImportDeclaration(node.parent.parent.parent)) {

typescript/src/completionsAtPosition.ts

@@ -91,8 +91,12 @@ export const getCompletionsAtPosition = (
         }
     }
     let prior = getPrior()
+    // todo rethink its usage and maybe always prefill instead
     const ensurePrior = () => {
-        if (!prior) prior = { entries: [], isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false }
+        if (!prior) {
+            prior = { entries: [], isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false }
+            ;(sharedCompletionContext.prior as typeof prior) = prior
+        }
         return true
     }
     const hasSuggestions = prior?.entries.some(({ kind }) => kind !== ts.ScriptElementKind.warning)