Skip to content

Commit 6754755

Browse files
claytonrcarterprarit
authored andcommitted
test: Update tests for changes to fixture project
1 parent 25d4969 commit 6754755

File tree

2 files changed

+20
-19
lines changed

2 files changed

+20
-19
lines changed

cmd/mr_show_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,16 @@ Branches: mrtest->master
3333
Status: Open
3434
Assignee: zaquestion
3535
Author: zaquestion
36-
Approved By: None
36+
Approved By: lab-testing
3737
Approvers: None
3838
Approval Groups: None
3939
Reviewers: None
40-
Milestone: None
40+
Milestone: 1.0
4141
Labels: documentation
4242
Issues Closed by this MR:
4343
Subscribed: Yes
4444
Created At: 2017-09-19 03:55:51.674 +0000 UTC
45-
Updated At: 2022-06-24 22:22:06.551 +0000 UTC
45+
Updated At: 2023-05-25 01:45:54.027 +0000 UTC
4646
WebURL: https://gitlab.com/zaquestion/test/-/merge_requests/1`)
4747
require.Contains(t, string(b), `commented at`)
4848
require.Contains(t, string(b), `updated comment at`)

cmd/mr_test.go

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -519,18 +519,11 @@ func Test_mrCmd_assign_and_review(t *testing.T) {
519519
mrID = s[0]
520520
// strip off "!"
521521
mrID = mrID[1:]
522+
t.Log("mrID:", mrID)
522523

523524
mrURL := "https://gitlab.com/zaquestion/test/-/merge_requests/" + mrID
524525

525526
t.Run("assign_and_unassign", func(t *testing.T) {
526-
mrEdit := exec.Command(labBinaryPath, "mr", "edit", mrID, "--assign", "lab-testing")
527-
mrEdit.Dir = repo
528-
mrEditOut, err := mrEdit.CombinedOutput()
529-
if err != nil {
530-
t.Log(string(mrEditOut))
531-
t.Fatal(err)
532-
}
533-
534527
mrList := exec.Command(labBinaryPath, "mr", "list", "--assignee", "lab-testing")
535528
mrList.Dir = repo
536529
mrListOut, err := mrList.CombinedOutput()
@@ -547,21 +540,21 @@ func Test_mrCmd_assign_and_review(t *testing.T) {
547540
t.Fatal(err)
548541
}
549542

550-
require.Contains(t, string(mrEditOut), mrURL)
551-
require.Contains(t, string(mrListOut), mrIDString)
552-
require.Contains(t, string(mrUnEditOut), mrURL)
553-
})
554-
555-
// This tests 'lab mr edit --review' and 'lab mr list --unreview'
556-
t.Run("review_and_unreview", func(t *testing.T) {
557-
mrEdit := exec.Command(labBinaryPath, "mr", "edit", mrID, "--review", "lab-testing")
543+
mrEdit := exec.Command(labBinaryPath, "mr", "edit", mrID, "--assign", "lab-testing")
558544
mrEdit.Dir = repo
559545
mrEditOut, err := mrEdit.CombinedOutput()
560546
if err != nil {
561547
t.Log(string(mrEditOut))
562548
t.Fatal(err)
563549
}
564550

551+
require.Contains(t, string(mrEditOut), mrURL)
552+
require.Contains(t, string(mrListOut), mrIDString)
553+
require.Contains(t, string(mrUnEditOut), mrURL)
554+
})
555+
556+
// This tests 'lab mr edit --review' and 'lab mr list --unreview'
557+
t.Run("review_and_unreview", func(t *testing.T) {
565558
mrList := exec.Command(labBinaryPath, "mr", "list", "--reviewer", "lab-testing")
566559
mrList.Dir = repo
567560
mrListOut, err := mrList.CombinedOutput()
@@ -578,6 +571,14 @@ func Test_mrCmd_assign_and_review(t *testing.T) {
578571
t.Fatal(err)
579572
}
580573

574+
mrEdit := exec.Command(labBinaryPath, "mr", "edit", mrID, "--review", "lab-testing")
575+
mrEdit.Dir = repo
576+
mrEditOut, err := mrEdit.CombinedOutput()
577+
if err != nil {
578+
t.Log(string(mrEditOut))
579+
t.Fatal(err)
580+
}
581+
581582
require.Contains(t, string(mrEditOut), mrURL)
582583
require.Contains(t, string(mrListOut), mrIDString)
583584
require.Contains(t, string(mrUnEditOut), mrURL)

0 commit comments

Comments
 (0)