Skip to content

Fix/cpp23 aligned storage #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix/cpp23 aligned storage #1184

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf417b3
chore: increase cmake mimimum version
FelixHommel Nov 12, 2025
468461b
fix: resolve depracation issues with c++23 and std::aligned_storage
FelixHommel Nov 12, 2025
dbe1190
chore: add some explaining comments
FelixHommel Nov 12, 2025
75e1a0e
chore: rollback cmake minimum version
FelixHommel Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion websocketpp/common/type_traits.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#ifndef WEBSOCKETPP_COMMON_TYPE_TRAITS_HPP
#define WEBSOCKETPP_COMMON_TYPE_TRAITS_HPP

#include <cstddef>
#include <websocketpp/common/cpp11.hpp>

// If we've determined that we're in full C++11 mode and the user hasn't
Expand All @@ -52,7 +53,18 @@ namespace websocketpp {
namespace lib {

#ifdef _WEBSOCKETPP_CPP11_TYPE_TRAITS_
using std::aligned_storage;
// NOTE: this is may not be the best way to detect c++23 compilers, but it worked fine for all test I did
// std::aligned_storage has been depracated as of c++23 (see P1413R3 for more details)
template<std::size_t N>
struct aligned_storage {
#if __cplusplus >= 202300L
struct type {
alignas(std::max_align_t) unsigned char data[N];
};
#else
using type = typename std::aligned_storage<N>::type;
#endif
};
using std::is_same;
#else
using boost::aligned_storage;
Expand Down