refactor: artifacthub catalog ID to pacpipelines

- Updated the internal pipeline hub catalog identifier from `pachub` to
  `pacpipelines`.
- Renamed the associated catalog display name from `pipelines-as-code`
  to `pac-pipelines`.
- Adjusted the `pipelinerun-remote-pipeline-from-hub.yaml` test data to
  reflect the new catalog ID.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

hack/dev/kind/install.sh

@@ -192,11 +192,21 @@ function configure_pac() {
 
   sed -e "s,%DOMAIN_NAME%,${DOMAIN_NAME}," -e "s,%SERVICE_NAME%,${service_name}," ingress-pac.yaml | kubectl apply -f-
 
-  kubectl patch configmap -n pipelines-as-code -p "{\"data\":{\"bitbucket-cloud-check-source-ip\": \"false\"}}" pipelines-as-code &&
-    kubectl patch configmap -n pipelines-as-code -p "{\"data\":{\"tekton-dashboard-url\": \"http://dashboard.${DOMAIN_NAME}\"}}" --type merge pipelines-as-code &&
-    kubectl patch configmap -n pipelines-as-code -p \
-      '{"data":{"catalog-1-type": "artifacthub", "catalog-1-id": "pachub", "catalog-1-name": "pipelines-as-code", "catalog-1-url": "https://artifacthub.io"}}' \
-      --type merge pipelines-as-code
+  patch_data=$(
+    cat <<EOF
+{
+  "data": {
+    "bitbucket-cloud-check-source-ip": "false",
+    "tekton-dashboard-url": "http://dashboard.${DOMAIN_NAME}",
+    "catalog-1-type": "artifacthub",
+    "catalog-1-id": "pacpipelines",
+    "catalog-1-name": "pac-pipelines",
+    "catalog-1-url": "https://artifacthub.io"
+  }
+}
+EOF
+  )
+  kubectl patch configmap -n pipelines-as-code pipelines-as-code --type merge --patch "${patch_data}"
   kubectl patch configmap pac-config-logging -n pipelines-as-code --type json -p '[{"op": "replace", "path": "/data/loglevel.pipelinesascode", "value":"debug"}]'
   set +x
   if [[ -n ${PAC_PASS_SECRET_FOLDER} ]]; then

test/testdata/pipelinerun-remote-pipeline-from-hub.yaml

@@ -6,7 +6,7 @@ metadata:
     pipelinesascode.tekton.dev/target-namespace: "\\ .TargetNamespace //"
     pipelinesascode.tekton.dev/on-target-branch: "[\\ .TargetBranch //]"
     pipelinesascode.tekton.dev/on-event: "[\\ .TargetEvent //]"
-    pipelinesascode.tekton.dev/pipeline: "pachub://test"
+    pipelinesascode.tekton.dev/pipeline: "pacpipelines://test"
 spec:
   pipelineRef:
     name: test