refactor(lint): only call format when necessary

Author: z0al

lib/lint.js

@@ -31,9 +31,13 @@ async function commitlint(context) {
 	// Paginate all PR commits
 	return paginate(pullRequests.getCommits(pull), async ({ data }) => {
 		// empty summary
-		const report = { valid: true, commits: {} }
+		const report = { valid: true, commits: [] }
 		const { rules } = await load(config)
 
+		// Keep counters
+		let errorsCount = 0
+		let warnsCount = 0
+
 		// Iterates over all commits
 		for (const d of data) {
 			const { valid, errors, warnings } = await lint(d.commit.message, rules)
@@ -42,21 +46,24 @@ async function commitlint(context) {
 			}
 
 			if (errors.length > 0 || warnings.length > 0) {
-				report.commits[d.sha] = { errors, warnings }
+				// Update counts
+				errorsCount += errors.length
+				warnsCount += warnings.length
+
+				report.commits.push({ sha: d.sha, errors, warnings })
 			}
 		}
 
-		const { summary, message } = format(report)
-
 		// Final status
 		await repos.createStatus({
 			...statusInfo,
 			state: report.valid ? 'success' : 'failure',
-			description: summary
+			description: `found ${errorsCount} problems, ${warnsCount} warnings`
 		})
 
 		// Write a comment with the details (if any)
-		if (message) {
+		if (errorsCount > 0 || warnsCount > 0) {
+			const message = format(report.commits)
 			await issues.createComment({ ...pull, body: message })
 		}
 	})