refactor:submission UI

Author: yuvrajsinh5252

2529.cpp

@@ -4,6 +4,12 @@
 from typing import Optional
 from ..server.auth import Auth
 from ..server.solution_manager import SolutionManager
+from ..lib.submission_ui import (
+    display_auth_error, display_file_not_found_error, display_language_detection_message,
+    display_language_detection_error, display_problem_not_found_error, display_submission_details,
+    display_submission_canceled, create_submission_progress, display_submission_results,
+    display_exception_error
+)
 
 auth_manager = Auth()
 solution_manager = SolutionManager(auth_manager.get_session())
@@ -36,57 +42,45 @@ def submit(
     Language is auto-detected from file extension if not specified.
     """
     if not auth_manager.is_authenticated:
-        typer.echo(typer.style("❌ Please login first using the login command", fg=typer.colors.RED))
-        raise typer.Exit(1)
+        display_auth_error()
 
     if not file.exists():
-        typer.echo(typer.style(f"❌ File not found: {file}", fg=typer.colors.RED))
-        raise typer.Exit(1)
+        display_file_not_found_error(file)
 
     try:
         # Auto-detect language from file extension if not provided
         if not lang:
             extension = os.path.splitext(file)[1].lower()
             if extension in LANGUAGE_MAP:
                 lang = LANGUAGE_MAP[extension]
-                typer.echo(typer.style(f"🔍 Auto-detected language: {lang}", fg=typer.colors.BLUE))
+                display_language_detection_message(lang)
             else:
-                typer.echo(typer.style(f"❌ Could not detect language for {extension} files. Please specify with --lang", fg=typer.colors.RED))
-                raise typer.Exit(1)
+                display_language_detection_error(extension)
 
         with open(file, 'r') as f:
             code = f.read()
 
         # Confirm submission unless forced
         if not force:
-            typer.echo(typer.style(f"Problem: {problem}", fg=typer.colors.BLUE))
-            typer.echo(typer.style(f"Language: {lang}", fg=typer.colors.BLUE))
-            typer.echo(typer.style(f"File: {file}", fg=typer.colors.BLUE))
-            if not typer.confirm("Do you want to submit this solution?"):
-                typer.echo(typer.style("Submission canceled", fg=typer.colors.YELLOW))
-                raise typer.Exit(0)
+            problem_name = solution_manager.get_question_data(problem).get('data', {}).get('question', {}).get('title')
 
-        typer.echo(typer.style("📤 Submitting solution...", fg=typer.colors.YELLOW))
-        result = solution_manager.submit_solution(problem, code, lang)
+            if not problem_name:
+                display_problem_not_found_error(problem)
 
-        if result["success"]:
-            status = result['status']
-            status_color = (
-                typer.colors.GREEN if status == "Accepted"
-                else typer.colors.YELLOW if status == "Runtime Error" or status == "Time Limit Exceeded"
-                else typer.colors.RED
-            )
+            if not display_submission_details(problem, problem_name, lang, file):
+                display_submission_canceled()
 
-            typer.echo(typer.style(f"\n✨ Status: {status}", fg=status_color))
-            typer.echo(f"⏱️  Runtime: {result['runtime']}")
-            typer.echo(f"💾 Memory: {result['memory']}")
-            typer.echo(f"✅ Passed: {result['passed_testcases']}/{result['total_testcases']} test cases")
+        if not lang:
+            display_language_detection_error("")
+            return
+
+        with create_submission_progress() as progress:
+            submit_task = progress.add_task("Submitting...", total=1)
+            progress.update(submit_task, advance=0.5)
+            result = solution_manager.submit_solution(problem, code, lang)
+            progress.update(submit_task, advance=0.5)
 
-            if status != "Accepted":
-                typer.echo(typer.style(f"\n❗ Error message: {result.get('error_message', 'No details available')}", fg=typer.colors.RED))
-        else:
-            typer.echo(typer.style(f"\n❌ Submission failed: {result['error']}", fg=typer.colors.RED))
+        display_submission_results(result)
 
     except Exception as e:
-        typer.echo(typer.style(f"❌ Error: {str(e)}", fg=typer.colors.RED))
-        raise typer.Exit(1)
+        display_exception_error(e)

src/commands/submit.py

@@ -0,0 +1,123 @@
+from rich.console import Console
+from rich.panel import Panel
+from rich.table import Table
+from rich.progress import Progress, BarColumn, TextColumn
+from rich import box
+from rich.text import Text
+from rich.columns import Columns
+import typer
+
+console = Console()
+
+def display_auth_error():
+    """Display error message when not authenticated"""
+    console.print(Panel("❌ Please login first using the login command",
+                      style="bold red", border_style="red"))
+    raise typer.Exit(1)
+
+def display_file_not_found_error(file):
+    """Display error message when file is not found"""
+    console.print(Panel(f"❌ File not found: {file}", style="bold red", border_style="red"))
+    raise typer.Exit(1)
+
+def display_language_detection_message(lang):
+    """Display auto-detected language message"""
+    console.print(f"🔍 Auto-detected language: [cyan]{lang}[/]")
+
+def display_language_detection_error(extension):
+    """Display error message when language cannot be detected"""
+    console.print(Panel(f"❌ Could not detect language for {extension} files. Please specify with --lang",
+                      style="bold red", border_style="red"))
+    raise typer.Exit(1)
+
+def display_problem_not_found_error(problem):
+    """Display error message when problem is not found"""
+    console.print(Panel(f"❌ Problem not found: {problem}", style="bold red", border_style="red"))
+    raise typer.Exit(1)
+
+def display_submission_details(problem, problem_name, lang, file):
+    """Display submission details and confirmation prompt using a clean layout"""
+    # Create formatted text lines instead of a nested table
+    content = [
+        f"[cyan]Problem:[/] {problem} - {problem_name}",
+        f"[cyan]Language:[/] {lang}",
+        f"[cyan]File:[/] {str(file)}"
+    ]
+
+    console.print(Panel(
+        "\n".join(content),
+        title="Submission Details",
+        border_style="blue",
+        box=box.ROUNDED
+    ))
+
+    return typer.confirm("Do you want to submit this solution?")
+
+def display_submission_canceled():
+    """Display submission canceled message"""
+    console.print("[yellow]Submission canceled[/]")
+    raise typer.Exit(0)
+
+def create_submission_progress():
+    """Create and return a submission progress context"""
+    return Progress(
+        TextColumn("[bold yellow]Submitting solution...", justify="right"),
+        BarColumn(bar_width=40, style="yellow"),
+        transient=True,
+    )
+
+def display_submission_results(result):
+    """Display submission results with a cleaner layout"""
+    if result["success"]:
+        status = result['status']
+
+        # Set colors based on status
+        if status == "Accepted":
+            status_style = "bold green"
+            border_style = "green"
+            emoji = "✅"
+        elif status in ["Runtime Error", "Time Limit Exceeded"]:
+            status_style = "bold yellow"
+            border_style = "yellow"
+            emoji = "⚠️"
+        else:
+            status_style = "bold red"
+            border_style = "red"
+            emoji = "❌"
+
+        # Get metrics
+        runtime = result.get('runtime', 'N/A')
+        memory = result.get('memory', 'N/A')
+        passed = result.get('passed_testcases', 0)
+        total = result.get('total_testcases', 0)
+        test_case_str = f"{passed}/{total} ({passed/total*100:.1f}%)" if total > 0 else "N/A"
+
+        content = [
+            f"[cyan]⏱️ Runtime:[/] {runtime}",
+            f"[cyan]💾 Memory:[/] {memory}",
+            f"[cyan]🧪 Test Cases:[/] {test_case_str}"
+        ]
+
+        title = f"{emoji} Submission Result: [{status_style}]{status}[/]"
+        console.print(Panel(
+            "\n".join(content),
+            title=title,
+            border_style=border_style,
+            box=box.ROUNDED
+        ))
+
+        if status != "Accepted" and result.get('error_message'):
+            error_msg = result.get('error_message', 'No details available')
+            console.print(Panel(error_msg, title="Error Details", border_style="red"))
+    else:
+        error_panel = Panel(
+            f"{result.get('error', 'Unknown error')}",
+            title="❌ Submission Failed",
+            border_style="red"
+        )
+        console.print(error_panel)
+
+def display_exception_error(e):
+    """Display exception error message"""
+    console.print(Panel(f"❌ Error: {str(e)}", style="bold red", border_style="red"))
+    raise typer.Exit(1)

src/lib/submission_ui.py

@@ -99,7 +99,7 @@ def submit_solution(self, title_slug: str, code: str, lang: str = "python3") ->
             if not question_data:
                 return {"success": False, "error": "Question data not found"}
 
-            question_id = question_data['questionFrontendId']
+            question_id = question_data['questionId']
             submit_url = f"{self.BASE_URL}/problems/{title_slug}/submit/"
 
             csrf_token = self._get_csrf_token()
@@ -158,7 +158,7 @@ def test_solution(self, title_slug: str, code: str, lang: str = "python3", full:
             if not question_data:
                 return {"success": False, "error": "Question data not found"}
 
-            question_id = question_data['questionFrontendId']
+            question_id = question_data['questionId']
             test_cases = question_data['exampleTestcaseList']
 
             endpoint = 'submit' if full else 'interpret_solution'