Merge pull request #438 from deflinhec/bugfix/coroutine-context-leak

Fix lua coroutine context leak

Author: yuin

_state.go

@@ -769,6 +769,9 @@ func (ls *LState) isStarted() bool {
 
 func (ls *LState) kill() {
 	ls.Dead = true
+	if ls.ctxCancelFn != nil {
+		ls.ctxCancelFn()
+	}
 }
 
 func (ls *LState) indexToReg(idx int) int {
@@ -1402,6 +1405,7 @@ func (ls *LState) NewThread() (*LState, context.CancelFunc) {
 	if ls.ctx != nil {
 		thread.mainLoop = mainLoopWithContext
 		thread.ctx, f = context.WithCancel(ls.ctx)
+		thread.ctxCancelFn = f
 	}
 	return thread, f
 }

state.go

@@ -815,6 +815,9 @@ func (ls *LState) isStarted() bool {
 
 func (ls *LState) kill() {
 	ls.Dead = true
+	if ls.ctxCancelFn != nil {
+		ls.ctxCancelFn()
+	}
 }
 
 func (ls *LState) indexToReg(idx int) int {
@@ -1561,6 +1564,7 @@ func (ls *LState) NewThread() (*LState, context.CancelFunc) {
 	if ls.ctx != nil {
 		thread.mainLoop = mainLoopWithContext
 		thread.ctx, f = context.WithCancel(ls.ctx)
+		thread.ctxCancelFn = f
 	}
 	return thread, f
 }

value.go

@@ -218,6 +218,7 @@ type LState struct {
 	hasErrorFunc bool
 	mainLoop     func(*LState, *callFrame)
 	ctx          context.Context
+	ctxCancelFn  context.CancelFunc
 }
 
 func (ls *LState) String() string                     { return fmt.Sprintf("thread: %p", ls) }