Skip to content

Commit f9ffc18

Browse files
yoanmyoanm
authored
[BC] Add sf 7.0 and drop 4.4 (#42)
1 parent ec9dfda commit f9ffc18

File tree

3 files changed

+25
-25
lines changed

3 files changed

+25
-25
lines changed

‎.github/workflows/reusable-CI-workflow.yml‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -63,27 +63,28 @@ jobs:
6363
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-max }}'
6464
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
6565
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
66-
- job-name: Up to date versions - Sf 5.4 case
66+
- job-name: Up to date versions - Sf 6.4 case
6767
php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
68-
symfony-version: '5.4'
68+
symfony-version: '6.4'
6969
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
70-
# Fix - symfony/yaml - Avoid issue with Sf YAML 6.4+ and Framework bundle
71-
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0' ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '6.4' ) && '--with "symfony/yaml:~6.4.0"' || '' }}
70+
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
7271
- job-name: Bare minimum # => Lowest versions allowed by composer config
7372
php-version: '${{ needs.fetch-supported-versions.outputs.php-min }}'
7473
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-min }}'
75-
- job-name: Bare minimum - Sf 5.4 case
76-
php-version: '${{ needs.fetch-supported-versions.outputs.php-min }}'
77-
symfony-version: '5.4'
78-
- job-name: Late PHP migration # => Highest symfony version with lowest php version allowed by composer config
74+
- job-name: Bare minimum - Sf 6.4 case
7975
# Fix - Sf 6.4 require php 8.1 minimum !
80-
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '6.4' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.1' || needs.fetch-supported-versions.outputs.php-min }}
76+
php-version: ${{ ( needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.1' || needs.fetch-supported-versions.outputs.php-min }}
77+
symfony-version: '6.4'
78+
- job-name: Late PHP migration # => Highest symfony version with lowest php version allowed by composer config
79+
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
80+
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
8181
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-max }}'
8282
- job-name: Late Symfony migration # => Lowest symfony version with highest php version allowed by composer config
8383
php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
8484
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-min }}'
8585
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
86-
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
86+
# Fix - symfony/yaml => Avoid issue between symfony/yaml and symfony/framework-bundle (not compatible with some versions due to incomplete function signatures)
87+
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0' ${{ ( needs.fetch-supported-versions.outputs.symfony-min == '5.4' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && '--with "symfony/yaml:~6.4.0"' || '' }}
8788
steps:
8889
- name: Check out code
8990
uses: actions/checkout@v5
@@ -247,20 +248,19 @@ jobs:
247248
php-version: ${{ needs.fetch-supported-versions.outputs.php-next }}
248249
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-min }}
249250
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
250-
pkg-extra-constraints: behat/gherkin:~4.12.0
251+
# Fix - symfony/yaml => Avoid issue between symfony/yaml and symfony/framework-bundle (not compatible with some versions due to incomplete function signatures)
252+
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-min == '5.4' && needs.fetch-supported-versions.outputs.php-next == '8.5' ) && 'symfony/yaml:~6.4.0' || '' }}
251253
- job-name: Symfony with highest supported PHP version
252254
php-version: ${{ needs.fetch-supported-versions.outputs.php-max }}
253255
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
254256
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
255-
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
256-
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
257+
pkg-extra-constraints: behat/gherkin:~4.12.0
257258
- job-name: Symfony with lowest supported PHP version
258-
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
259-
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
259+
# Fix - Sf 7.1 require php 8.2 minimum !
260+
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.1' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
260261
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
261262
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
262-
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
263-
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
263+
pkg-extra-constraints: behat/gherkin:~4.12.0
264264

265265
steps:
266266
- name: Check out code

‎.github/workflows/supported-versions.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"php": {"min": "8.0", "max": "8.4", "next": "8.5"},
3-
"symfony": {"min": "4.4", "max": "6.4", "next": "7.0"}
3+
"symfony": {"min": "5.4", "max": "7.0", "next": "7.1"}
44
}

‎composer.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
},
3232
"require": {
3333
"php": "^8.0",
34-
"symfony/config": "^4.4 || ^5.4 || ^6.0",
35-
"symfony/dependency-injection": "^4.4 || ^5.4 || ^6.0",
36-
"symfony/http-kernel": "^4.4 || ^5.4 || ^6.0",
34+
"symfony/config": "^5.4 || ^6.4 || ^7.0",
35+
"symfony/dependency-injection": "^5.4 || ^6.4 || ^7.0",
36+
"symfony/http-kernel": "^5.4 || ^6.4 || ^7.0",
3737
"yoanm/jsonrpc-params-symfony-validator-sdk": "^2.0"
3838
},
3939
"require-dev": {
@@ -47,12 +47,12 @@
4747
"phpunit/php-code-coverage": "^9.2.4",
4848
"phpunit/phpunit": "^9.0",
4949
"squizlabs/php_codesniffer": "^3.5",
50-
"symfony/framework-bundle": "^4.4 || ^5.4 || ^6.0",
51-
"symfony/http-foundation": "^4.4 || ^5.4 || ^6.0",
52-
"symfony/routing": "^4.4 || ^5.4 || ^6.0",
50+
"symfony/framework-bundle": "^5.4 || ^6.4 || ^7.0",
51+
"symfony/http-foundation": "^5.4 || ^6.4 || ^7.0",
52+
"symfony/routing": "^5.4 || ^6.4 || ^7.0",
5353
"yoanm/jsonrpc-server-sdk": "^3.0",
5454
"yoanm/php-unit-extended": "^2.0.2",
55-
"yoanm/symfony-jsonrpc-http-server": "^3.0"
55+
"yoanm/symfony-jsonrpc-http-server": "^3.0|| ^4.0"
5656
},
5757
"config": {
5858
"sort-packages": true

0 commit comments

Comments
 (0)