Skip to content

Commit f7ebdea

Browse files
authored
Test PHP 7.4 on Travis (#15)
1 parent 42a29bd commit f7ebdea

File tree

7 files changed

+13
-12
lines changed

7 files changed

+13
-12
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ php:
44
- '7.1'
55
- '7.2'
66
- '7.3'
7+
- '7.4'
78

89
env:
910
global:

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
"require": {
3232
"php": ">=7.1",
3333
"yoanm/jsonrpc-server-sdk": "^3.0",
34-
"yoanm/jsonrpc-params-symfony-validator-sdk": "^0.1",
35-
"yoanm/jsonrpc-params-symfony-constraint-doc-sdk": "^0.1",
36-
"yoanm/symfony-jsonrpc-http-server-doc": "^0.1",
34+
"yoanm/jsonrpc-params-symfony-validator-sdk": "^0.2",
35+
"yoanm/jsonrpc-params-symfony-constraint-doc-sdk": "^0.2",
36+
"yoanm/symfony-jsonrpc-http-server-doc": "^0.2",
3737
"symfony/http-kernel": "^3.0 || ^4.0",
3838
"symfony/dependency-injection": "^3.0 || ^4.0"
3939
},
@@ -42,7 +42,7 @@
4242
"behat/behat": "~3.0",
4343
"squizlabs/php_codesniffer": "3.*",
4444
"phpunit/phpunit": "^7.0 || ^8.0",
45-
"matthiasnoback/symfony-dependency-injection-test": "^2.0 || ^3.0",
45+
"matthiasnoback/symfony-dependency-injection-test": "^3.0 || ^4.0",
4646
"matthiasnoback/symfony-config-test": "^3.0 || ^4.0",
4747
"symfony/framework-bundle": "^3.0 || ^4.0",
4848
"yoanm/php-unit-extended": "~1.0"

tests/Common/DependencyInjection/AbstractTestClass.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ abstract class AbstractTestClass extends AbstractExtensionTestCase
1313
/**
1414
* {@inheritdoc}
1515
*/
16-
protected function getContainerExtensions()
16+
protected function getContainerExtensions(): array
1717
{
1818
return [
1919
new JsonRpcParamsSfConstraintsDocExtension()
2020
];
2121
}
2222

23-
protected function load(array $configurationValues = [])
23+
protected function loadContainer(array $configurationValues = []): void
2424
{
2525
parent::load($configurationValues);
2626

tests/Functional/DependencyInjection/ConfigFilesTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class ConfigFilesTest extends AbstractTestClass
2828
*/
2929
public function testShouldHaveService($serviceId, $expectedClassName, $public)
3030
{
31-
$this->load();
31+
$this->loadContainer();
3232

3333
$this->assertContainerBuilderHasService($serviceId, $expectedClassName);
3434
if (true === $public) {
@@ -41,7 +41,7 @@ public function testShouldHaveService($serviceId, $expectedClassName, $public)
4141

4242
public function testServerDocCreatedListenerShouldHaveRightTags()
4343
{
44-
$this->load();
44+
$this->loadContainer();
4545

4646
// From yoanm/symfony-jsonrpc-http-server
4747
$this->assertContainerBuilderHasServiceDefinitionWithTag(
@@ -56,7 +56,7 @@ public function testServerDocCreatedListenerShouldHaveRightTags()
5656

5757
public function testMethodDocCreatedListenerShouldHaveRightTags()
5858
{
59-
$this->load();
59+
$this->loadContainer();
6060

6161
// From yoanm/symfony-jsonrpc-http-server
6262
$this->assertContainerBuilderHasServiceDefinitionWithTag(

tests/Functional/DependencyInjection/JsonRpcParamsSfConstraintsDocExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class JsonRpcParamsSfConstraintsDocExtensionTest extends AbstractTestClass
1111
{
1212
public function testShouldBeLoadable()
1313
{
14-
$this->load();
14+
$this->loadContainer();
1515

1616
$this->assertIsLoadable();
1717
}

tests/Functional/Listener/MethodDocCreatedListenerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class MethodDocCreatedListenerTest extends TestCase
2424
/** ConstraintToParamsDocTransformer|ObjectProphecy */
2525
private $paramDocConverter;
2626

27-
protected function setUp()
27+
protected function setUp(): void
2828
{
2929
$this->paramDocConverter = $this->prophesize(ConstraintToParamsDocTransformer::class);
3030

tests/Functional/Listener/ServerDocCreatedListenerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class ServerDocCreatedListenerTest extends TestCase
1919
/** @var ServerDocCreatedListener */
2020
private $listener;
2121

22-
protected function setUp()
22+
protected function setUp(): void
2323
{
2424
$this->listener = new ServerDocCreatedListener();
2525
}

0 commit comments

Comments
 (0)