Improve (#5)

Author: yoanm

Makefile

@@ -6,6 +6,7 @@ COVERAGE_OUTPUT_STYLE ?= html
 BUILD_DIRECTORY ?= build
 REPORTS_DIRECTORY ?= ${BUILD_DIRECTORY}/reports
 COVERAGE_DIRECTORY ?= ${BUILD_DIRECTORY}/coverage
+BEHAT_COVERAGE_DIRECTORY ?= ${BUILD_DIRECTORY}/behat-coverage
 COVERAGE_CLOVER_FILE_PATH ?= ${COVERAGE_DIRECTORY}/clover.xml
 
 ## Commands options
@@ -88,15 +89,21 @@ codestyle: create-reports-directory
 coverage: create-coverage-directory
 	./vendor/bin/phpunit ${PHPUNIT_COLOR_OPTION} ${PHPUNIT_OUTPUT_STYLE_OPTION} ${PHPUNIT_COVERAGE_OPTION}
 
+behat-coverage: create-behat-coverage-directory
+	composer required leanphp/behat-code-coverage
+	./vendor/bin/behat ${BEHAT_COLOR_OPTION} ${BEHAT_OUTPUT_STYLE_OPTION} --no-snippets --profile coverage
 
 
 # Internal commands
 create-coverage-directory:
 	mkdir -p ${COVERAGE_DIRECTORY}
 
+create-behat-coverage-directory:
+	mkdir -p ${BEHAT_COVERAGE_DIRECTORY}
+
 create-reports-directory:
 	mkdir -p ${REPORTS_DIRECTORY}
 
 
-.PHONY: build install configure test test-technical test-functional codestyle coverage create-coverage-directory create-reports-directory
+.PHONY: build install configure test test-technical test-functional codestyle coverage behat-coverage create-coverage-directory create-behat-coverage-directory create-reports-directory
 .DEFAULT: build

behat.yml

@@ -3,3 +3,17 @@ default:
     default:
       contexts:
         - Tests\Functional\BehatContext\DemoAppContext: ~
+coverage:
+  extensions:
+    LeanPHP\Behat\CodeCoverage\Extension:
+      drivers:
+      - local
+      filter:
+        whitelist:
+          include:
+            directories:
+              'src': ~
+      report:
+        format:   html
+        options:
+          target: build/behat-coverage

composer.json

@@ -36,6 +36,7 @@
     "symfony/dependency-injection": "^3.0 || ^4.0"
   },
   "require-dev": {
+    "ext-json": "*",
     "behat/behat": "~3.0",
     "squizlabs/php_codesniffer": "3.*",
     "phpunit/phpunit": "^6.0 || ^7.0",

features/demo_app/src/Method/MethodA.php

@@ -9,14 +9,6 @@
 
 class MethodA implements JsonRpcMethodInterface, MethodWithValidatedParamsInterface
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function validateParams(array $paramList) : array
-    {
-        return [];
-    }
-
     /**
      * {@inheritdoc}
      */

features/demo_app/src/Method/MethodB.php

@@ -5,14 +5,6 @@
 
 class MethodB implements JsonRpcMethodInterface
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function validateParams(array $paramList) : array
-    {
-        return [];
-    }
-
     /**
      * {@inheritdoc}
      */

features/demo_app/src/Method/MethodC.php

@@ -10,14 +10,6 @@
 
 class MethodC implements JsonRpcMethodInterface, MethodWithValidatedParamsInterface
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function validateParams(array $paramList) : array
-    {
-        return [];
-    }
-
     /**
      * {@inheritdoc}
      */

phpunit.xml.dist

@@ -8,7 +8,6 @@
          processIsolation="false"
 
          stopOnRisky="true"
-
          stopOnError="true"
          stopOnFailure="true"
 

src/Listener/MethodDocCreatedListener.php

@@ -23,6 +23,8 @@ public function __construct(ConstraintToParamsDocTransformer $paramDocConverter)
 
     /**
      * @param MethodDocCreatedEvent $event
+     *
+     * @throws \ReflectionException
      */
     public function enhanceMethodDoc(MethodDocCreatedEvent $event)
     {