Improve (#38)

Author: yoanm

features/bootstrap/AbstractContext.php

@@ -0,0 +1,57 @@
+<?php
+namespace Tests\Functional\BehatContext;
+
+use Behat\Behat\Context\Context;
+use DemoApp\AbstractKernel;
+use DemoApp\DefaultKernel;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+class AbstractContext implements Context
+{
+    public function jsonDecode($encodedData)
+    {
+        $decoded = json_decode($encodedData, true);
+
+        if (JSON_ERROR_NONE != json_last_error()) {
+            throw new \Exception(
+                json_last_error_msg(),
+                json_last_error()
+            );
+        }
+
+        return $decoded;
+    }
+
+    /**
+     * @param string $uri
+     * @param string $httpMethod
+     * @param string $content
+     *
+     * @return Response
+     *
+     * @throws \Exception
+     */
+    public function sendHttpContentTo(string $uri, string $httpMethod, string $content): Response
+    {
+        $kernel = $this->getDemoAppKernel();
+        $kernel->boot();
+        $request = Request::create($uri, $httpMethod, [], [], [], [], $content);
+        $response = $kernel->handle($request);
+        $kernel->terminate($request, $response);
+        $kernel->shutdown();
+
+        return $response;
+    }
+
+    /**
+     * @return AbstractKernel
+     */
+    public function getDemoAppKernel()
+    {
+        $env = 'prod';
+        $debug = true;
+
+        return new DefaultKernel($env, $debug);
+    }
+}

features/bootstrap/DemoAppContext.php

@@ -1,19 +1,15 @@
 <?php
 namespace Tests\Functional\BehatContext;
 
-use Behat\Behat\Context\Context;
 use Behat\Gherkin\Node\PyStringNode;
-use DemoApp\AbstractKernel;
-use DemoApp\DefaultKernel;
 use PHPUnit\Framework\Assert;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Yoanm\JsonRpcServer\Domain\JsonRpcMethodInterface;
 
 /**
  * Defines application features from the specific context.
  */
-class DemoAppContext implements Context
+class DemoAppContext extends AbstractContext
 {
     /** @var Response|null */
     private $lastResponse;
@@ -23,14 +19,11 @@ class DemoAppContext implements Context
      */
     public function whenISendFollowingPayloadToDemoApp($httpMethod, $uri, PyStringNode $payload)
     {
-        $this->lastResponse = null;
-
-        $kernel = $this->getDemoAppKernel();
-        $kernel->boot();
-        $request = Request::create($uri, $httpMethod, [], [], [], [], $payload->getRaw());
-        $this->lastResponse = $kernel->handle($request);
-        $kernel->terminate($request, $this->lastResponse);
-        $kernel->shutdown();
+        $this->lastResponse = $this->sendHttpContentTo(
+            $uri,
+            $httpMethod,
+            $payload->getRaw()
+        );
     }
 
     /**
@@ -41,8 +34,8 @@ public function thenIShouldHaveAResponseFromDemoAppWithFollowingContent($httpCod
         Assert::assertInstanceOf(Response::class, $this->lastResponse);
         // Decode payload to get ride of indentation, spacing, etc
         Assert::assertEquals(
-            json_decode($payload->getRaw(), true),
-            json_decode($this->lastResponse->getContent(), true)
+            $this->jsonDecode($payload->getRaw()),
+            $this->jsonDecode($this->lastResponse->getContent())
         );
         Assert::assertSame((int) $httpCode, $this->lastResponse->getStatusCode());
     }
@@ -76,15 +69,4 @@ public function thenCollectorShouldHaveAMethodWithName($methodClass, $methodName
             sprintf('Method "%s" is not an instance of "%s"', $methodName, $methodClass)
         );
     }
-
-    /**
-     * @return AbstractKernel
-     */
-    protected function getDemoAppKernel()
-    {
-        $env = 'prod';
-        $debug = true;
-
-        return new DefaultKernel($env, $debug);
-    }
 }