Improve (#3)

Author: yoanm

.scrutinizer.yml

@@ -15,18 +15,14 @@ build:
     tests:
         stop_on_failure: true
         override:
-            - php-scrutinizer-run --enable-security-analysis
-            -
-                command: make codestyle
-                analysis:
-                      file: 'build/reports/cs-data'
-                      format: 'php-cs-checkstyle'
             -
                 command: make coverage
                 idle_timeout: 1200
                 coverage:
                     file: 'build/coverage/clover.xml'
                     format: 'php-clover'
+            - php-scrutinizer-run --enable-security-analysis
+            - make codestyle
     cache:
         directories:
             - ~/.composer
@@ -39,8 +35,6 @@ build:
             COMPOSER_OPTIONS: '--optimize-autoloader'
             COVERAGE_OUTPUT_STYLE: 'clover'
             COVERAGE_CLOVER_FILE_PATH: 'build/coverage/clover.xml'
-            PHPCS_REPORT_STYLE: 'checkstyle'
-            PHPCS_REPORT_FILE: 'build/reports/cs-data'
         php:
             version: "7.1"
         timezone: UTC

.travis.yml

@@ -1,16 +1,19 @@
 language: php
 
 php:
-  - '7.0'
   - '7.1'
   - '7.2'
+  - '7.3'
 
 env:
   global:
     CI: 'true'
     TEST_OUTPUT_STYLE: 'pretty'
     PHPCS_REPORT_STYLE: 'full'
     COMPOSER_OPTIONS: '--optimize-autoloader'
+  matrix:
+  - SYMFONY_VERSION: '~3.0'
+  - SYMFONY_VERSION: '~4.0'
 
 sudo: false
 
@@ -19,9 +22,10 @@ matrix:
 
 before_install:
   # remove xdebug to speed up build
-  - phpenv config-rm xdebug.ini
+  - phpenv config-rm xdebug.ini || true
 
 install:
+  - composer require symfony/http-kernel:$SYMFONY_VERSION symfony/dependency-injection:$SYMFONY_VERSION
   - make build
 script:
   - make test-technical

composer.json

@@ -3,6 +3,7 @@
     "description": "Symfony bundle for easy JSON-RPC server OpenAPI 3.0.0 documentation",
     "license": "MIT",
     "type": "library",
+    "minimum-stability": "dev",
     "support": {
         "issues": "https://github.com/yoanm/symfony-jsonrpc-http-server-openapi-doc/issues"
     },
@@ -25,13 +26,11 @@
         }
     },
     "require": {
-        "php": ">=5.5",
-        "yoanm/jsonrpc-server-doc-sdk": "dev-feature/improve",
-        "yoanm/jsonrpc-http-server-openapi-doc-sdk": "dev-feature/improve",
-        "yoanm/symfony-jsonrpc-http-server-doc": "dev-feature/improve",
-        "symfony/http-foundation": "^3.0 || ^4.0",
+        "php": ">=7.1",
+        "yoanm/jsonrpc-server-doc-sdk": "dev-release/1.0.0",
+        "yoanm/jsonrpc-http-server-openapi-doc-sdk": "dev-release/1.0.0",
+        "yoanm/symfony-jsonrpc-http-server-doc": "dev-release/0.1.0",
         "symfony/http-kernel": "^3.0 || ^4.0",
-        "symfony/config": "^3.0 || ^4.0",
         "symfony/dependency-injection": "^3.0 || ^4.0"
     },
     "require-dev": {

src/Event/OpenAPIDocCreatedEvent.php

@@ -1,7 +1,7 @@
 <?php
 namespace Yoanm\SymfonyJsonRpcHttpServerOpenAPIDoc\Event;
 
-use Yoanm\JsonRpcServerDoc\Model\HttpServerDoc;
+use Yoanm\JsonRpcServerDoc\Domain\Model\HttpServerDoc;
 use Yoanm\SymfonyJsonRpcHttpServerDoc\Event\DocEvent;
 
 /**
@@ -17,11 +17,14 @@ class OpenAPIDocCreatedEvent extends DocEvent
     private $serverDoc;
 
     /**
-     * @param array                     $openAPIDoc
+     * @param array              $openAPIDoc
      * @param HttpServerDoc|null $serverDoc
      */
-    public function __construct(array $openAPIDoc, HttpServerDoc $serverDoc = null)
-    {
+    public function __construct(
+        array $openAPIDoc,
+        HttpServerDoc $serverDoc = null
+    ) {
+
         $this->openAPIDoc = $openAPIDoc;
         $this->serverDoc = $serverDoc;
     }

src/Provider/DocProvider.php

@@ -3,7 +3,7 @@
 
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Yoanm\JsonRpcHttpServerOpenAPIDoc\Normalizer\DocNormalizer;
-use Yoanm\JsonRpcServerDoc\Model\HttpServerDoc;
+use Yoanm\JsonRpcServerDoc\Domain\Model\HttpServerDoc;
 use Yoanm\SymfonyJsonRpcHttpServerDoc\Creator\HttpServerDocCreator;
 use Yoanm\SymfonyJsonRpcHttpServerDoc\Provider\DocProviderInterface;
 use Yoanm\SymfonyJsonRpcHttpServerOpenAPIDoc\Event\OpenAPIDocCreatedEvent;

src/Resources/config/services.sdk.yaml

@@ -31,7 +31,6 @@ services:
   json_rpc_http_server_open_api_doc_sdk.normalizer.component.error:
     class: Yoanm\JsonRpcHttpServerOpenAPIDoc\Normalizer\Component\ErrorDocNormalizer
     arguments:
-     - '@json_rpc_http_server_open_api_doc_sdk.resolver.definition_ref'
      - '@json_rpc_http_server_open_api_doc_sdk.normalizer.component.parameter_doc'
      - '@json_rpc_http_server_open_api_doc_sdk.normalizer.component.shape'
   json_rpc_http_server_open_api_doc_sdk.normalizer.component.external_schema_list: