Polish (#9)

Author: yoanm

.travis.yml

@@ -25,7 +25,7 @@ before_install:
   - phpenv config-rm xdebug.ini || true
 
 install:
-  - composer require symfony/http-foundation:$SYMFONY_VERSION symfony/http-kernel:$SYMFONY_VERSION symfony/config:$SYMFONY_VERSION symfony/dependency-injection:$SYMFONY_VERSION
+  - composer require symfony/http-kernel:$SYMFONY_VERSION symfony/config:$SYMFONY_VERSION symfony/dependency-injection:$SYMFONY_VERSION
   - make build
 script:
   - make test-technical
@@ -35,3 +35,7 @@ cache:
   directories:
     - $HOME/.composer
     - vendor
+
+branches:
+  except:
+  - /.*\-dev$/

README.md

@@ -1,5 +1,5 @@
 # JSON-RPC server documentation
-[![License](https://img.shields.io/github/license/yoanm/symfony-jsonrpc-http-server-doc.svg)](https://github.com/yoanm/symfony-jsonrpc-http-server-doc) [![Code size](https://img.shields.io/github/languages/code-size/yoanm/symfony-jsonrpc-http-server-doc.svg)](https://github.com/yoanm/symfony-jsonrpc-http-server-doc)
+[![License](https://img.shields.io/github/license/yoanm/symfony-jsonrpc-http-server-doc.svg)](https://github.com/yoanm/symfony-jsonrpc-http-server-doc) [![Code size](https://img.shields.io/github/languages/code-size/yoanm/symfony-jsonrpc-http-server-doc.svg)](https://github.com/yoanm/symfony-jsonrpc-http-server-doc) [![Dependencies](https://img.shields.io/librariesio/github/yoanm/symfony-jsonrpc-http-server-doc.svg)](https://libraries.io/packagist/yoanm%2Fsymfony-jsonrpc-http-server-doc)
 
 [![Scrutinizer Build Status](https://img.shields.io/scrutinizer/build/g/yoanm/symfony-jsonrpc-http-server-doc.svg?label=Scrutinizer&logo=scrutinizer)](https://scrutinizer-ci.com/g/yoanm/symfony-jsonrpc-http-server-doc/build-status/master) [![Scrutinizer Code Quality](https://img.shields.io/scrutinizer/g/yoanm/symfony-jsonrpc-http-server-doc/master.svg?logo=scrutinizer)](https://scrutinizer-ci.com/g/yoanm/symfony-jsonrpc-http-server-doc/?branch=master) [![Code Coverage](https://img.shields.io/scrutinizer/coverage/g/yoanm/symfony-jsonrpc-http-server-doc/master.svg?logo=scrutinizer)](https://scrutinizer-ci.com/g/yoanm/symfony-jsonrpc-http-server-doc/?branch=master)
 

composer.json

@@ -26,10 +26,16 @@
       "DemoApp\\": "features/demo_app/src"
     }
   },
+  "suggest": {
+    "yoanm/symfony-jsonrpc-http-server": "Symfony Bundle to convert an HTTP json-rpc request into HTTP json-rpc response",
+    "yoanm/symfony-jsonrpc-params-sf-constraints-doc": "Symfony bundle for easy Symfony constraints to JSON-RPC documentation transformation",
+    "yoanm/symfony-jsonrpc-http-server-openapi-doc": "Symfony bundle for easy JSON-RPC server OpenAPI 3.0.0 documentation",
+    "yoanm/symfony-jsonrpc-http-server-swagger-doc": "Symfony bundle for easy JSON-RPC server Swagger 2.0 documentation"
+  },
   "require": {
     "php": ">=7.1",
     "yoanm/jsonrpc-server-sdk": "dev-release/3.0.0",
-    "yoanm/jsonrpc-server-doc-sdk": "dev-release/1.0.0",
+    "yoanm/jsonrpc-server-doc-sdk": "dev-release/0.1.0",
     "yoanm/symfony-jsonrpc-http-server": "dev-release/2.0.0",
     "symfony/http-kernel": "^3.0 || ^4.0",
     "symfony/config": "^3.0 || ^4.0",

features/bootstrap/DemoAppContext.php

@@ -9,7 +9,6 @@
 use PHPUnit\Framework\Assert;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Yoanm\JsonRpcServer\Domain\JsonRpcMethodInterface;
 
 /**
  * Defines application features from the specific context.
@@ -70,36 +69,6 @@ public function thenIShouldHaveAResponseFromDemoAppWithFollowingContent($httpCod
         Assert::assertSame((int) $httpCode, $this->lastResponse->getStatusCode());
     }
 
-    /**
-     * @Then Collector should have :methodClass JSON-RPC method with name :methodName
-     */
-    public function thenCollectorShouldHaveAMethodWithName($methodClass, $methodName)
-    {
-        $kernel = $this->getDemoAppKernel();
-        $kernel->boot();
-        $mappingList = $kernel->getContainer()
-            ->get('mapping_aware_service')
-            ->getMappingList()
-        ;
-        $kernel->shutdown();
-
-        if (!isset($mappingList[$methodName])) {
-            throw new \Exception(sprintf('No mapping defined to method name "%s"', $methodName));
-        }
-        $method = $mappingList[$methodName];
-
-        Assert::assertInstanceOf(
-            JsonRpcMethodInterface::class,
-            $method,
-            'Method must be a JsonRpcMethodInterface instance'
-        );
-        Assert::assertInstanceOf(
-            $methodClass,
-            $method,
-            sprintf('Method "%s" is not an instance of "%s"', $methodName, $methodClass)
-        );
-    }
-
     /**
      * @return AbstractKernel
      */

src/DependencyInjection/JsonRpcHttpServerDocExtension.php

@@ -30,7 +30,7 @@ public function load(array $configs, ContainerBuilder $container)
 
         $loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
 
-        $loader->load('services.sdk.yaml');
+        $loader->load('services.sdk.infra.yaml');
         $loader->load('services.private.yaml');
         $loader->load('services.public.yaml');
     }

src/Resources/config/services.sdk.yaml renamed to src/Resources/config/services.sdk.infra.yaml

@@ -12,6 +12,7 @@
 use Yoanm\SymfonyJsonRpcHttpServerDoc\Creator\HttpServerDocCreator;
 use Yoanm\SymfonyJsonRpcHttpServerDoc\Endpoint\DocumentationEndpoint;
 use Yoanm\SymfonyJsonRpcHttpServerDoc\Finder\NormalizedDocFinder;
+use Yoanm\SymfonyJsonRpcHttpServerDoc\Listener\ServerDocCreatedListener;
 use Yoanm\SymfonyJsonRpcHttpServerDoc\Provider\RawDocProvider;
 
 /**
@@ -127,6 +128,11 @@ public function provideBundlePrivateServiceIdAndClass()
                 'serviceClassName' => NormalizedDocFinder::class,
                 'public' => false,
             ],
+            'Bundle - Private - ServerDocCreatedListener' => [
+                'serviceId' => 'json_rpc_http_server_doc.listener.server_doc_created',
+                'serviceClassName' => ServerDocCreatedListener::class,
+                'public' => false,
+            ],
         ];
     }
 }