Improce CI

yoanm · yoanm · commit c40daacbec2a · 2025-09-02T07:39:43.000+02:00
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -1,4 +1,5 @@
 name: 'CI'
+
 on: # Build any PRs and main branch changes
   workflow_dispatch: # Allows to run the workflow manually from the Actions tab
   pull_request:
@@ -18,10 +19,16 @@ on: # Build any PRs and main branch changes
   schedule:
     - cron: '0 0 1 * *' # Every month
 
+permissions:
+  contents: read
+
 concurrency:
   group: "${{ github.workflow }}-${{ github.head_ref || github.ref }}"
   cancel-in-progress: true
 
+env:
+  TEST_OUTPUT_STYLE: pretty
+
 jobs:
   tests:
     name: Tests
diff --git a/.github/workflows/coverage-upload.yml b/.github/workflows/coverage-upload.yml
@@ -4,9 +4,13 @@ on:
     workflows: ["CI"]
     types: [completed]
 
+permissions:
+  contents: read
+  checks: write # For the check run creation !
+
 jobs:
   upload:
-    name: Upload
+    name: Coverage
     permissions:
       contents: read
       checks: write # For the check run creation !
diff --git a/.github/workflows/pre-check-CI-updates.yml b/.github/workflows/pre-check-CI-updates.yml
@@ -17,6 +17,10 @@ on:
       - '.github/workflows/reusable-CI-workflow.yml'
       - '.github/workflows/reusable-coverage-upload-workflow.yml'
 
+permissions:
+  contents: read
+  checks: write # For the check run creation !
+
 concurrency:
   group: "${{ github.workflow }}-${{ github.head_ref || github.ref }}"
   cancel-in-progress: true
@@ -29,7 +33,7 @@ jobs:
     uses: ./.github/workflows/reusable-CI-workflow.yml
 
   upload:
-    name: Upload
+    name: Coverage
     needs: [tests]
     permissions:
       contents: read
diff --git a/.github/workflows/reusable-CI-workflow.yml b/.github/workflows/reusable-CI-workflow.yml
@@ -3,105 +3,109 @@ name: 'CI reusable workflow'
 on:
   workflow_call:
 
+permissions:
+  contents: read
+
 env:
+  COMPOSER_PREFER_STABLE: '1'
   TEST_OUTPUT_STYLE: pretty
-  COMPOSER_OPTIONS: --optimize-autoloader
 
 jobs:
+  fetch-supported-versions:
+    name: Fetch supported versions
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    outputs:
+      php-min: ${{ steps.fetch-php-versions.outputs.min }}
+      php-max: ${{ steps.fetch-php-versions.outputs.max }}
+      php-next: ${{ steps.fetch-php-versions.outputs.next }}
+    steps:
+      - name: Fetch supported versions file
+        id: fetch-file
+        uses: yoanm/gha-supported-versions-parser/github-downloader@v1
+        with:
+          file-path: .github/workflows/supported-versions.json
+
+      - name: Fetch PHP supported versions
+        id: fetch-php-versions
+        uses: yoanm/gha-supported-versions-parser@v1
+        with:
+          path: ${{ steps.fetch-file.outputs.path }}
+          dependency: php
+
   tests:
-    name: PHP ${{ matrix.php-version }} & Symfony ${{ matrix.symfony-version }}
+    name: ${{ matrix.job-name }}
+    needs: [fetch-supported-versions]
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     env:
       COVERAGE_TYPE: none
+      COVERAGE_OUTPUT_STYLE: clover
     strategy:
       fail-fast: true
-      max-parallel: 4
       matrix:
         include:
-          # Bare minimum => Lowest versions allowed by composer config
-          - symfony-version: '4.4'
-            php-version: '8.0'
-            composer-flag: --prefer-lowest
-          # Up to date versions => Latest versions allowed by composer config
-          - symfony-version: '5.4'
-            php-version: '8.2'
-          # Late symfony migration => Lowest symfony version with latest minor php version allowed by composer config
-          - symfony-version: '4.4'
-            php-version: '8.2'
-            composer-flag: --prefer-lowest
-          # Late php migration => Latest symfony version with lowest minor php version allowed by composer config
-          - symfony-version: '5.4'
-            php-version: '8.0'
-          # Symfony 6.0 latest
-          - symfony-version: '6.0'
-            php-version: '8.2'
-          # Symfony 6.0 lowest
-          - symfony-version: '6.0'
-            php-version: '8.0'
-            composer-flag: --prefer-lowest
+          - job-name: Up to date versions # => Highest versions allowed by composer config
+            php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
+          - job-name: Bare minimum # => Lowest versions allowed by composer config
+            php-version: '${{ needs.fetch-supported-versions.outputs.php-min }}'
     steps:
       - name: Check out code
         uses: actions/checkout@v4
 
+      # Enable coverage only for specific version(s) !
+      # Usually highest version(s), plus additional ones in case of code used only with specific versions
       - name: Enable coverage
-        if: ${{ matrix.php-version == '8.2' }}
+        if: ${{ matrix.php-version == needs.fetch-supported-versions.outputs.php-max }}
         run: |
-          echo "COVERAGE_OUTPUT_STYLE=clover" >> $GITHUB_ENV
           echo "COVERAGE_TYPE=xdebug" >> $GITHUB_ENV
 
       - name: Setup PHP ${{ matrix.php-version }}
+        id: setup-php
         uses: shivammathur/setup-php@v2
         env:
-          update: true # Always use latest available patch for the version
+          update: true # whether to use latest available patch for the version or not
           fail-fast: true # step will fail if an extension or tool fails to set up
         with:
-          php-version: '${{ matrix.php-version }}'
+          php-version: ${{ matrix.php-version }}
           tools: composer
           coverage: ${{ env.COVERAGE_TYPE }}
 
-      - name: Setup cache
-        id: cache
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Setup cache for PHP ${{ steps.setup-php.outputs.php-version }}
         uses: actions/cache@v4
         with:
           path: |
-            ~/.composer
-            ./vendor
-          # Clear the cache if composer json (as composer.lock is in the repo) has been updated
-          key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ matrix.composer-flag }}-${{ hashFiles('composer.json') }}
+            ${{ steps.composer-cache.outputs.dir }}
+          # Clear the cache if composer.json (as composer.lock is not available) has been updated
+          key: tests-php${{ steps.setup-php.outputs.php-version }}-${{ hashFiles('composer.json') }}
 
-      - name: Build
-        run: |
-          SF_VERSION=${{ matrix.symfony-version }}
-          # Issue with ParamterBag below 4.4.30 => https://github.com/symfony/symfony/commit/3eca446b21607ea1c7a865ece2dd8254c33679cc
-          test '${{ matrix.symfony-version }}' = '4.4' && test '${{ matrix.php-version }}' = '8.2' && SF_VERSION=4.4.30
-          composer require -W ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \
-            symfony/validator:^$SF_VERSION \
-            symfony/intl:^$SF_VERSION \
-            symfony/expression-language:^$SF_VERSION \
-          && composer update ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \
-          && make build
+      - name: Build with PHP ${{ steps.setup-php.outputs.php-version }}
+        run: make build
 
       - name: Tests
         run: make test-unit && make test-functional
 
       - name: Create "unit tests" reports group
         if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
-        id: unit-tests-coverage-group
-        uses: yoanm/temp-reports-group-workspace/gha-create@v0
+        uses: yoanm/temp-reports-group-workspace/create-group@v0
         with:
           name: unit-tests
           format: clover
           files: build/coverage-phpunit/unit.clover
           flags: |
             unit-tests
             php-${{ matrix.php-version }}
-            sf-${{ matrix.symfony-version }}
           path: build/coverage-groups
 
-      - name: Create "functional tests" coverage group
+      - name: Create "functional tests" reports group
         if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
-        id: functional-tests-coverage-group
-        uses: yoanm/temp-reports-group-workspace/gha-create@v0
+        uses: yoanm/temp-reports-group-workspace/create-group@v0
         with:
           name: functional-tests
           format: clover
@@ -111,43 +115,51 @@ jobs:
           flags: |
             functional-tests
             php-${{ matrix.php-version }}
-            sf-${{ matrix.symfony-version }}
           path: build/coverage-groups
 
       - name: Upload coverage reports
         if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
         uses: actions/upload-artifact@v4
         with:
-          name: coverage-groups-php${{ matrix.php-version }}-sf${{ matrix.symfony-version }}
+          name: coverage-groups-php${{ steps.setup-php.outputs.php-version }}
           path: build/coverage-groups
           if-no-files-found: error
 
   static-checks:
     name: Static analysis
+    needs: [fetch-supported-versions]
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    env:
+      PHP_VERSION: ${{ needs.fetch-supported-versions.outputs.php-max }}
     steps:
       - uses: actions/checkout@v4
 
-      - name: Setup PHP 8.2
+      - name: Setup PHP ${{ env.PHP_VERSION }}
+        id: setup-php
         uses: shivammathur/setup-php@v2
+        env:
+          update: true # Always use latest available patch for the version
+          fail-fast: true # step will fail if an extension or tool fails to set up
         with:
-          php-version: 8.2 # Latest supported
+          php-version: ${{ env.PHP_VERSION }}
           tools: composer
           coverage: none
-        env:
-          # Always use latest available patch for the version
-          update: true
 
-      - name: Setup cache
-        id: cache
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Setup cache for PHP ${{ steps.setup-php.outputs.php-version }}
         uses: actions/cache@v4
         with:
           path: |
-            ~/.composer
-          # Clear the cache if composer json (as composer.lock is in the repo) has been updated
-          key: tests-${{ env.PHP_VERSION }}-${{ hashFiles('composer.json') }}
+            ${{ steps.composer-cache.outputs.dir }}
+          # Clear the cache if composer.json (as composer.lock is not available) has been updated
+          key: tests-php${{ steps.setup-php.outputs.php-version }}-${{ hashFiles('composer.json') }}
 
-      - name: Build
+      - name: Build with PHP ${{ steps.setup-php.outputs.php-version }}
         run: make build
 
       - name: ComposerRequireChecker
@@ -158,59 +170,45 @@ jobs:
         uses: actions/dependency-review-action@v4
 
   nightly-tests:
-    name: Nightly - PHP ${{ matrix.php-version }} & Symfony ${{ matrix.symfony-version }}
+    name: Nightly
+    needs: [ fetch-supported-versions, tests ]
+    if: ${{ github.event_name == 'push' || ( github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'with-nightly-tests') ) }}
     runs-on: ubuntu-latest
-    env:
-      COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+'
+    permissions:
+      contents: read
     continue-on-error: true
-    needs: [ static-checks, tests ]
-    strategy:
-      fail-fast: false
-      max-parallel: 4
-      matrix:
-        php-version:
-          - '8.3' # Current php dev version
-        symfony-version:
-          - '4.4' # Lowest LTS
-          - '5.4' # Latest LTS
-          - '6.0' # Current major version
-        include:
-          - symfony-version: '6.3' # Next symfony minor version to manage with latest supported PHP version
-            php-version: '8.2'
-
+    env:
+      PHP_VERSION: ${{ needs.fetch-supported-versions.outputs.php-next }}
+      COMPOSER_IGNORE_PLATFORM_REQ: 'php+'
     steps:
       - name: Check out code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
-      - name: Setup PHP ${{ matrix.php-version }}
+      - name: Setup PHP ${{ env.PHP_VERSION }}
+        id: setup-php
         uses: shivammathur/setup-php@v2
+        env:
+          update: true # whether to use latest available patch for the version or not
+          fail-fast: true # step will fail if an extension or tool fails to set up
         with:
-          php-version: '${{ matrix.php-version }}'
+          php-version: ${{ env.PHP_VERSION }}
           tools: composer
           coverage: none
-        env:
-          # Always use latest available patch for the version
-          update: true
 
-      - name: Setup cache
-        id: cache
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Setup cache for PHP ${{ steps.setup-php.outputs.php-version }}
         uses: actions/cache@v4
         with:
           path: |
-            ~/.composer
-            ./vendor
-          # Clear the cache if composer json (as composer.lock is in the repo) has been updated
-          key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ hashFiles('composer.json') }}
+            ${{ steps.composer-cache.outputs.dir }}
+          # Clear the cache if composer.json (as composer.lock is not available) has been updated
+          key: tests-php${{ steps.setup-php.outputs.php-version }}-${{ hashFiles('composer.json') }}
 
-      - name: Build
-        run: |
-          composer config minimum-stability dev \
-          && composer require -W ${{ env.COMPOSER_OPTIONS }} \
-            symfony/validator:^${{ matrix.symfony-version }} \
-            symfony/intl:^${{ matrix.symfony-version }} \
-            symfony/expression-language:^${{ matrix.symfony-version }} \
-          && composer update ${{ env.COMPOSER_OPTIONS }} \
-          && make build
+      - name: Build with PHP ${{ steps.setup-php.outputs.php-version }}
+        run: make build
 
       - name: Test
         run: make test-unit && make test-functional
diff --git a/.github/workflows/reusable-coverage-upload-workflow.yml b/.github/workflows/reusable-coverage-upload-workflow.yml
diff --git a/.github/workflows/supported-versions.json b/.github/workflows/supported-versions.json
