Improve (#9)

Author: yoanm

Makefile

@@ -6,6 +6,7 @@ COVERAGE_OUTPUT_STYLE ?= html
 BUILD_DIRECTORY ?= build
 REPORTS_DIRECTORY ?= ${BUILD_DIRECTORY}/reports
 COVERAGE_DIRECTORY ?= ${BUILD_DIRECTORY}/coverage
+BEHAT_COVERAGE_DIRECTORY ?= ${BUILD_DIRECTORY}/behat-coverage
 COVERAGE_CLOVER_FILE_PATH ?= ${COVERAGE_DIRECTORY}/clover.xml
 
 ## Commands options
@@ -88,15 +89,21 @@ codestyle: create-reports-directory
 coverage: create-coverage-directory
 	./vendor/bin/phpunit ${PHPUNIT_COLOR_OPTION} ${PHPUNIT_OUTPUT_STYLE_OPTION} ${PHPUNIT_COVERAGE_OPTION}
 
+behat-coverage: create-behat-coverage-directory
+	composer required leanphp/behat-code-coverage
+	./vendor/bin/behat ${BEHAT_COLOR_OPTION} ${BEHAT_OUTPUT_STYLE_OPTION} --no-snippets --profile coverage
 
 
 # Internal commands
 create-coverage-directory:
 	mkdir -p ${COVERAGE_DIRECTORY}
 
+create-behat-coverage-directory:
+	mkdir -p ${BEHAT_COVERAGE_DIRECTORY}
+
 create-reports-directory:
 	mkdir -p ${REPORTS_DIRECTORY}
 
 
-.PHONY: build install configure test test-technical test-functional codestyle coverage create-coverage-directory create-reports-directory
+.PHONY: build install configure test test-technical test-functional codestyle coverage behat-coverage create-coverage-directory create-behat-coverage-directory create-reports-directory
 .DEFAULT: build

behat.yml

@@ -3,3 +3,17 @@ default:
     default:
       contexts:
         - Tests\Functional\BehatContext\ConstraintTransformerContext: ~
+coverage:
+  extensions:
+    LeanPHP\Behat\CodeCoverage\Extension:
+      drivers:
+      - local
+      filter:
+        whitelist:
+          include:
+            directories:
+              'src': ~
+      report:
+        format:   html
+        options:
+          target: build/behat-coverage

phpunit.xml.dist

@@ -8,7 +8,6 @@
          processIsolation="false"
 
          stopOnRisky="true"
-
          stopOnError="true"
          stopOnFailure="true"
 

src/App/Helper/DocTypeHelper.php

@@ -25,6 +25,7 @@ class DocTypeHelper
 
     /**
      * @param ConstraintPayloadDocHelper $constraintPayloadDocHelper
+     * @param TypeGuesser                $typeGuesser
      */
     public function __construct(ConstraintPayloadDocHelper $constraintPayloadDocHelper, TypeGuesser $typeGuesser)
     {

src/App/Helper/StringDocHelper.php

@@ -12,8 +12,10 @@
 class StringDocHelper
 {
     /**
-     * @param TypeDoc $doc
+     * @param TypeDoc    $doc
      * @param Constraint $constraint
+     *
+     * @throws \ReflectionException
      */
     public function append(TypeDoc $doc, Constraint $constraint)
     {

src/Infra/Transformer/ConstraintToParamsDocTransformer.php

@@ -27,6 +27,8 @@ class ConstraintToParamsDocTransformer
 
     /**
      * @param DocTypeHelper              $docTypeHelper
+     * @param StringDocHelper            $stringDocHelper
+     * @param MinMaxHelper               $minMaxHelper
      * @param ConstraintPayloadDocHelper $constraintPayloadDocHelper
      */
     public function __construct(
@@ -45,6 +47,8 @@ public function __construct(
      * @param Constraint $constraint
      *
      * @return TypeDoc
+     *
+     * @throws \ReflectionException
      */
     public function transform(Constraint $constraint) : TypeDoc
     {
@@ -55,6 +59,8 @@ public function transform(Constraint $constraint) : TypeDoc
      * @param Constraint[] $constraintList
      *
      * @return TypeDoc
+     *
+     * @throws \ReflectionException
      */
     public function transformList(array $constraintList) : TypeDoc
     {
@@ -68,8 +74,10 @@ public function transformList(array $constraintList) : TypeDoc
     }
 
     /**
-     * @param TypeDoc $doc
-     * @param Constraint   $constraint
+     * @param TypeDoc    $doc
+     * @param Constraint $constraint
+     *
+     * @throws \ReflectionException
      */
     private function appendToDoc(TypeDoc $doc, Constraint $constraint) : void
     {
@@ -127,8 +135,10 @@ private function appendToDoc(TypeDoc $doc, Constraint $constraint) : void
     }
 
     /**
-     * @param TypeDoc $doc
+     * @param TypeDoc    $doc
      * @param Constraint $constraint
+     *
+     * @throws \ReflectionException
      */
     private function appendCollectionDoc(TypeDoc $doc, Constraint $constraint) : void
     {
@@ -185,6 +195,8 @@ private function appendValidItemListDoc(TypeDoc $doc, Constraint $constraint) :
     /**
      * @param ArrayDoc   $doc
      * @param Assert\All $constraint
+     *
+     * @throws \ReflectionException
      */
     private function appendAllConstraintToDoc(ArrayDoc $doc, Assert\All $constraint) : void
     {

tests/Functional/App/Helper/StringDocHelperTest.php

@@ -27,10 +27,12 @@ public function setUp()
     public function testShouldDoNothingIfNotAStringDoc()
     {
         $doc = new TypeDoc();
+        $constraint = $this->prophesize(Assert\Date::class);
 
-        $this->assertNull(
-            $this->helper->append($doc, $this->prophesize(Assert\Date::class)->reveal())
-        );
+        $this->helper->append($doc, $constraint->reveal());
+
+        // there only to avoid "This test did not perform any assertions" issue
+        $this->assertNull(null);
     }
 
     /**