Skip to content

Commit c69f304

Browse files
committed
Update sidecar version
1 parent 3ade0cb commit c69f304

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

src/comm.lisp

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@
1111
(kernel
1212
:initarg :kernel
1313
:initform *kernel*
14-
:reader comm-kernel))
14+
:reader comm-kernel)
15+
(on-close
16+
:initarg :on-close
17+
:initform nil
18+
:accessor comm-on-close
19+
:documentation "Instance specific close notification"))
1520
(:default-initargs
1621
:sink (when *kernel*
1722
(source-sink *kernel*))))
@@ -26,15 +31,22 @@
2631

2732
(defgeneric on-comm-open (comm data metadata buffers))
2833

29-
(defmethod on-comm-open (comm data metadata buffers))
34+
(defmethod on-comm-open (comm data metadata buffers)
35+
(declare (ignore comm data metadata buffers)))
3036

3137
(defgeneric on-comm-message (comm data metadata buffers))
3238

33-
(defmethod on-comm-message (comm data metadata buffers))
39+
(defmethod on-comm-message (comm data metadata buffers)
40+
(declare (ignore comm data metadata buffers)))
3441

3542
(defgeneric on-comm-close (comm data metadata buffers))
3643

37-
(defmethod on-comm-close (comm data metadata buffers))
44+
(defmethod on-comm-close (comm data metadata buffers)
45+
(declare (ignore comm data metadata buffers)))
46+
47+
(defmethod on-comm-close :after ((comm comm) data metadata buffers)
48+
(dolist (func (comm-on-close comm))
49+
(funcall func comm data metadata buffers)))
3850

3951
(defun send-comm-open (comm &optional data metadata buffers)
4052
(with-slots (comm-id kernel target-name) comm

src/widgets/widget.lisp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
(defparameter +output-module+ "@jupyter-widgets/output")
99
(defparameter +output-module-version+ "1.0.0")
1010
(defparameter +sidecar-module+ "@jupyter-widgets/jupyterlab-sidecar")
11-
(defparameter +sidecar-module-version+ "1.0.0")
11+
(defparameter +sidecar-module-version+ "1.1.0")
1212

1313
(defparameter +target-name+ "jupyter.widget")
1414

0 commit comments

Comments
 (0)