feat(): Enable strict rules and bleeding edge analysis, and update README.md with strict configuration examples. (#29)

terabytesoftw · web-flow · commit b910ed8be4f3 · 2025-06-06T17:44:16.000-04:00
diff --git a/.github/workflows/dependency-check.yml b/.github/workflows/dependency-check.yml
@@ -26,4 +26,4 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.1']
+        ['8.4']
diff --git a/.github/workflows/ecs.yml b/.github/workflows/ecs.yml
@@ -28,4 +28,4 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.1']
+        ['8.4']
diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml
@@ -30,4 +30,4 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.1']
+        ['8.4']
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,10 +2,11 @@
 
 ## 0.2.3 June 06, 2025
 
-- Enh #25: Add support for PHPStan Extension Installer (@samuelrajan747)
-- Enh #26: Add PHPStan extension installer instructions and improve `ServiceMap` configuration handling (@terabytesoftw)
+- Enh #25: Add support for `PHPStan` Extension Installer (@samuelrajan747)
+- Enh #26: Add `PHPStan` extension installer instructions and improve `ServiceMap` configuration handling (@terabytesoftw)
 - Bug #27: Enhance error handling in `ServiceMap` for invalid configuration structures and add corresponding test cases (@terabytesoftw)
 - Bug #28: Refactor component handling in `ServiceMap` to improve variable naming and streamline logic (@terabytesoftw)
+- Enh #29: Enable strict rules and bleeding edge analysis, and update `README.md` with strict configuration examples (@terabytesoftw)
 
 ## 0.2.2 June 04, 2025
 
diff --git a/README.md b/README.md
@@ -119,10 +119,12 @@ constants.
 To maintain the `Yii2` constants recognition, you must include them explicitly along with your custom constants, as
 shown above.
 
-### Advanced Configuration Example
+### Strict Configuration
 
 ```neon
 includes:
+    - phar://phpstan.phar/conf/bleedingEdge.neon
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
     - vendor/yii2-extensions/phpstan/extension.neon
 
 parameters:
@@ -154,6 +156,16 @@ parameters:
 
     yii2:
         config_path: %currentWorkingDirectory%/config/web.php
+
+    # Enable strict advanced checks
+    checkImplicitMixed: true
+    checkBenevolentUnionTypes: true
+    checkUninitializedProperties: true
+    checkMissingCallableSignature: true
+    checkTooWideReturnTypesInProtectedAndPublicMethods: true
+    reportAnyTypeWideningInVarTag: true
+    reportPossiblyNonexistentConstantArrayOffset: true
+    reportPossiblyNonexistentGeneralArrayOffset: true    
 ```
 
 ### PHPstan extension installer
diff --git a/composer.json b/composer.json
@@ -16,6 +16,7 @@
     "require-dev": {
         "maglnet/composer-require-checker": "^4.7",
         "phpstan/phpstan-phpunit": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0.3",
         "phpunit/phpunit": "^10.2",
         "symplify/easy-coding-standard": "^12.1"
     },
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,8 +1,7 @@
 includes:
-	- extension.neon
-	- vendor/phpstan/phpstan-phpunit/extension.neon
-	- vendor/phpstan/phpstan-phpunit/rules.neon
-	- phar://phpstan.phar/conf/bleedingEdge.neon
+    - extension.neon
+    - phar://phpstan.phar/conf/bleedingEdge.neon
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
 
 parameters:
     bootstrapFiles:
@@ -16,3 +15,13 @@ parameters:
 
     paths:
         - src
+
+    # Enable strict advanced checks
+    checkImplicitMixed: true
+    checkBenevolentUnionTypes: true
+    checkUninitializedProperties: true
+    checkMissingCallableSignature: true
+    checkTooWideReturnTypesInProtectedAndPublicMethods: true
+    reportAnyTypeWideningInVarTag: true
+    reportPossiblyNonexistentConstantArrayOffset: true
+    reportPossiblyNonexistentGeneralArrayOffset: true
diff --git a/src/reflection/ApplicationPropertiesClassReflectionExtension.php b/src/reflection/ApplicationPropertiesClassReflectionExtension.php
@@ -142,6 +142,6 @@ public function hasProperty(ClassReflection $classReflection, string $propertyNa
 
         return $classReflection->hasNativeProperty($propertyName)
             || $this->annotationsProperties->hasProperty($classReflection, $propertyName)
-            || $this->serviceMap->getComponentClassById($propertyName);
+            || $this->serviceMap->getComponentClassById($propertyName) !== null;
     }
 }
diff --git a/src/type/ActiveQueryDynamicMethodReturnTypeExtension.php b/src/type/ActiveQueryDynamicMethodReturnTypeExtension.php
@@ -62,6 +62,8 @@ final class ActiveQueryDynamicMethodReturnTypeExtension implements DynamicMethod
      * Returns the class name for which this dynamic return type extension applies.
      *
      * @return string Fully qualified class name of the supported class.
+     *
+     * @phpstan-return class-string
      */
     public function getClass(): string
     {
diff --git a/src/type/ActiveRecordDynamicMethodReturnTypeExtension.php b/src/type/ActiveRecordDynamicMethodReturnTypeExtension.php
@@ -13,7 +13,6 @@
 use yii\db\ActiveRecord;
 
 use function count;
-use function get_class;
 use function in_array;
 use function sprintf;
 
@@ -60,6 +59,8 @@ final class ActiveRecordDynamicMethodReturnTypeExtension implements DynamicMetho
      * autocompletion for dynamic relation definitions.
      *
      * @return string Fully qualified class name of the supported {@see ActiveRecord} class.
+     *
+     * @phpstan-return class-string
      */
     public function getClass(): string
     {
@@ -90,13 +91,12 @@ public function getTypeFromMethodCall(
         MethodCall $methodCall,
         Scope $scope,
     ): Type {
-        $arg = $methodCall->args[0];
+        $arg = $methodCall->getRawArgs()[0] ?? null;
 
         if ($arg instanceof Arg === false) {
             throw new ShouldNotHappenException(
                 sprintf(
-                    'Unexpected arg %s during method call %s at line %d',
-                    get_class($arg),
+                    'Invalid or missing argument for method %s at line %d',
                     $methodReflection->getName(),
                     $methodCall->getLine(),
                 ),
diff --git a/src/type/ActiveRecordDynamicStaticMethodReturnTypeExtension.php b/src/type/ActiveRecordDynamicStaticMethodReturnTypeExtension.php
@@ -68,6 +68,8 @@ public function __construct(private readonly ReflectionProvider $reflectionProvi
      * return type inference is applied to the correct class hierarchy during static analysis and IDE autocompletion.
      *
      * @return string Fully qualified class name of the supported {@see ActiveRecord} class.
+     *
+     * @phpstan-return class-string
      */
     public function getClass(): string
     {
diff --git a/src/type/ContainerDynamicMethodReturnTypeExtension.php b/src/type/ContainerDynamicMethodReturnTypeExtension.php
@@ -56,6 +56,8 @@ public function __construct(private readonly ServiceMap $serviceMap) {}
      * return type logic is applied to service resolution calls.
      *
      * @return string Fully qualified class name of the supported container class.
+     *
+     * @phpstan-return class-string
      */
     public function getClass(): string
     {
diff --git a/src/type/HeaderCollectionDynamicMethodReturnTypeExtension.php b/src/type/HeaderCollectionDynamicMethodReturnTypeExtension.php
@@ -48,6 +48,19 @@
  */
 final class HeaderCollectionDynamicMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
+    /**
+     * Returns the class name for which this dynamic return type extension applies.
+     *
+     * Specifies the fully qualified class name of the Yii {@see HeaderCollection} class that this extension targets
+     * for dynamic return type inference in PHPStan analysis.
+     *
+     * This enables PHPStan to apply custom return type logic for the {@see HeaderCollection::get()} method, supporting
+     * accurate type inference and IDE autocompletion for header value retrieval in Yii HTTP handling.
+     *
+     * @return string Fully qualified class name of the supported header collection class.
+     *
+     * @phpstan-return class-string
+     */
     public function getClass(): string
     {
         return HeaderCollection::class;
@@ -61,12 +74,14 @@ public function getTypeFromMethodCall(
         MethodCall $methodCall,
         Scope $scope,
     ): Type {
-        if (count($methodCall->args) < 3) {
+        $args = $methodCall->getArgs();
+
+        if (count($args) < 3) {
             return new StringType();
         }
 
         /** @var Arg $arg */
-        $arg = $methodCall->args[2];
+        $arg = $args[2] ?? null;
 
         if ($arg->value instanceof ConstFetch) {
             $value = $arg->value->name->getParts()[0];

-Original file line number
+Diff line change
       os: >-
         ['ubuntu-latest']
       php: >-
 -        ['8.1']
 +        ['8.4']
Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,6 @@ public function hasProperty(ClassReflection $classReflection, string $propertyNa`
`142`	`142`
`143`	`143`	`return $classReflection->hasNativeProperty($propertyName)`
`144`	`144`	`\|\| $this->annotationsProperties->hasProperty($classReflection, $propertyName)`
`145`		`- \|\| $this->serviceMap->getComponentClassById($propertyName);`
	`145`	`+ \|\| $this->serviceMap->getComponentClassById($propertyName) !== null;`
`146`	`146`	`}`
`147`	`147`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,8 @@ final class ActiveQueryDynamicMethodReturnTypeExtension implements DynamicMethod`
`62`	`62`	`* Returns the class name for which this dynamic return type extension applies.`
`63`	`63`	`*`
`64`	`64`	`* @return string Fully qualified class name of the supported class.`
	`65`	`+ *`
	`66`	`+ * @phpstan-return class-string`
`65`	`67`	`*/`
`66`	`68`	`public function getClass(): string`
`67`	`69`	`{`