Skip to content
This repository was archived by the owner on Sep 14, 2022. It is now read-only.

Commit 6a94bf1

Browse files
committed
refactor
1 parent 0562696 commit 6a94bf1

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/App.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,6 @@ export const App: FC = () => {
4747
(async () => setLinter(await loadDemoLinter()))();
4848
}, []);
4949

50-
const handleCodeEditing = (code: string) => {
51-
setCode(code);
52-
};
53-
5450
const handleRuleEditing = (ruleStr: string) => {
5551
try {
5652
const rules = JSON5.parse(ruleStr);
@@ -100,7 +96,7 @@ export const App: FC = () => {
10096
<Tab eventKey="code" title="Code">
10197
<CodeEditor
10298
initial={queryParamsState.get().code || DEFAULT_CODE}
103-
onChange={handleCodeEditing}
99+
onChange={setCode}
104100
messages={messages}
105101
/>
106102
</Tab>

src/components/CodeEditor.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,15 @@ interface Props {
1010
messages?: Linter.LintMessage[];
1111
}
1212

13+
function toMarkerPos (pos: number): number {
14+
return pos - 1;
15+
}
16+
1317
function messageToMarker(message: Linter.LintMessage): Marker {
14-
const from = { line: message.line - 1, ch: message.column - 1 };
18+
const from = { line: toMarkerPos(message.line), ch: toMarkerPos(message.column) };
1519
const to = {
16-
line: (message.endLine || message.line) - 1,
17-
ch: (message.endColumn || message.column) - 1,
20+
line: toMarkerPos(message.endLine || message.line) - 1,
21+
ch: toMarkerPos(message.endColumn || message.column) - 1,
1822
};
1923
return [from, to];
2024
}

0 commit comments

Comments
 (0)